d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Always panic if an invalid capability is passed to capable(..) instead of

Browse Source 
just with INVARIANTS

rwatson's point was valid in the sense that if the data passed at runtime is
invalid, it should always trip the invariant, not just in the debug case.
This is a deterrent against malicious input, or input caused by hardware
errors.

MFC after: 4 days
X-MFC with: r302577
Requested by: rwatson
Sponsored by: EMC / Isilon Storage Division
This commit is contained in:
Enji Cooper 2016-07-14 13:55:38 +00:00
parent 70e3da3892
commit e5619a893e
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=302841
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sys/dev/drm2/drm_os_freebsd.h
View File

@ -439,8 +439,7 @@ capable(enum __drm_capabilities cap)
case CAP_SYS_ADMIN:
return DRM_SUSER(curthread);
default:
KASSERT(false,
("%s: unhandled capability: %0x", __func__, cap));
panic("%s: unhandled capability: %0x", __func__, cap);
return (false);
}
}