From e5912dcf20718573bdb694b085d1cf3bc10a2eb5 Mon Sep 17 00:00:00 2001 From: Mateusz Piotrowski <0mp@FreeBSD.org> Date: Fri, 20 Nov 2020 14:37:07 +0000 Subject: [PATCH] Revert r367291 (KEYWORD: shutdown for rc.d/zfs) The problem is that zfs is asked to stop too early in the shutdown sequence. Other services, such as syslog may still be running and have some files open (e.g., under /var/log). This of course causes the messages like: cannot unmount '/var/run': umount failed cannot unmount '/var/log': umount failed cannot unmount '/var': umount failed cannot unmount '/usr/home': umount failed cannot unmount '/usr': umount failed cannot unmount '/': umount failed For now, let's remove the shutdown KEYWORD from the zfs service, as people are reporting problems in their setups: https://lists.freebsd.org/pipermail/freebsd-current/2020-November/077559.html In the future, we may think of stopping zfs on shutdown after all the other services and just before init(8) exits. Another interesting option might be to a new rcorder(8) KEYWORD like "shutdownjail", but this idea would need to be discussed a bit. Reported by: Johan Hendriks Reported by: Yasuhiro KIMURA Reported by: Tomoaki AOKI Approved by: kevans (src) MFC: 3 days Differential Revision: https://reviews.freebsd.org/D27263 --- libexec/rc/rc.d/zfs | 1 - 1 file changed, 1 deletion(-) diff --git a/libexec/rc/rc.d/zfs b/libexec/rc/rc.d/zfs index 102023175709..2d35f9b54642 100755 --- a/libexec/rc/rc.d/zfs +++ b/libexec/rc/rc.d/zfs @@ -6,7 +6,6 @@ # PROVIDE: zfs # REQUIRE: zfsbe # BEFORE: FILESYSTEMS var -# KEYWORD: shutdown . /etc/rc.subr