d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lock_profile_release_lock: do not compare unsigned with zero

Browse Source 
Found by:	Coverity Prevent
CID:		3660
Reviewed by:	jhb
MFC after:	2 weeks
This commit is contained in:
Andriy Gapon 2010-06-17 10:15:13 +00:00
parent 2e983ace8f
commit e7154e7ef1
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=209247
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/kern/subr_lock.c
View File

@ -598,7 +598,7 @@ lock_profile_release_lock(struct lock_object *lo)
struct lock_profile_object *l;
struct lock_prof_type *type;
struct lock_prof *lp;
u_int64_t holdtime;
u_int64_t curtime, holdtime;
struct lpohead *head;
int spin;
@ -626,9 +626,11 @@ lock_profile_release_lock(struct lock_object *lo)
lp = lock_profile_lookup(lo, spin, l->lpo_file, l->lpo_line);
if (lp == NULL)
goto release;
holdtime = nanoseconds() - l->lpo_acqtime;
if (holdtime < 0)
curtime = nanoseconds();
if (curtime < l->lpo_acqtime)
goto release;
holdtime = curtime - l->lpo_acqtime;
/*
* Record if the lock has been held longer now than ever
* before.