d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

The default value of net.graph.nonstandard_pppoe is changed to -1,

Browse Source 
which means "always stay in the standard mode of PPPoE operation
regardless of any junk floating around."

As the referenced PR stated clearly, the old default setting of 0
was extremely dangerous because it opened a possibility for a
spurious frame not only to put down a single PPPoE node running
FreeBSD, but to plague *every* FreeBSD node in a PPPoE network in
such a way that those nodes would keep poisoning each other until
rebooted simultaneously.

PR:		kern/47920
Reviewed by:	Gleb Smirnoff <glebius <at> cell.sick.ru>
MFC after:	1 week
This commit is contained in:
Yaroslav Tykhiy 2003-12-19 16:03:28 +00:00
parent 05f768d918
commit e883537ce7
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=123671
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/netgraph/ng_pppoe.c
View File

@ -246,9 +246,9 @@ struct ether_header eh_prototype =
ETHERTYPE_PPPOE_DISC};
#define PPPOE_KEEPSTANDARD -1 /* never switch to nonstandard mode */
#define PPPOE_STANDARD 0 /* try standard mode (default) */
#define PPPOE_STANDARD 0 /* try standard mode (dangerous!) */
#define PPPOE_NONSTANDARD 1 /* just be in nonstandard mode */
static int pppoe_mode = PPPOE_STANDARD;
static int pppoe_mode = PPPOE_KEEPSTANDARD;
static int
ngpppoe_set_ethertype(SYSCTL_HANDLER_ARGS)