From e8f26e5dc859a8fbc663e108421f657325ca3054 Mon Sep 17 00:00:00 2001 From: Warner Losh Date: Mon, 11 Oct 2021 11:13:39 -0600 Subject: [PATCH] bootstrap: No need to disable shared libraries for bootstrap tools There's no need to disable shared libraries when building the bootstrap tools. This was added on 2000 (commit ad879ce9552c) when the perl bootstrap was added (libperl and miniperl) and saved a fair amount of time (perl took a long time to build on 2000-era hardware). For many years now, however, we rarely build any libraries when bootstrapping. Even when we do, the optimization saves at most a few seconds when upgrading since the libraries built have been small. Shared libraries are more robust accross versions that static libraries due to creaping dependencies (we aren't crossing versions of share libraries, though, just using what's on the host). In addition, linux and macos have been building like this for some time because static binaries on those systems are difficult to impossible. Sponsored by: Netflix Reviewed by: arichardson, bapt Differential Revision: https://reviews.freebsd.org/D32443 --- Makefile.inc1 | 1 - 1 file changed, 1 deletion(-) diff --git a/Makefile.inc1 b/Makefile.inc1 index 9b81d4029608..fb640eefdb82 100644 --- a/Makefile.inc1 +++ b/Makefile.inc1 @@ -720,7 +720,6 @@ BSARGS= DESTDIR= \ -DNO_CPU_CFLAGS \ -DNO_LINT \ -DNO_PIC \ - -DNO_SHARED \ MK_ASAN=no \ MK_CTF=no \ MK_CLANG_EXTRAS=no \