Add a comment indicating that the vnode locking in this section of the
kernel linker code may be wrong: it fails to hold a lock across the call to VOP_GETATTR(), and vn_rdwr() with IO_NODELOCKED.
This commit is contained in:
parent
c5c76bdb10
commit
ea117ca465
@ -1370,6 +1370,9 @@ linker_lookup_file(const char *path, int pathlen,
|
||||
* Lookup KLD which contains requested module in the "linker.hints" file.
|
||||
* If version specification is available, then try to find the best KLD.
|
||||
* Otherwise just find the latest one.
|
||||
*
|
||||
* XXX: Vnode locking here is hosed; lock should be held for calls to
|
||||
* VOP_GETATTR() and vn_rdwr().
|
||||
*/
|
||||
static char *
|
||||
linker_hints_lookup(const char *path, int pathlen,
|
||||
|
Loading…
Reference in New Issue
Block a user