d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

filedesc: microoptimize fget_unlocked by getting rid of fd < 0 branch

Browse Source 
Casting fd to an unsigned type simplifies fd range coparison to mere checking
if the result is bigger than the table.
This commit is contained in:
Mateusz Guzik 2015-03-24 00:10:11 +00:00
parent ca0f81984a
commit ea926658ff
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=280407
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/kern/kern_descrip.c
View File

@ -2342,7 +2342,7 @@ fget_unlocked(struct filedesc *fdp, int fd, cap_rights_t *needrightsp,
#endif
fdt = fdp->fd_files;
if (fd < 0 || fd >= fdt->fdt_nfiles)
if ((u_int)fd >= fdt->fdt_nfiles)
return (EBADF);
/*
* Fetch the descriptor locklessly. We avoid fdrop() races by