d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix a couple of things that weren't quite right for not using

Browse Source 
PN_RX_BUG_WAR - it was freeing memory that may not have been allocated,
and unconditionally bzero'ing the mbufs even if the workaround wasn't
enabled.
This commit is contained in:
Peter Wemm 1999-08-31 04:22:46 +00:00
parent ccb4d0c653
commit ead4c37a5d
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=50683
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/pci/if_pn.c
View File

@ -1295,7 +1295,8 @@ static int pn_detach(dev)
free(sc->pn_ldata_ptr, M_DEVBUF);
#ifdef PN_RX_BUG_WAR
free(sc->pn_rx_buf, M_DEVBUF);
if (sc->pn_rx_war)
free(sc->pn_rx_buf, M_DEVBUF);
#endif
ifmedia_removeall(&sc->ifmedia);
@ -1411,11 +1412,14 @@ static int pn_newbuf(sc, c, m)
*/
m_adj(m_new, sizeof(u_int64_t));
#ifdef PN_RX_BUG_WAR
/*
* Zero the buffer. This is part of the workaround for the
* promiscuous mode bug in the revision 33 PNIC chips.
*/
bzero((char *)mtod(m_new, char *), m_new->m_len);
if (sc->pn_rx_war)
bzero((char *)mtod(m_new, char *), m_new->m_len);
#endif
c->pn_mbuf = m_new;
c->pn_ptr->pn_data = vtophys(mtod(m_new, caddr_t));