d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Correct a performance bug in revision 1.462. The effect of the bug is to

Browse Source 
execute the outer loop in procedures such as pmap_protect() many more times
than necessary.

Reviewed by:	tegge
This commit is contained in:
Alan Cox 2005-08-19 07:25:40 +00:00
parent 8c9a194842
commit eb3d4a39fd
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=149272
1 changed files with 7 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
sys/amd64/amd64/pmap.c
View File

@ -1569,13 +1569,13 @@ pmap_remove(pmap_t pmap, vm_offset_t sva, vm_offset_t eva)
break;
pml4e = pmap_pml4e(pmap, sva);
if (pml4e == 0) {
if ((*pml4e & PG_V) == 0) {
va_next = (sva + NBPML4) & ~PML4MASK;
continue;
}
pdpe = pmap_pdpe(pmap, sva);
if (pdpe == 0) {
if ((*pdpe & PG_V) == 0) {
va_next = (sva + NBPDP) & ~PDPMASK;
continue;
}
@ -1586,8 +1586,6 @@ pmap_remove(pmap_t pmap, vm_offset_t sva, vm_offset_t eva)
va_next = (sva + NBPDR) & ~PDRMASK;
pde = pmap_pde(pmap, sva);
if (pde == 0)
continue;
ptpaddr = *pde;
/*
@ -1724,13 +1722,13 @@ pmap_protect(pmap_t pmap, vm_offset_t sva, vm_offset_t eva, vm_prot_t prot)
for (; sva < eva; sva = va_next) {
pml4e = pmap_pml4e(pmap, sva);
if (pml4e == 0) {
if ((*pml4e & PG_V) == 0) {
va_next = (sva + NBPML4) & ~PML4MASK;
continue;
}
pdpe = pmap_pdpe(pmap, sva);
if (pdpe == 0) {
if ((*pdpe & PG_V) == 0) {
va_next = (sva + NBPDP) & ~PDPMASK;
continue;
}
@ -1738,8 +1736,6 @@ pmap_protect(pmap_t pmap, vm_offset_t sva, vm_offset_t eva, vm_prot_t prot)
va_next = (sva + NBPDR) & ~PDRMASK;
pde = pmap_pde(pmap, sva);
if (pde == NULL)
continue;
ptpaddr = *pde;
/*
@ -2263,13 +2259,13 @@ pmap_copy(pmap_t dst_pmap, pmap_t src_pmap, vm_offset_t dst_addr, vm_size_t len,
break;
pml4e = pmap_pml4e(src_pmap, addr);
if (pml4e == 0) {
if ((*pml4e & PG_V) == 0) {
va_next = (addr + NBPML4) & ~PML4MASK;
continue;
}
pdpe = pmap_pdpe(src_pmap, addr);
if (pdpe == 0) {
if ((*pdpe & PG_V) == 0) {
va_next = (addr + NBPDP) & ~PDPMASK;
continue;
}
@ -2277,10 +2273,7 @@ pmap_copy(pmap_t dst_pmap, pmap_t src_pmap, vm_offset_t dst_addr, vm_size_t len,
va_next = (addr + NBPDR) & ~PDRMASK;
pde = pmap_pde(src_pmap, addr);
if (pde)
srcptepaddr = *pde;
else
continue;
srcptepaddr = *pde;
if (srcptepaddr == 0)
continue;