d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nvme: Eliminate redundant code

Browse Source 
get_admin_opcode_string and get_io_opcode_string are identical, but
start with different tables. Use a helper routine that takes an argument
to implement these instead. A future commit will refine this further.

Sponsored by:		Netflix
Reviewed by:		chuck, mav, jhb
Differential Revision:	https://reviews.freebsd.org/D41310
This commit is contained in:
Warner Losh 2023-08-07 16:35:15 -06:00
parent 7be0b06885
commit edd23e4dc0
1 changed files with 8 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
sys/dev/nvme/nvme_qpair.c
View File

@ -99,12 +99,8 @@ static struct nvme_opcode_string io_opcode[] = {
};
static const char *
get_admin_opcode_string(uint16_t opc)
get_opcode_string(struct nvme_opcode_string *entry, uint16_t opc)
{
struct nvme_opcode_string *entry;
entry = admin_opcode;
while (entry->opc != 0xFFFF) {
if (entry->opc == opc)
return (entry->str);
@ -113,19 +109,16 @@ get_admin_opcode_string(uint16_t opc)
return (entry->str);
}
static const char *
get_admin_opcode_string(uint16_t opc)
{
return (get_opcode_string(admin_opcode, opc));
}
static const char *
get_io_opcode_string(uint16_t opc)
{
struct nvme_opcode_string *entry;
entry = io_opcode;
while (entry->opc != 0xFFFF) {
if (entry->opc == opc)
return (entry->str);
entry++;
}
return (entry->str);
return (get_opcode_string(io_opcode, opc));
}
static void