d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ZTS: limit mmapwrite file size

Browse Source 
mmapwrite spawns several threads, all of which perform writes on a file
for the purpose of testing the behavior of mmap(2)-ed files.  One
thread performs an mmap and a write to the beginning of that region,
while the others perform regular writes after lseek(2)-ing the end of
the file.

Because these regular writes are set in a while (1) loop, they will
write an unbounded amount of data to disk.  The mmap_write_001_pos test
script SIGKILLs them after 30 seconds, but on fast testbeds, this may
be enough time to exhaust the available space in the filesystem,
leading to spurious test failures.

Instead, limit the total file size by checking that the lseek return
value is no greater than 250 * 1024*1024 bytes, which is less than the
default minimum vdev size defined in includes/default.cfg .

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Antonio Russo <aerusso@aerusso.net>
Closes #14277 
Closes #14345
This commit is contained in:
Antonio Russo 2023-01-05 13:50:30 -07:00 committed by GitHub
parent 8352e9dfae
commit ee6bf97c77
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/zfs-tests/cmd/mmapwrite.c
View File

@ -52,6 +52,7 @@
*/
#define NORMAL_WRITE_TH_NUM 2
#define MAX_WRITE_BYTES 262144000
static void *
normal_writer(void *filename)
@ -67,18 +68,21 @@ normal_writer(void *filename)
}
char buf = 'z';
while (1) {
off_t bytes_written = 0;
while (bytes_written < MAX_WRITE_BYTES) {
write_num = write(fd, &buf, 1);
if (write_num == 0) {
err(1, "write failed!");
break;
}
if (lseek(fd, page_size, SEEK_CUR) == -1) {
if ((bytes_written = lseek(fd, page_size, SEEK_CUR)) == -1) {
err(1, "lseek failed on %s: %s", file_path,
strerror(errno));
break;
}
}
return (NULL);
}
static void *