d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

top(1): issue warning on invalid delay

Browse Source 
When top -sH is run it continually updates. It should issue an warning
instead.

Reported by:	jmg
PR:		230803
This commit is contained in:
Eitan Adler 2018-08-22 09:49:38 +00:00
parent cd615bf560
commit eeb147d528
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=338187
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
usr.bin/top/top.c
View File

@ -21,6 +21,7 @@
#include <sys/signal.h>
#include <assert.h>
#include <err.h>
#include <errno.h>
#include <getopt.h>
#include <jail.h>
@ -253,6 +254,7 @@ main(int argc, char *argv[])
char *order_name = NULL;
int order_index = 0;
fd_set readfds;
char *nptr;
/* set the buffer for stdout */
#ifdef DEBUG
@ -386,7 +388,12 @@ main(int argc, char *argv[])
}
case 's':
delay = strtod(optarg, NULL);
delay = strtod(optarg, &nptr);
if (nptr == optarg) {
warnx("warning: invalid delay");
delay = 2;
warnings++;
}
if (delay < 0) {
fprintf(stderr,
"%s: warning: seconds delay should be positive -- using default\n",