d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Check for socket creation success before calling bind().

Browse Source 
Reported by:	Coverity
CID:		1194209
This commit is contained in:
Don Lewis 2016-05-12 05:43:54 +00:00
parent a09a9cbb40
commit eeb6394364
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=299516
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
sbin/ping/ping.c
View File

@ -285,6 +285,16 @@ main(int argc, char *const *argv)
err(EX_NOPERM, "setuid() failed");
uid = getuid();
if (ssend < 0) {
errno = ssend_errno;
err(EX_OSERR, "ssend socket");
}
if (srecv < 0) {
errno = srecv_errno;
err(EX_OSERR, "srecv socket");
}
alarmtimeout = df = preload = tos = 0;
outpack = outpackhdr + sizeof(struct ip);
@ -625,16 +635,6 @@ main(int argc, char *const *argv)
}
#endif
if (ssend < 0) {
errno = ssend_errno;
err(EX_OSERR, "ssend socket");
}
if (srecv < 0) {
errno = srecv_errno;
err(EX_OSERR, "srecv socket");
}
if (connect(ssend, (struct sockaddr *)&whereto, sizeof(whereto)) != 0)
err(1, "connect");