d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sctp: fix another locking bug in COOKIE handling

Browse Source 
Thanks to Tolya Korniltsev for reporting the issue for
the userland stack and testing the fix.

MFC after:	3 days
This commit is contained in:
Michael Tuexen 2021-05-12 23:02:31 +02:00
parent e06874f3f6
commit eec6aed5b8
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sys/netinet/sctp_input.c
View File

@ -1752,17 +1752,23 @@ sctp_process_cookie_existing(struct mbuf *m, int iphlen, int offset,
struct sctpasochead *head;
if (asoc->peer_supports_nat) {
struct sctp_tcb *local_stcb;
/*
* This is a gross gross hack. Just call the
* cookie_new code since we are allowing a duplicate
* association. I hope this works...
*/
return (sctp_process_cookie_new(m, iphlen, offset, src, dst,
local_stcb = sctp_process_cookie_new(m, iphlen, offset, src, dst,
sh, cookie, cookie_len,
inp, netp, init_src, notification,
auth_skipped, auth_offset, auth_len,
mflowtype, mflowid,
vrf_id, port));
vrf_id, port);
if (local_stcb == NULL) {
SCTP_TCB_UNLOCK(stcb);
}
return (local_stcb);
}
/*
* case A in Section 5.2.4 Table 2: XXMM (peer restarted)