d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

strfmon: Remove XXX marks

Browse Source 
phantom@'s HDD crashed with the final version of strfmon.c, as explained
in 9d430a5991.

Now there are tests in place that cover these code paths.

Reviewed by:	kib
PR:	267410
Github PR:	#620
MFC after:	1 week
This commit is contained in:
Jose Luis Duran 2022-10-28 06:20:33 -03:00 committed by Konstantin Belousov
parent 621bf91893
commit f0a15aafcb
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/libc/stdlib/strfmon.c
View File

@ -324,7 +324,7 @@ vstrfmon_l(char * __restrict s, size_t maxsize, locale_t loc,
if (cs_precedes == 1) {
if (sign_posn == 1 || sign_posn == 3) {
PRINTS(signstr);
if (sep_by_space == 2) /* XXX: ? */
if (sep_by_space == 2)
PRINT(' ');
}
@ -363,7 +363,7 @@ vstrfmon_l(char * __restrict s, size_t maxsize, locale_t loc,
|| sign_posn == 2
|| sign_posn == 4)))
PRINT(space_char);
PRINTS(currency_symbol); /* XXX: len */
PRINTS(currency_symbol);
if (sign_posn == 4) {
if (sep_by_space == 2)
PRINT(' ');
@ -597,7 +597,7 @@ __format_grouped_double(double value, int *flags,
}
if ((*flags & NEED_GROUPING) &&
thousands_sep_size > 0 && /* XXX: need investigation */
thousands_sep_size > 0 &&
*grouping != CHAR_MAX &&
*grouping > 0) {
while (avalue_size > (int)*grouping) {