d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

xdma(4): Fix invalid pointer use (breaks arm.SOCFPGA build)

Browse Source 
In xdma_handle_mem_node(), vmem_size_t and vmem_addr_t pointers were passed to
an FDT API that emits u_long values to the output parameter pointer.  This
broke on systems with both xdma and 32-bit vmem size/addr types (SOCFPGA).

Reported by:	tinderbox
Sponsored by:	Dell EMC Isilon
This commit is contained in:
Conrad Meyer 2019-05-16 17:34:36 +00:00
parent 2471860668
commit f4ab98c597
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=347828
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sys/dev/xdma/xdma.c
View File

@ -312,8 +312,7 @@ xdma_handle_mem_node(vmem_t *vmem, phandle_t memory)
pcell_t *regp;
int addr_cells, size_cells;
int i, reg_len, ret, tuple_size, tuples;
vmem_addr_t mem_start;
vmem_size_t mem_size;
u_long mem_start, mem_size;
if ((ret = fdt_addrsize_cells(OF_parent(memory), &addr_cells,
&size_cells)) != 0)