crunchide: report explicit error for combined string table

Some tools produce objects with a combined strtab and shstrtab.
These objects are not supported by crunchide since it rewrites the
symtab and strtab to "hide" symbols. This invalidates section header
offsets into a combined strtab/shstrtab.

In the future we could support these objects (by ensuring that we retain
unmodified section name strings in the output .strtab, and then rewriting
each section header's sh_name).

MFC after:	1 week
Sponsored by:	The FreeBSD Foundation
This commit is contained in:
Ed Maste 2016-11-17 18:12:17 +00:00
parent 6e18247a3d
commit f513dfd44b
Notes: svn2git 2020-12-20 02:59:44 +00:00
svn path=/head/; revision=308772

View File

@ -279,6 +279,10 @@ ELFNAMEEND(hide)(int fd, const char *fn)
weird = 1;
weirdreason = "section header string table does not exist";
}
if (strtabshdr == shstrtabshdr) {
weird = 1;
weirdreason = "combined strtab and shstrtab not supported";
}
if (weirdreason == NULL)
weirdreason = "unsupported";
if (weird) {