d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Swap destination and source arguments of two bcopy() calls.

Browse Source 
Before committing the initial tcp_hostcache I changed them from memcpy()
to conform with FreeBSD style without realizing the difference in argument
definition.

This fixes hostcache operation for IPv6 (in general and explicitly IPv6
path mtu discovery) and T/TCP (RFC1644).

Submitted by:	Taku YAMAMOTO <taku@cent.saitama-u.ac.jp>
Approved by:	re (rwatson)
This commit is contained in:
Andre Oppermann 2003-12-02 21:25:12 +00:00
parent 504fbf4e1e
commit f5bd8e9aff
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=123113
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/netinet/tcp_hostcache.c
View File

@ -377,7 +377,7 @@ tcp_hc_insert(struct in_conninfo *inc)
*/
bzero(hc_entry, sizeof(*hc_entry));
if (inc->inc_isipv6)
bcopy(&hc_entry->ip6, &inc->inc6_faddr, sizeof(hc_entry->ip6));
bcopy(&inc->inc6_faddr, &hc_entry->ip6, sizeof(hc_entry->ip6));
else
hc_entry->ip4 = inc->inc_faddr;
hc_entry->rmx_head = hc_head;
@ -474,7 +474,7 @@ tcp_hc_gettao(struct in_conninfo *inc, struct rmxp_tao *tao)
hc_entry->rmx_hits++;
hc_entry->rmx_expire = tcp_hostcache.expire; /* start over again */
bcopy(tao, &hc_entry->rmx_tao, sizeof(*tao));
bcopy(&hc_entry->rmx_tao, tao, sizeof(*tao));
THC_UNLOCK(&hc_entry->rmx_head->hch_mtx);
}