d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vfs: plug spurious error checks in namei

Browse Source 
error is guaranteed 0 at that point
This commit is contained in:
Mateusz Guzik 2022-09-13 23:18:30 +00:00
parent 3078531de1
commit f7dc4a71da
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
sys/kern/vfs_lookup.c
View File

@ -689,16 +689,15 @@ namei(struct nameidata *ndp)
*/
if ((cnp->cn_flags & ISSYMLINK) == 0) {
SDT_PROBE4(vfs, namei, lookup, return, error,
(error == 0 ? ndp->ni_vp : NULL), false, ndp);
ndp->ni_vp, false, ndp);
if ((cnp->cn_flags & (SAVENAME | SAVESTART)) == 0) {
namei_cleanup_cnp(cnp);
} else
cnp->cn_flags |= HASBUF;
nameicap_cleanup(ndp);
pwd_drop(pwd);
if (error == 0)
NDVALIDATE(ndp);
return (error);
NDVALIDATE(ndp);
return (0);
}
error = namei_follow_link(ndp);
if (error != 0)