d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

msdosfs: Drop an unneeded brelse in bread error condition

Browse Source 
After r294954, it is an invariant that bread returns non-NULL bp if and only
if the routine succeeded.  On error, it handles any buffer cleanup
internally.  So the brelse(NULL) here was just redundant.

No functional change.

Discussed with:	kib (extracted from a larger differential)
This commit is contained in:
Conrad Meyer 2019-09-05 21:30:52 +00:00
parent ed4e4cff0e
commit f80cbeb292
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=351898
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/fs/msdosfs/msdosfs_fat.c
View File

@ -1145,10 +1145,8 @@ markvoldirty(struct msdosfsmount *pmp, int dirty)
byteoffset = FATOFS(pmp, 1);
fatblock(pmp, byteoffset, &bn, &bsize, &bo);
error = bread(pmp->pm_devvp, bn, bsize, NOCRED, &bp);
if (error) {
brelse(bp);
if (error)
return (error);
}
/*
* Get the current value of the FAT entry and set/clear the relevant