From f8b45306c6c74938e248f9fbfc55499d2126a82f Mon Sep 17 00:00:00 2001 From: Gleb Smirnoff Date: Fri, 13 Sep 2019 22:36:04 +0000 Subject: [PATCH] Drivers may pass runt packets to filter. This is okay. Reviewed by: gallatin --- sys/netpfil/ipfw/ip_fw2.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sys/netpfil/ipfw/ip_fw2.c b/sys/netpfil/ipfw/ip_fw2.c index 6dfe58911955..f55329f54ce4 100644 --- a/sys/netpfil/ipfw/ip_fw2.c +++ b/sys/netpfil/ipfw/ip_fw2.c @@ -1448,7 +1448,10 @@ ipfw_chk(struct ip_fw_args *args) do { \ int x = (_len) + T + EHLEN; \ if (mem) { \ - MPASS(pktlen >= x); \ + if (__predict_false(pktlen < x)) { \ + unlock; \ + goto pullup_failed; \ + } \ p = (char *)args->mem + (_len) + EHLEN; \ } else { \ if (__predict_false((m)->m_len < x)) { \