From f988d55683172b390caaa14174ce8d080bb70f26 Mon Sep 17 00:00:00 2001 From: Alexander Motin Date: Wed, 22 Mar 2017 13:53:21 +0000 Subject: [PATCH] Fix printing bits above first eight. Reported by: Coverity CID: 1372596 MFC after: 1 week --- sbin/camcontrol/camcontrol.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sbin/camcontrol/camcontrol.c b/sbin/camcontrol/camcontrol.c index d9a9064a1bca..10f2778a9323 100644 --- a/sbin/camcontrol/camcontrol.c +++ b/sbin/camcontrol/camcontrol.c @@ -5321,7 +5321,7 @@ static void cpi_print(struct ccb_pathinq *cpi) { char adapter_str[1024]; - int i; + uint64_t i; snprintf(adapter_str, sizeof(adapter_str), "%s%d:", cpi->dev_name, cpi->unit_number); @@ -5329,7 +5329,7 @@ cpi_print(struct ccb_pathinq *cpi) fprintf(stdout, "%s SIM/HBA version: %d\n", adapter_str, cpi->version_num); - for (i = 1; i < 0xff; i = i << 1) { + for (i = 1; i < UINT8_MAX; i = i << 1) { const char *str; if ((i & cpi->hba_inquiry) == 0) @@ -5369,7 +5369,7 @@ cpi_print(struct ccb_pathinq *cpi) fprintf(stdout, "%s\n", str); } - for (i = 1; i < 0xff; i = i << 1) { + for (i = 1; i < UINT32_MAX; i = i << 1) { const char *str; if ((i & cpi->hba_misc) == 0) @@ -5416,7 +5416,7 @@ cpi_print(struct ccb_pathinq *cpi) fprintf(stdout, "%s\n", str); } - for (i = 1; i < 0xff; i = i << 1) { + for (i = 1; i < UINT16_MAX; i = i << 1) { const char *str; if ((i & cpi->target_sprt) == 0)