d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

netlink: reduce default log levels

Browse Source 
Reduce the default log level for netlink to LOG_INFO. This removes a
number of messages such as

> [nl_iface] dump_sa: unsupported family: 0, skipping
or
> [nl_iface] get_operstate_ether: error calling SIOCGIFMEDIA on vlan0: 22

that are useful for debugging, but not for most users.

Reviewed by:	melifaro
Sponsored by:	Rubicon Communications, LLC ("Netgate")
Differential Revision:	https://reviews.freebsd.org/D40062
This commit is contained in:
Kristof Provost 2023-05-11 15:08:42 +02:00
parent dd4f32ae62
commit fa554de774
14 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/compat/linux/linux_netlink.c
View File

@ -57,7 +57,7 @@ __FBSDID("$FreeBSD$");
#define DEBUG_MOD_NAME nl_linux #define DEBUG_MOD_NAME nl_linux
#define DEBUG_MAX_LEVEL LOG_DEBUG3 #define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h> #include <netlink/netlink_debug.h>
_DECLARE_DEBUG(LOG_DEBUG); _DECLARE_DEBUG(LOG_INFO);
static bool static bool
valid_rta_size(const struct rtattr *rta, int sz) valid_rta_size(const struct rtattr *rta, int sz)

2
sys/netlink/netlink_domain.c
View File

@ -56,7 +56,7 @@
#define DEBUG_MOD_NAME nl_domain #define DEBUG_MOD_NAME nl_domain
#define DEBUG_MAX_LEVEL LOG_DEBUG3 #define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h> #include <netlink/netlink_debug.h>
_DECLARE_DEBUG(LOG_DEBUG); _DECLARE_DEBUG(LOG_INFO);
_Static_assert((NLP_MAX_GROUPS % 64) == 0, _Static_assert((NLP_MAX_GROUPS % 64) == 0,
"NLP_MAX_GROUPS has to be multiple of 64"); "NLP_MAX_GROUPS has to be multiple of 64");

2
sys/netlink/netlink_generic.c
View File

@ -49,7 +49,7 @@ __FBSDID("$FreeBSD$");
#define DEBUG_MOD_NAME nl_generic #define DEBUG_MOD_NAME nl_generic
#define DEBUG_MAX_LEVEL LOG_DEBUG3 #define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h> #include <netlink/netlink_debug.h>
_DECLARE_DEBUG(LOG_DEBUG); _DECLARE_DEBUG(LOG_INFO);
static int dump_family(struct nlmsghdr *hdr, struct genlmsghdr *ghdr, static int dump_family(struct nlmsghdr *hdr, struct genlmsghdr *ghdr,
const struct genl_family *gf, struct nl_writer *nw); const struct genl_family *gf, struct nl_writer *nw);

2
sys/netlink/netlink_generic_kpi.c
View File

@ -45,7 +45,7 @@ __FBSDID("$FreeBSD$");
#define DEBUG_MOD_NAME nl_generic_kpi #define DEBUG_MOD_NAME nl_generic_kpi
#define DEBUG_MAX_LEVEL LOG_DEBUG3 #define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h> #include <netlink/netlink_debug.h>
_DECLARE_DEBUG(LOG_DEBUG3); _DECLARE_DEBUG(LOG_INFO);
/* /*

2
sys/netlink/netlink_io.c
View File

@ -48,7 +48,7 @@ __FBSDID("$FreeBSD$");
#define DEBUG_MOD_NAME nl_io #define DEBUG_MOD_NAME nl_io
#define DEBUG_MAX_LEVEL LOG_DEBUG3 #define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h> #include <netlink/netlink_debug.h>
_DECLARE_DEBUG(LOG_DEBUG); _DECLARE_DEBUG(LOG_INFO);
/* /*
* The logic below provide a p2p interface for receiving and * The logic below provide a p2p interface for receiving and

2
sys/netlink/netlink_message_parser.c
View File

@ -50,7 +50,7 @@ __FBSDID("$FreeBSD$");
#define DEBUG_MOD_NAME nl_parser #define DEBUG_MOD_NAME nl_parser
#define DEBUG_MAX_LEVEL LOG_DEBUG3 #define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h> #include <netlink/netlink_debug.h>
_DECLARE_DEBUG(LOG_DEBUG); _DECLARE_DEBUG(LOG_INFO);
bool bool
nlmsg_report_err_msg(struct nl_pstate *npt, const char *fmt, ...) nlmsg_report_err_msg(struct nl_pstate *npt, const char *fmt, ...)

2
sys/netlink/netlink_message_writer.c
View File

@ -47,7 +47,7 @@ __FBSDID("$FreeBSD$");
#define DEBUG_MOD_NAME nl_writer #define DEBUG_MOD_NAME nl_writer
#define DEBUG_MAX_LEVEL LOG_DEBUG3 #define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h> #include <netlink/netlink_debug.h>
_DECLARE_DEBUG(LOG_DEBUG); _DECLARE_DEBUG(LOG_INFO);
/* /*
* The goal of this file is to provide convenient message writing KPI on top of * The goal of this file is to provide convenient message writing KPI on top of

2
sys/netlink/netlink_module.c
View File

@ -52,7 +52,7 @@ FEATURE(netlink, "Netlink support");
#define DEBUG_MOD_NAME nl_mod #define DEBUG_MOD_NAME nl_mod
#define DEBUG_MAX_LEVEL LOG_DEBUG3 #define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h> #include <netlink/netlink_debug.h>
_DECLARE_DEBUG(LOG_DEBUG); _DECLARE_DEBUG(LOG_INFO);
#define NL_MAX_HANDLERS 20 #define NL_MAX_HANDLERS 20

2
sys/netlink/netlink_route.c
View File

@ -44,7 +44,7 @@ __FBSDID("$FreeBSD$");
#define DEBUG_MOD_NAME nl_route_core #define DEBUG_MOD_NAME nl_route_core
#define DEBUG_MAX_LEVEL LOG_DEBUG3 #define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h> #include <netlink/netlink_debug.h>
_DECLARE_DEBUG(LOG_DEBUG); _DECLARE_DEBUG(LOG_INFO);
#define HANDLER_MAX_NUM (NL_RTM_MAX + 10) #define HANDLER_MAX_NUM (NL_RTM_MAX + 10)
static const struct rtnl_cmd_handler *rtnl_handler[HANDLER_MAX_NUM] = {}; static const struct rtnl_cmd_handler *rtnl_handler[HANDLER_MAX_NUM] = {};

2
sys/netlink/route/iface.c
View File

@ -59,7 +59,7 @@ __FBSDID("$FreeBSD$");
#define DEBUG_MOD_NAME nl_iface #define DEBUG_MOD_NAME nl_iface
#define DEBUG_MAX_LEVEL LOG_DEBUG3 #define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h> #include <netlink/netlink_debug.h>
_DECLARE_DEBUG(LOG_DEBUG); _DECLARE_DEBUG(LOG_INFO);
struct netlink_walkargs { struct netlink_walkargs {
struct nl_writer *nw; struct nl_writer *nw;

2
sys/netlink/route/iface_drivers.c
View File

@ -57,7 +57,7 @@ __FBSDID("$FreeBSD$");
#define DEBUG_MOD_NAME nl_iface_drivers #define DEBUG_MOD_NAME nl_iface_drivers
#define DEBUG_MAX_LEVEL LOG_DEBUG3 #define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h> #include <netlink/netlink_debug.h>
_DECLARE_DEBUG(LOG_DEBUG); _DECLARE_DEBUG(LOG_INFO);
/* /*
* Generic modification interface handler. * Generic modification interface handler.

2
sys/netlink/route/neigh.c
View File

@ -52,7 +52,7 @@ __FBSDID("$FreeBSD$");
#define DEBUG_MOD_NAME nl_neigh #define DEBUG_MOD_NAME nl_neigh
#define DEBUG_MAX_LEVEL LOG_DEBUG3 #define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h> #include <netlink/netlink_debug.h>
_DECLARE_DEBUG(LOG_DEBUG); _DECLARE_DEBUG(LOG_INFO);
static int lle_families[] = { AF_INET, AF_INET6 }; static int lle_families[] = { AF_INET, AF_INET6 };

2
sys/netlink/route/nexthop.c
View File

@ -56,7 +56,7 @@ __FBSDID("$FreeBSD$");
#define DEBUG_MOD_NAME nl_nhop #define DEBUG_MOD_NAME nl_nhop
#define DEBUG_MAX_LEVEL LOG_DEBUG3 #define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h> #include <netlink/netlink_debug.h>
_DECLARE_DEBUG(LOG_DEBUG); _DECLARE_DEBUG(LOG_INFO);
/* /*
* This file contains the logic to maintain kernel nexthops and * This file contains the logic to maintain kernel nexthops and

2
sys/netlink/route/rt.c
View File

@ -52,7 +52,7 @@ __FBSDID("$FreeBSD$");
#define DEBUG_MOD_NAME nl_route #define DEBUG_MOD_NAME nl_route
#define DEBUG_MAX_LEVEL LOG_DEBUG3 #define DEBUG_MAX_LEVEL LOG_DEBUG3
#include <netlink/netlink_debug.h> #include <netlink/netlink_debug.h>
_DECLARE_DEBUG(LOG_DEBUG); _DECLARE_DEBUG(LOG_INFO);
static unsigned char static unsigned char
get_rtm_type(const struct nhop_object *nh) get_rtm_type(const struct nhop_object *nh)