d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

loader: make sure we use snprintf() in commands.c

Browse Source 
Safeguard against memory corruptions.
This commit is contained in:
Toomas Soome 2018-04-16 08:15:50 +00:00
parent 88876b6500
commit faa5306390
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=332557
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
stand/common/commands.c
View File

@ -236,7 +236,7 @@ command_commandlist(int argc, char *argv[])
if (res)
break;
if (((*cmdp)->c_name != NULL) && ((*cmdp)->c_desc != NULL)) {
sprintf(name, " %-15s ", (*cmdp)->c_name);
snprintf(name, sizeof(name), " %-15s ", (*cmdp)->c_name);
pager_output(name);
pager_output((*cmdp)->c_desc);
res = pager_output("\n");
@ -435,12 +435,12 @@ command_more(int argc, char *argv[])
res=0;
pager_open();
for (i = 1; (i < argc) && (res == 0); i++) {
sprintf(line, "*** FILE %s BEGIN ***\n", argv[i]);
snprintf(line, sizeof(line), "*** FILE %s BEGIN ***\n", argv[i]);
if (pager_output(line))
break;
res = page_file(argv[i]);
if (!res) {
sprintf(line, "*** FILE %s END ***\n", argv[i]);
snprintf(line, sizeof(line), "*** FILE %s END ***\n", argv[i]);
res = pager_output(line);
}
}
@ -501,7 +501,7 @@ command_lsdev(int argc, char *argv[])
if (devsw[i]->dv_print(verbose))
break;
} else {
sprintf(line, "%s: (unknown)\n", devsw[i]->dv_name);
snprintf(line, sizeof(line), "%s: (unknown)\n", devsw[i]->dv_name);
if (pager_output(line))
break;
}