d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix clang 15 warning in cxgbe

Browse Source 
Clang 15 warns:

    sys/dev/cxgbe/cudbg/cudbg_lib.c:2949:6: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
            int i = 0;
                ^

Apparently 'i' was meant as the current retry counter, but '1' was used
in the while loop comparison instead, making the loop potentially
infinite, if 'busy' never gets reset.

MFC after:	3 days
Reviewed by:	np
Differential Revision: https://reviews.freebsd.org/D35834
This commit is contained in:
Dimitry Andric 2022-07-16 21:19:51 +02:00
parent 752b6daecc
commit fb0493d559
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/dev/cxgbe/cudbg/cudbg_lib.c
View File

@ -2950,7 +2950,7 @@ static int check_busy_bit(struct adapter *padap)
int retry = 10;
int status = 0;
while (busy & (1 < retry)) {
while (busy && i < retry) {
val = t4_read_reg(padap, A_CIM_HOST_ACC_CTRL);
busy = (0 != (val & CUDBG_CIM_BUSY_BIT));
i++;