d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

If VOP_ADVLOCK() call or earlier checks failed don't check for a race with

Browse Source 
close, because even if we had a race there is nothing to unlock.

Discussed with:	kib
MFC after:	1 month
This commit is contained in:
Pawel Jakub Dawidek 2012-06-17 16:32:32 +00:00
parent 5e33d57ff1
commit fd6049b186
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=237198
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sys/kern/kern_descrip.c
View File

@ -668,6 +668,10 @@ kern_fcntl(struct thread *td, int fd, int cmd, intptr_t arg)
}
VFS_UNLOCK_GIANT(vfslocked);
vfslocked = 0;
if (error != 0) {
fdrop(fp, td);
break;
}
/* Check for race with close */
FILEDESC_SLOCK(fdp);
if (fget_locked(fdp, fd) != fp) {