From fdb727f4f29312ca5d80583d2f05e144da6ef40c Mon Sep 17 00:00:00 2001 From: Conrad Meyer Date: Mon, 13 Mar 2017 18:05:31 +0000 Subject: [PATCH] alias_proxy.c: Fix accidental error quashing This was introduced on accident in r165243, when return sites were unified to add a lock around LibAliasProxyRule(). PR: 217749 Submitted by: Svyatoslav Sponsored by: Viva64 (PVS-Studio) --- sys/netinet/libalias/alias_proxy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/netinet/libalias/alias_proxy.c b/sys/netinet/libalias/alias_proxy.c index 132e56295fce..d7af37759928 100644 --- a/sys/netinet/libalias/alias_proxy.c +++ b/sys/netinet/libalias/alias_proxy.c @@ -720,7 +720,8 @@ LibAliasProxyRule(struct libalias *la, const char *cmd) err = RuleNumberDelete(la, rule_to_delete); if (err) ret = -1; - ret = 0; + else + ret = 0; goto getout; }