Edward Tomasz Napierala
0686a20b8a
Don't blindly assume the target agreed to transition to Full Feature Phase;
...
if we got a Login Response PDU without the "T" bit set, try again with
an empty request. This fixes interoperability with COMSTAR.
Reviewed by: mav@
Tested by: mav@
MFC after: 1 week
2014-09-11 20:01:57 +00:00
Alexander Motin
eb4e5b0ad5
Fix memory leak, reported by Coverity.
...
CID: 1229996
2014-09-10 08:06:31 +00:00
Edward Tomasz Napierala
b7a65e3936
Make the iSCSI stack use __FBSDID() properly.
...
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation
2014-08-21 15:32:38 +00:00
Enji Cooper
a725bfc49c
Add LIBCRYPTO and LIBSSL to DPADD
...
This fixes "make checkdpadd"
Phabric: D621
PR: 192761
Approved by: rpaulo (mentor)
MFC after: 2 weeks
2014-08-18 18:01:18 +00:00
Alexander Motin
ffe82e05b3
Make iSCSI initiator keep Initiator Session ID (ISID) across reconnects.
...
Previously ISID was changed every time, that made impossible correct
persistent reservation, because reconnected session was identified as
completely new one.
Reviewed by: trasz
MFC after: 1 week
2014-07-06 17:37:49 +00:00
Baptiste Daroussin
01c2b8ac0d
use .Mt to mark up email addresses consistently (part2)
...
PR: 191174
Submitted by: Franco Fichtner <franco@lastsummer.de>
2014-06-20 09:57:27 +00:00
Edward Tomasz Napierala
51be90b522
Implement redirection handling in initiator.
...
Sponsored by: The FreeBSD Foundation
2014-06-18 17:35:40 +00:00
Edward Tomasz Napierala
09bf9ac9f2
Get rid of unneccessary argument.
...
Sponsored by: The FreeBSD Foundation
2014-06-18 17:21:38 +00:00
Edward Tomasz Napierala
f704805957
Improve code a little; no functional changes.
...
Sponsored by: The FreeBSD Foundation
2014-06-18 17:04:25 +00:00
Edward Tomasz Napierala
bbd91c8883
Use proper term in debug messages.
...
MFC after: 1 month
Sponsored by: FreeBSD Foundation
2014-06-18 17:00:41 +00:00
Edward Tomasz Napierala
f851961034
Remove unused variable.
2014-05-15 18:34:31 +00:00
Edward Tomasz Napierala
280c1e94b4
Remove redundant code.
...
Sponsored by: The FreeBSD Foundation
2014-04-17 12:53:56 +00:00
Edward Tomasz Napierala
57a4f20b8d
Make it possible for the initiator side to operate in both proxy
...
and normal mode; this makes it possible to compile with the former
by default, but use it only when neccessary. That's especially
important for the userland part.
Sponsored by: The FreeBSD Foundation
2014-04-16 18:23:36 +00:00
Robert Watson
b881b8be1d
Update most userspace consumers of capability.h to use capsicum.h instead.
...
auditdistd is not updated as I will make the change upstream and then do a
vendor import sometime in the next week or two.
MFC after: 3 weeks
2014-03-16 11:04:44 +00:00
Edward Tomasz Napierala
1ecb3c5857
So, it turns out SIGCHLD is discarded by default, so we have to set up
...
a dummy handler to make it interrupt an ioctl(2) or select(2).
This makes those short-lived iscsid(8) zombies disappear.
Sponsored by: The FreeBSD Foundation
2014-02-11 10:47:28 +00:00
Edward Tomasz Napierala
022b237d47
Empty data segment during Login Phase is rather unlikely, but it's not
...
a protocol error.
Sponsored by: The FreeBSD Foundation
2014-02-11 10:45:20 +00:00
Edward Tomasz Napierala
3fa953a071
The log_whatever() routines don't accept NULL for format strings,
...
so mark them as __printflike instead of __printf0like.
Sponsored by: The FreeBSD Foundation
2014-02-10 15:12:59 +00:00
Edward Tomasz Napierala
0b50e35921
Plug memory leak.
...
Coverity CID: 1087991
Approved by: re (gjb)
Sponsored by: FreeBSD Foundation
2013-10-09 13:48:08 +00:00
Edward Tomasz Napierala
9e55679baf
Fix memory overrun.
...
Coverity CID: 1092478
Approved by: re (gjb)
Sponsored by: FreeBSD Foundation
2013-10-09 13:45:07 +00:00
Edward Tomasz Napierala
7843bd031a
Fix several problems in the new iSCSI stack; this includes interoperability
...
fix for LIO (Linux target), removing possibility for the target to avoid mutual
CHAP by choosing to skip authentication altogether, and fixing truncated error
messages in iscsictl(8) output. This also fixes several of the problems found
with Coverity.
Note that this change requires world rebuild.
Coverity CID: 1088038, 1087998, 1087990, 1088004, 1088044, 1088041, 1088040
Approved by: re (blanket)
Sponsored by: FreeBSD Foundation
2013-09-18 21:15:21 +00:00
Edward Tomasz Napierala
c76e8a9aa0
Make iscsictl(8) automatically try to load the iscsi module. While here,
...
improve module loading in iscsid(8) and ctld(8).
Approved by: re (delphij)
2013-09-18 08:37:14 +00:00
Edward Tomasz Napierala
1f90f28221
Improve iSCSI address resolution, fixing "InitiatorAddress" handling,
...
and error reporting.
Approved by: re (kib)
2013-09-17 14:23:15 +00:00
Joel Dahl
33e1779ab8
Minor mdoc fixes.
...
Approved by: re (blanket)
2013-09-14 21:43:18 +00:00
Edward Tomasz Napierala
009ea47eb2
Bring in the new iSCSI target and initiator.
...
Reviewed by: ken (parts)
Approved by: re (delphij)
Sponsored by: FreeBSD Foundation
2013-09-14 15:29:06 +00:00