Commit Graph

43 Commits

Author SHA1 Message Date
David Greenman
1e8ee278b6 From Johannes Stille:
When we get an EN8 response while we're already sending the file using
the i protocol, this can happen:

In send.c, flocal_send_await_reply() is called. This function calls
flocal_send_fail() to process the aborted transfer. After this, we run
into the branch that calls ffileseekend() to force the end of the
actual transfer.

Now flocal_send_fail() frees qtrans, but qtrans is still used later!

I propose to fix this by moving the usfree_send(qtrans) out of
flocal_send_fail(), as in the patch I append to this mail.

...

I have found a race condition in the uucp 1.05 code. The typical result
is that the connections mysteriously fails with "conversation failed",
even while all files were transmitted. This is the problem:

At least for the i protocol, the code to send a packet can receive and
process packets after sending.
In several places in the code, we send a command and then prepare to
receive an answer.
Now the answer might already arrive during the call that sends the
command while we aren't ready to process it.

The general solution is IMHO first to do all preparations and only as a
last step to send out the command.

Reviewed by:	John Dyson
Submitted by:	Johannes Stille
1994-11-06 10:17:13 +00:00
Andrey A. Chernov
8961fb9fd4 Allow '#' in address in rmail arguments
Obtained from: taylor-uucp list
1994-10-22 03:51:36 +00:00
Andrey A. Chernov
1546c307a6 Make ~%take work: ignore \r
Obtained from: taylor-list
1994-10-02 23:10:39 +00:00
Andrey A. Chernov
09b7b3dcca Make -a option optional, uux fails in other case with new sendmail-style
<> address in return-receipts
Obtained from: taylor-list
1994-10-02 23:09:41 +00:00
Bruce Evans
05e598dc37 We do have <dirent.h>, and it was harmful to pretend that we don't.
Several files in uucp/libunix included <sys/dir.h> and defined dirent
as direct, but <sys/dir.h> defines direct as dirent.  This macro
recursion is not allowed by cpp in traditional mode.  The 2.0 mkdep
uses cpp in traditional mode (another bug) so cpp prints a error
message and exits with a nonzero status.  The error status leaks out
of the pipe (another bug) so mkdep "succeeds".  It may even succeed.
1994-08-28 16:04:56 +00:00
Jordan K. Hubbard
7129790a6c New 2.0 specific changes.
Reviewed by:
Submitted by:
1994-08-08 20:24:29 +00:00
Jordan K. Hubbard
aeddb76205 Make uucp compile again in 2.0. A little perturbed about the comment
saying that 4.4 uses f_size in statfs, yet we're using b_size.  Anyway,
I've configured things to match our current environment.
Reviewed by:
Submitted by:
1994-08-08 20:24:12 +00:00
Andrey A. Chernov
4a62bda2ae Back out previous change and allow uucico to run by others,
this required by several programs
1994-05-31 15:55:43 +00:00
Andrey A. Chernov
9c07bcf01d Don't need to restrict cu, it can be able to check permissions by itself 1994-05-31 07:47:39 +00:00
Andrey A. Chernov
70db166b79 Allow uux and uucp to run by others,
we can got problems with various mailers in other case
1994-05-31 07:37:25 +00:00
Andrey A. Chernov
33dddc66c6 I forget to add BINGRP=$(group) 1994-05-31 05:46:42 +00:00
Andrey A. Chernov
336116b49a Disallow uucp execution to others.
It maybe not so nice, but if any user can easily shut up your
mail feed with big file isn't nice too.
1994-05-31 05:37:12 +00:00
Andrey A. Chernov
5974426b37 Allow group "dialer" to run cu
Disallow others to run cu
1994-05-31 05:23:39 +00:00
Andrey A. Chernov
241ca242fb Don't allow others to run uuconv 1994-05-31 05:13:08 +00:00
Andrey A. Chernov
a537d2cfa6 Don't allow others run uuchk 1994-05-31 05:11:12 +00:00
Andrey A. Chernov
ac0c045974 Don't allow others run uuxqt 1994-05-31 05:09:03 +00:00
Andrey A. Chernov
5789078704 Don't allow others run uucico 1994-05-31 05:08:11 +00:00
Andrey A. Chernov
3af2612b6a Change group to uucp group 1994-05-31 04:41:32 +00:00
Andrey A. Chernov
40a845cd5b Fix -z key, patch from Taylor 1994-05-25 20:14:52 +00:00
Andrey A. Chernov
120a306987 Documentation added 1994-05-25 19:04:00 +00:00
Andrey A. Chernov
8ada725ee1 Fix multiply slash problem 1994-05-20 00:34:30 +00:00
Andrey A. Chernov
442f2b9758 We have BROKEN_SETREUID by Taylor point of view 1994-05-17 23:15:30 +00:00
Andrey A. Chernov
8d29233fea Upgrade to version 1.05 1994-05-07 18:14:43 +00:00
Andrey A. Chernov
a36226d6ef 1) Add \p\c after CONNECT for modems which give CONNECT before
carrier up
2) Add more chat-fail codes
3) Add comment about complete/abort scripts, when modem handle
   DTR drop properly
1994-05-03 18:46:44 +00:00
Jordan K. Hubbard
54678dc993 Back my earlier BSD_TTY change out of -current. 1994-04-26 21:30:33 +00:00
Jordan K. Hubbard
1162c4cea3 From: stark!gene@newsserv.cs.sunysb.edu (Gene Stark)
Message-Id: <199404171501.LAA01245@stark.UUCP>
To: freebsd-hackers@freefall.cdrom.com
Subject: Make world and UUCP
Sender: freebsd-hackers-owner@freefall.cdrom.com
Precedence: bulk

It would be much more convenient if "make world" didn't clobber my
UUCP configuration files in /etc/uucp.  Perhaps the easiest fix would
be to change the names of the sample configuration files:

	config -> config.sample
	ports -> ports.sample
	...
1994-04-25 16:18:07 +00:00
Jordan K. Hubbard
0375e3e434 From: Marko Teiste <mte@tigger.cirion.fi>
Message-Id: <199404241154.OAA00260@tigger.cirion.fi>
Subject: uucp error
Index: gun/libexec/uucp FreeBSD-1.1-GAMMA
Apparently-To: FreeBSD-bugfiler@freefall.cdrom.com
Sender: freebsd-bugs-owner@freefall.cdrom.com
Precedence: bulk

Description:
	When calling remote uucp site dialing succeeds, but standard
	login chat fails. Debug file shows that uucico does not see
	any characters send from remote.

Repeat-By:
	use sio drivers, 16450 base serial and standard taylor configuration
	provided with the GAMMA release. Run uucico and observer.

Fix:
	define HAVE_BSD_TTY instead of HAVE_POSIX_TTY in common_source/policy.h
	and recompile.
1994-04-25 16:16:59 +00:00
Jordan K. Hubbard
2caac73e76 Fix gross spelling and typographical errors pointed out by Keith Bostic. 1994-04-24 01:22:07 +00:00
Jordan K. Hubbard
83c4d4f67a Back out previous change. 1994-04-02 17:10:19 +00:00
Jordan K. Hubbard
f382b1e919 Fix from Gene for bogus destinations. 1994-04-01 13:11:01 +00:00
Andrey A. Chernov
00cf4634ce Partially undo prevoius fix from Ian Taylor, VTIME must be 0 here 1994-02-07 23:47:51 +00:00
Jordan K. Hubbard
1f17318c25 Patches from Gunter Jung to make xchat work properly. 1994-02-06 22:02:25 +00:00
Rodney W. Grimes
52660a3119 Update for new organization of gnu tree. 1994-01-30 01:08:21 +00:00
Andrey A. Chernov
0def918bed remove HAVE_SETPGRP, because it doesn't detach terminal
in POSIX (setsid() is only way to do it)
1993-11-18 01:19:06 +00:00
Andrey A. Chernov
03e2b4a1fd IMAXBELL & PENDIN now cleared to satisfy new sio driver.
From Ian Taylor.
Fix POSIX CLOCAL behaviour, set controlling terminal after it.
Change VTIME from 0 to 1 to fix timeouts waiting for data
1993-11-18 01:03:18 +00:00
Andrey A. Chernov
590ab56698 From Ian Taylor.
Fix POSIX detach behaviour, based on setsid() call.
stpgrp(0,0) not used for POSIX now.
1993-11-18 00:59:17 +00:00
Rodney W. Grimes
05a078e0da Makefile to install sample files in /etc/uucp with correct ownership and
permissions
1993-10-14 12:18:29 +00:00
Rodney W. Grimes
242d29de40 Add subdir samples so that the sample scripts can get installed in /etc/uucp.
Add group to Makefile.inc for use in installing sample files
1993-10-14 12:17:58 +00:00
J.T. Conklin
3e0ac24dc1 SRCS should contain *.c's, not *.o's. 1993-08-16 16:22:34 +00:00
Rodney W. Grimes
f1d678eac9 Fixed manual page names from .0 to .8. 1993-08-06 23:38:29 +00:00
Rodney W. Grimes
fdb2069e27 Since there are no c sources in this directory we need a null depend:
target.  I added this.
1993-08-06 23:28:02 +00:00
J.T. Conklin
d7933e73a3 FreeBSD doesn't define sig_atomic_t in <signal.h> like it should... 1993-08-06 16:49:30 +00:00
J.T. Conklin
a5ebd84e62 Taylor UUCP 1.04 1993-08-05 18:28:27 +00:00