Stefan Eßer
71bc4af6ed
Fix potential buffer overflow and undefined behavior.
...
The buffer allocated in read_chat() could be 1 element too short, if the
chatstr parameter passed in is 1 or 3 charachters long (e.g. "a" or "a b").
The allocation of the pointer array does not account for the terminating
NULL pointer in that case.
Overlapping source and destination strings are undefined in strcpy().
Instead of moving a string to the left by one character just increment the
char pointer before it is assigned to the results array.
MFC after: 2 weeks
2019-01-26 20:43:28 +00:00
Edward Tomasz Napierala
18587b84c5
Build getty(8) with WARNS=6.
...
Reviewed by: imp@
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D14197
2018-02-21 15:57:24 +00:00
Dimitry Andric
50541c922e
In libexec/getty/chat.c, replace && with & in chat_send(). The intent
...
is to test if the CHATDEBUG_SEND bit is set in the chat_debug global.
MFC after: 1 week
2011-12-16 15:44:12 +00:00
Philippe Charnier
9f8c312911
Add __unused. Ansi prototypes.
2010-12-20 08:29:54 +00:00
Stefan Farfeleder
410f13a58d
Include gettytab.h before extern.h so that the declarations of struct
...
gettyflags, gettynums and gettystrs are available.
2005-04-06 17:42:24 +00:00
Bruce Evans
2dc8d58f59
Fixed a misspelling of 0 as NULL.
2004-03-14 05:27:26 +00:00
Jens Schweikhardt
d64ada501a
Fix typos, mostly s/ an / a / where appropriate and a few s/an/and/
...
Add FreeBSD Id tag where missing.
2002-12-30 21:18:15 +00:00
Bruce Evans
391a2becf1
Removed unused include of <sys/resource.h> instead of depending on
...
namespace pollution only 1 layer deep in <sys/stat.h> for its
prerequisite <sys/time.h>
Removed other unused includes.
2002-02-25 02:18:36 +00:00
Warner Losh
95289b278a
o __P removal
...
o remove register
o use strict prototypes
2002-02-06 16:38:40 +00:00
Peter Wemm
7f3dea244c
$Id$ -> $FreeBSD$
1999-08-28 00:22:10 +00:00
Philippe Charnier
d748864d2c
Correct incompletes .Xrs. Remove duplicate #includes and unused variables.
1997-11-21 07:43:53 +00:00
David Nugent
b92f6bd2b8
Use cgetustr() since we handled special escapes ourselves.
...
Fix typo in escape parsing function.
PR: 4370
Submitted by: sumii@is.s.u-tokyo.ac.jp
1997-09-01 10:06:05 +00:00
Peter Wemm
9e522f7a18
Revert $FreeBSD$ to $Id$
1997-02-22 14:22:49 +00:00
David Nugent
26015440b9
Tidy-up modem-chat handling: ensure tty modes are restored to
...
'sane' standard (not raw) settings before abort/exiting; move
responsibility of setting raw mode for chat-handling out of
chat.c to avoid doing redundant tc{s,g}etattr()s; move DE
pause prior setting standard mode before issue/login prompt to
avoid echoing modem connect strings. Fixed up comment styles
in a couple of places.
1997-02-09 16:12:08 +00:00
David Nugent
fe552114a3
Added:
...
ic=expect/send script modem init script
ac=expect/send script modem answer script
ct#val chat script timeout (seconds)
rt#val recycle timeout (seconds) if 'ac' set
dc#val debug bitmask for debugging chat scripts
hw (boolean) enable crtscts handshaking
if=path 'issue' file sent prior login prompt
chat.c is a simplistic expect/send chat module.
1997-02-02 14:24:57 +00:00
