Commit Graph

27 Commits

Author SHA1 Message Date
Xin LI
617efa7ad5 Cleanup:
- Change signedness of nxtfld() to make msgs(1) WARNS=6 clean
 - Add several static's
2005-01-17 17:45:38 +00:00
Bruce Evans
263bf898e0 Fixed misspellings of '\0' as NULL. 2004-03-11 10:12:05 +00:00
Mike Barcroft
2d979824f5 Fix singular/plural confusion in a printf.
PR:		47953
Submitted by:	Volker Stolz <stolz@i2.informatik.rwth-aachen.de>
MFC after:	3 days
2003-02-06 22:39:44 +00:00
David Malone
f4ac32def2 ANSIify function definitions.
Add some constness to avoid some warnings.
Remove use register keyword.
Deal with missing/unneeded extern/prototypes.
Some minor type changes/casts to avoid warnings.

Reviewed by:	md5
2002-09-04 23:29:10 +00:00
Juli Mallett
3a7fc8ce59 Remove local prototypes for main(). 2002-08-19 03:07:56 +00:00
Bruce Evans
fe3736d468 Fixed some style bugs:
- ifdefs around vendor sccsid were left reversed after switching to
  __FBSDID().
- vertical whitespace after some of the non-FALLTHROUGH cases was lost.
- too much vertical whitespace before prototypes.
2002-04-18 13:02:17 +00:00
Bruce Evans
7be9c056ce Backed out the style bugs in rev.1.17:
- don't use unusual indentation for 39 lines of declarations when only 2
  of the lines benefit from it.
- don't use __DECONST().  This was the one use of it in the tree, and it
  was just wrong.  It was used to hide the warning about tgetnum() having
  the wrong prototype (missing a `const') due to libncurses being
  misconfigured.  libncurses has been fixed, so the original code now
  compiles cleanly with WARNS=4.
2002-04-18 12:53:39 +00:00
Philippe Charnier
20c58ba5f7 Document that only superuser can use -c option. Add FBSDID. Make use of uid_t
to silent lint. fprintf -> err conversion. Add some FALLTHROUGH and NOTREACHED
comment to silent lint.
2002-04-12 13:11:42 +00:00
Warner Losh
d3cb5ded92 remove __P 2002-03-22 01:33:25 +00:00
Andrey A. Chernov
005ee369ed File positions are off_t nowdays, not long, so:
fseek -> fseeko
    ftell -> ftello
    fseek(x, 0L, 0) -> rewind(x)

    NOTE: that fseek/ftell not works for >long offsets per POSIX:

    [EOVERFLOW] For fseek( ), the resulting file offset would be a value which
    cannot be represented correctly in an object of type long.

    [EOVERFLOW] For ftell ( ), the current file offset cannot be represented
    correctly in an object of type long.
2001-09-03 04:30:46 +00:00
Kris Kennaway
5f0e809ac0 Fix WARNS=2 warnings on alpha and i386 and clamp it down 2001-05-26 21:49:29 +00:00
Kris Kennaway
08e61f6489 MFS: Don't allow printf directives in PAGER
Obtained from:	OpenBSD
2000-07-07 00:24:13 +00:00
Peter Wemm
c3aac50f28 $Id$ -> $FreeBSD$ 1999-08-28 01:08:13 +00:00
Matt Jacob
0de83b4407 Apply suggested patch- seems reasonable.
PR:		12020
Submitted by:	Matthew D. Fuller <fullermd@futuresouth.com>
1999-07-24 17:49:17 +00:00
Guy Helmer
9629cc1275 Revert "POSIX saved uids change". seteuid(2) is not POSIX, and
FreeBSD does not have _POSIX_SAVED_IDS enabled.  Thanks to Warner Losh
and Ollivier Robert for pointing this out, and Bruce Evans for explaining
the role of _POSIX_SAVED_IDS.
1998-07-14 19:07:30 +00:00
Guy Helmer
932634cdff Security and minor functionality changes based on OpenBSD msgs.c:
tmp file (mktemp changed to mkstemp), saved POSIX uids, buffer overflow,
and use PAGER environment variable if set.
Obtained from: OpenBSD
1998-07-09 14:06:54 +00:00
Jordan K. Hubbard
df1da01e0e Previous fix didn't make it past the Bruce filter. Clean up
non-KNF indentation and use err() properly.
1998-07-07 22:20:50 +00:00
Jordan K. Hubbard
0b1778905f msgs -p (and maybe other flags, too) gives misleading error messages,
especially on a new install, where /var/msgs/bounds doesn't exist.  I
        moved my bounds file out of the way to create this before and after
        on a quick 'n' dirty hack, which is probably the 23rd best way to do it,
        but it works:

PR:		6963
Submitted by:	Matthew Fuller <fullermd@mortis.futuresouth.com>
1998-07-07 12:02:59 +00:00
Philippe Charnier
e46a3508d0 Use err(3).
sprintf -> snprintf from OpenBSD.
Add usage(), prototypes.
Use MAXPATHLEN instead of 128 from OpenBSD.
Obtained from: OpenBSD
1997-07-29 06:47:18 +00:00
Bruce Evans
0c8ea4d48c Eliminated includes of the "temporary" backwards compatibility header
<sys/dir.h> in applications.  Maintained existing (inadequate) ifdefs
for dir.h vs dirent.h in libdialog, amd and rarpd, but didn't add any
new ones.
1996-09-24 08:08:11 +00:00
Andrey A. Chernov
da3b2e6612 Localize it 1995-12-13 12:54:26 +00:00
David Greenman
0ee0bd8331 Initialize some uninitialized variables to fix a bug that sometimes
resulted in msgs doing strange things, including getting stuck in an
infinite loop.
1995-12-06 07:34:49 +00:00
Andrey A. Chernov
8b761b33c1 Default file creation mask was 666 (allow othres write anything
to msgs directory), change it to 644
1995-11-19 16:55:50 +00:00
Rodney W. Grimes
7799f52a32 Remove trailing whitespace. 1995-05-30 06:41:30 +00:00
Rodney W. Grimes
1a4e9088d5 Fix nested comments for -Wcomment warnings. 1995-05-09 13:13:29 +00:00
Garrett Wollman
59bfb274d1 Use tcflush(), eliminate libcompat. 1995-02-21 04:15:15 +00:00
Rodney W. Grimes
9b50d90275 BSD 4.4 Lite Usr.bin Sources 1994-05-27 12:33:43 +00:00