Commit Graph

48 Commits

Author SHA1 Message Date
Ken Smith
327433d2a2 Selecting amd and a few other things in the Networking config section
caused a segfault.  It turns out that in pre-7.0 systems if you do
getenv("amd_enable=YES") it will return the setting of the environment
variable "amd_enable" but now it returns NULL.  I think I found the
places where sysinstall was potentially relying on that old behavior.
Fix is to make a copy of the string to be used for the getenv(3) call,
look for a '=' character in it, and replace it with '\0' if one is
found.  Stuck to sysinstall's typical coding standards despite urges
to do otherwise.

PR:		117642
MFC after:	2 days
2007-10-30 05:03:37 +00:00
John Baldwin
9d4514b0fd Fix numerous warnings. Aside from menu items in system.c and menu.c
this now compiles on i386 with WARNS?= 3.  Most of the fixes included
adding missing 'static' keywords to internal functions, using fully-defined
terminators in statically defined arrays of structs, and various
signed vs unsigned mismatches.  Also G/C'd unused configSecurity()
function.
2006-02-28 21:49:33 +00:00
John Baldwin
d30d1cdee6 - Autogenerate a menu containing a list of countries and keymaps supported
by syscons.
- If we are running as init, popup the country menu before the main menu.
  If a non-default country is chosen, then a second menu is brought up
  to let the user choose a keymap.  By default the default keymap for
  the country that was selected is highlighted.  If the user chooses the
  default country, then the default keymap is just assumed and the user
  is not presented with the keymap menu.  Currently the default country
  is set to "United States" except for PC98 which assumes "Japan".

PR:		bin/93853
Submitted by:	Seth Kingsley sethk at magnesium dot net
MFC after:	3 days
2006-02-28 20:29:43 +00:00
Marcel Moolenaar
9862c36bfb Fix 3 'cast to pointer from integer of different size' warnings.
While here, fix the long line bugs in the same statements.
2003-09-17 03:45:30 +00:00
Jordan K. Hubbard
976e0e0dd0 Whoops - really make the "fix" I did to the dmenuToggleVariable logic
work.
2000-03-08 14:20:26 +00:00
Jordan K. Hubbard
a90fc31d36 Toggle variables between YES and NO values, don't just set them to YES
or unset them.  That makes it impossible to turn something off.
2000-02-26 12:07:40 +00:00
Jordan K. Hubbard
7025aeb16e Completely rip-out and redesign sysinstall's refresh model as well
as redoing all the menus to have proper, or at least non-hallucinogenic,
keyboard accelerators.

This requires my recent update to libdialog to work properly and will
probably also exhibit some other "interesting" behavior while the last
few missing screen clears are found (which is why I'm not going to MFC
immediately).  At least now, however, sysinstall does not gratuitously
redraw random screens at the drop of a hat and drive serial console
installers out of their minds.
1999-12-14 04:25:29 +00:00
Peter Wemm
97d92980a9 $Id$ -> $FreeBSD$ 1999-08-28 01:35:59 +00:00
Jordan K. Hubbard
61bbe58e17 Ack! Correct a typo which crept into here and reshuffle the index back
into alphabetical order.
1999-02-06 08:45:20 +00:00
Jordan K. Hubbard
b1e7bed4c0 Add one more "escape" for marking internal variables. 1999-02-05 22:25:13 +00:00
Jordan K. Hubbard
63cad5499d Totally change the way variables are accounted for in sysinstall.
Now we know which variables are internal and which need to be
backed to /etc/rc.conf.site.  rc.conf is not touched now.

Also kget kernel change information back properly and set up a loader.rc
file to use it.
1999-02-05 22:15:52 +00:00
Jordan K. Hubbard
1860722c6b Fix some bogons with variable handling. 1998-03-15 19:30:49 +00:00
Jordan K. Hubbard
1a8a1188c0 Correct misfeature with quoting, better error reporting. 1998-03-10 17:24:08 +00:00
Jordan K. Hubbard
9addf1c150 Add a new startup variables menu for tweaking rc.conf variables in more
detail (also added more of them to the networking services menu).  Add
new dmenuISetVariable() function for interactive setting of non-boolean
flags.
1997-10-14 18:17:35 +00:00
Paul Traina
69ac164732 Put all variables in VAR_ #define's to force a single location for all
of these magic knobs.  This is purely cosmetic and a documentation issue
so we don't have to glop through the source code looking for gems.
1997-09-17 16:18:22 +00:00
Jordan K. Hubbard
08e6881746 YAMF22 1997-06-13 14:21:22 +00:00
Peter Wemm
b97fa2ef50 Revert $FreeBSD$ to $Id$ 1997-02-22 14:13:04 +00:00
Jordan K. Hubbard
b4045b65fe Correct a real brain-o in my check for when a "fixup" should be run.
Don't recreate parent menus just for submenus - it's irritating.
1997-01-19 10:27:12 +00:00
Jordan K. Hubbard
1130b656e5 Make the long-awaited change from $Id$ to $FreeBSD$
This will make a number of things easier in the future, as well as (finally!)
avoiding the Id-smashing problem which has plagued developers for so long.

Boy, I'm glad we're not using sup anymore.  This update would have been
insane otherwise.
1997-01-14 07:20:47 +00:00
Jordan K. Hubbard
e5b09b7d10 Do something I've wanted to do for quite some time - collapse all the
common layout code into some work functions and make all the layout-using
routine adopt them.  Also reorganize includes and generally clean up.
1997-01-03 06:32:39 +00:00
Jordan K. Hubbard
00b69db338 As Paul has just pointed out, much of my strncpy() usage was either
bogus or overly complex and really needed to be done more consistently
and sanely throughout - no question about it.  Done.

Suggested-By: Paul Traina <pst@Shockwave.COM>
1996-12-09 08:22:19 +00:00
Joerg Wunsch
9b23ef93f3 Sysinstall now offers the installation of a keymap early in the game!
Not all mappings are supported, most languages come only with one
encoding since this should be sufficient to get up & running in using
sysinstall, and we are already pretty tight on space.  (My previous
commit has already bumped the boot MFS size by another 50 KB for
this.)

This feature requires the `kbdcontrol -L' i've just committed.  Plain
text keymaps and the entire scanner are overkill for sysinstall.

Also updated the list of available keymaps while i was at it.

Reviewed by:	jkh
1996-11-09 16:47:08 +00:00
Jordan K. Hubbard
663b45cb90 Joerg's changes to add screen font and screenmap setting.
Some changes of my own to make screen saver configuration a little
more sane, and also make it easier to get to the keyboard/screen
setup from the options menu.
1996-11-07 08:03:29 +00:00
Jordan K. Hubbard
96a9d7fb41 Try to make screen update more efficient (less flickering) by more
judicious use of dialog_clear_norefresh().
1996-08-03 10:11:56 +00:00
Jordan K. Hubbard
a19596c5a8 Close PR#1542. Don't just assume 24 lines, get the tty size.
Some things may still display text on the 24th line, but that's because
they've always been screens designed to fit into a minimal real-estate
and have hardwired assumptions about the dimensions.  They'll be a little
harder to make dynamic.
1996-08-01 10:58:54 +00:00
Jordan K. Hubbard
bd5706a78a Make the menu height calculation actually work.
Make a menu more self-explanatory at user request.
1996-07-11 18:37:48 +00:00
Jordan K. Hubbard
2dc1c61598 Support compressed doc files again.
Add a few strategic screen clears.
Do a lot less wasted screen I/O in restoring screen contents that don't need
restoring.
Use tar instead of cp to back up /etc in installUpdate.
Don't panic when upgrade shell exits.
1996-07-05 08:36:02 +00:00
Jordan K. Hubbard
3b307053cb Make it plainer how to exit. 1996-07-02 01:03:55 +00:00
Jordan K. Hubbard
061e2fb9a6 Fix a truly stupid bug which broke the package installation menu
for everything _but_ the multi-user case now (it was the opposite before :-).
That means adding packages with the 2.2-960511-SNAP boot floppy is busted. Feh.
1996-06-12 14:02:13 +00:00
Jordan K. Hubbard
ba67e870cb Bump snapshot release date - looks like I was off by a couple
of days!

More display fixes to sysinstall and assorted tweaking.
1996-04-28 00:37:38 +00:00
Jordan K. Hubbard
18b1c03d52 Quite a few changes:
1. Fix the last display bugs (I hope) by use of dialog rebuilds at stategic
   points.
2. Clean up the distributions menus so that everybody (that's reasonable)
   has All and Clear options for setting/clearing things en-masse.
3. Various attempts at display optimization.
4. Change the wording of the `Don't use Write!' dialogs to make them more
   explicitly define when and when not to use the option.
1996-04-25 17:31:27 +00:00
Jordan K. Hubbard
2113a60c4b Bring this into sync.
I still have a _very very annoying_ display bug which occurs when a menu
item causes a submenu to be displayed - the screen repaints for the original
menu (which is restored upon return from the submenu) are off by about 4
characters.  I've tried restoring the screen, the cursor position, you name
it - same deal.  Grrrr!  This commit is my first step in trying to get someone
else to help me look into this one since I'm just tearing my hair out at this
point!
1996-04-23 01:29:35 +00:00
Jordan K. Hubbard
af4cbec4e1 1. Update all the copyrights to delete useless clauses 3 and 4.
2. Change more of the menu code over to new system.
3. Streamline label editor.
1996-04-13 13:32:15 +00:00
Jordan K. Hubbard
957bdf511e Major surgery.
1. Use new dialog menu hacks (no strings, just arrays of dialogMenuItem structs)
   so that I can create composite menus with radio/checkbox/... items in them,
   removing some long-standing UI bogons in various menus.  This work isn't
   finished yet, but will be done in two phases.  This is phase one.

2. Remove all the script installation stuff.  I never got time to document it,
   it was arcane and it just complicated much of the code.  There are better
   ways of doing this if I want to do auto-driven installations later.

3. Remove much dead code and otherwise attempt to remove as much historical
   grot as possible so that this code is easier to hack on.  This is also
   a two-stage process, phase one of which is now complete.
1996-04-07 03:52:36 +00:00
Jordan K. Hubbard
e07e86d046 Miscellaneous cleanup before big round of menu restructuring (to use new
libdialog features).
1996-03-02 07:31:58 +00:00
Peter Wemm
40b0c0d936 Update the -current sources from the 2.1 branch.
Approved (in spirit) by: jkh
1995-12-07 10:34:59 +00:00
Rodney W. Grimes
d3628763db Merge RELENG_2_0_5 into HEAD 1995-06-11 19:33:05 +00:00
Rodney W. Grimes
e5370bd7fe Remove trailing whitespace. 1995-05-30 08:29:07 +00:00
Jordan K. Hubbard
a098749d6b Bring everybody up to date on my morning's work.
1. Fix a few bugs in the ftp installation code and implement proper
   ftp and network shutdown routines.

2. Clean up the menus a fair bit - add a FreeBSD configuration menu.

3. Eliminate the last of the "chaining" - the installation now does
   the most obvious thing in the most obvious cases and doesn't present
   you with more menus than you were expecting.  This makes it necessary to be
   a little more explicit in places, but it's still less confusing.

4. Add a few more safety nets for the user.  Change a few hard-and-fast
   limits to warnings (it now runs as non-root, Bruce).

5. Add descriptions for all the supported ethernet cards.

6. Make the cpio floppy extract put up a menu requesting the drive you wish
   to use if you have more than one; don't just always assume drive A.
1995-05-24 17:49:20 +00:00
Jordan K. Hubbard
d0eeafc570 Commit my latest so that Gary can sync up - this version should also
be the grounds for our first round of testing in the release I'm rolling.
It doesn't load the distributions yet, but it should do everything else.
1995-05-17 14:40:00 +00:00
Jordan K. Hubbard
3dee6615c7 This does _not yet compile_; I'm simply bringing in my changes from
this weekend in order to more easily sync with my CVS tree at home.
Another commit relative to these changes will follow shortly.
1995-05-16 02:53:31 +00:00
Jordan K. Hubbard
dae062c15f First round of changes after testing this on actual systems. Clean up
some of the badly displayed menus, use the proper notification box for
messages, make proceed work.
1995-05-11 06:10:56 +00:00
Jordan K. Hubbard
4ec1f4bcf2 Whoops - dispatch() takes multiple args now. 1995-05-10 08:00:47 +00:00
Jordan K. Hubbard
351669d743 Fold in all my recent changes.
Do another clean-up pass over this, making the generic menu handler much
more powerful (now handles multiple dispatch).  A few more menus fleshed
out and the beginnings of the distribution handler committed.  Should
be transfering full distributions over in the next commit.
1995-05-10 07:45:00 +00:00
Jordan K. Hubbard
411bac67a7 Commit my latest changes before having a nap. Still not close to done,
nor is it in sync with my working sources, but it leaves me less CVS hassles
to bring in the new files at this time.  Still no documentation to translate
quite yet, but soon.  This stuff is actually very close now.
1995-05-01 21:56:32 +00:00
Jordan K. Hubbard
e40a316fcf o Add extra menu types (radio implemented, multiple choice shortly).
o Make the framework generally more robust.
o Figured out how to nest the menu descriptions - no more grotty initialization
  of menus.
o Fix bug with helpline and helpfile not being reset.
o Add stubs for the media selection code.

Coming next:  Fdisk and disklabel screens using Phk's new libdisk stuff.
1995-04-29 19:33:06 +00:00
Jordan K. Hubbard
ef42570d65 Latest raft of changes.
Added another couple of menu item types.

Reshuffled the menus and added a few more.  Sure wish I could figure out
how to initialize a menu with _one_ initializer rather than two! :(
1995-04-27 18:03:55 +00:00
Jordan K. Hubbard
4e278bdb76 Here is my first "framework" commit of the new sysinstall. There is a LOT
more to come in the next 24 hours, this is just the first stable result of
8 hours of hacking so far.  The specification format for menus is pretty
much hammered out and the beginnings (very humble) of the doc hierarchy
are present for an example.  It should be quite easy to add a lot more
menus quickly to this since I did go somewhat out of my way to make the
framework easy to work with.  This is NOT the glorious semi-graphical
sysinstall (or whatever its name will be) that the install-geeks are working
on, this is simply the "son of sysinstall" I've been promising to write in
the interim for 2.0.5 and 2.1R (super install doesn't come until 2.2R).
1995-04-27 12:50:35 +00:00