Commit Graph

216 Commits

Author SHA1 Message Date
Kris Kennaway
d0899afa3a Disallow libdialog to be used in setugid applications; it is chock full
of buffer overflows.

MFC after:      3 days
2002-10-12 20:32:03 +00:00
Peter Wemm
224af215a6 Zap now-unused SHLIB_MINOR 2002-09-28 00:25:32 +00:00
Garrett Wollman
bf153e6922 Quiet another annoying warning. 2002-09-09 17:44:08 +00:00
Ruslan Ermilov
d2893b161b Drop support for COPY, -c has been the default mode of install(1)
for a long time now.

Approved by:	bde
2002-07-29 09:40:17 +00:00
Ruslan Ermilov
0b87f79976 s/${INSTALL} -c/${INSTALL} ${COPY}/ 2002-07-18 12:07:49 +00:00
Doug Barton
ca2ca2ab60 In addition to exiting the dialog via ESC, the user could also have
exited via \r, \n, or ' ' (space); all of which are valid,
non-error responses.
2002-06-13 23:39:35 +00:00
Mike Barcroft
cb263c3594 Use POSIX macros for wait(2)-style status information instead of the
deprecated 4.2/4.3BSD wait union.  Fix some nearby pid_t/int
confusion.
2002-06-03 23:13:11 +00:00
Garrett Wollman
0d542a4797 Add used includes of <stdlib.h>. 2002-05-30 19:49:21 +00:00
Ruslan Ermilov
c7b111cba8 Added new bsd.incs.mk which handles installing of header files
via INCS.  Implemented INCSLINKS (equivalent to SYMLINKS) to
handle symlinking include files.  Allow for multiple groups of
include files to be installed, with the powerful INCSGROUPS knob.
Documentation to follow.

Added standard `includes' and `incsinstall' targets, use them
in Makefile.inc1.  Headers from the following makefiles were
not installed before (during `includes' in Makefile.inc1):

	kerberos5/lib/libtelnet/Makefile
	lib/libbz2/Makefile
	lib/libdevinfo/Makefile
	lib/libform/Makefile
	lib/libisc/Makefile
	lib/libmenu/Makefile
	lib/libmilter/Makefile
	lib/libpanel/Makefile

Replaced all `beforeinstall' targets for installing includes
with the INCS stuff.

Renamed INCDIR to INCSDIR, for consistency with FILES and SCRIPTS,
and for compatibility with NetBSD.  Similarly for INCOWN, INCGRP,
and INCMODE.

Consistently use INCLUDEDIR instead of /usr/include.

gnu/lib/libstdc++/Makefile and gnu/lib/libsupc++/Makefile changes
were only lightly tested due to the missing contrib/libstdc++-v3.
I fully tested the pre-WIP_GCC31 version of this patch with the
contrib/libstdc++.295 stuff.

These changes have been tested on i386 with the -DNO_WERROR "make
world" and "make release".
2002-05-12 16:01:00 +00:00
Ruslan Ermilov
973698b38b Fixed memory leak in dialog_gauge(3).
PR:		gnu/32260
Submitted by:	Igor Pokrovsky <tiamat@telegraph.spb.ru>
MFC after:	3 days
2001-11-29 07:42:13 +00:00
Bruce Evans
d703551558 Fixed missing return type in synopsis. 2001-10-03 04:01:51 +00:00
Ruslan Ermilov
32eef9aeb1 mdoc(7) police: Use the new .In macro for #include statements. 2001-10-01 16:09:29 +00:00
Eric Melville
ae0b7d588a Properly move cursor when home and end keys are used. 2001-08-31 01:56:06 +00:00
Eric Melville
eb84be870e Handle keys consistently. 2001-08-09 01:14:09 +00:00
Ruslan Ermilov
4ad7956eb6 dialog(3) -> dialog_noyes(3). 2001-08-07 12:13:22 +00:00
Eric Melville
2180c55b9c Update man page to actually match the source.
PR:		7456
2001-08-01 06:23:00 +00:00
Eric Melville
5dc547c27e Properly update cursor position when the list is scrolled. 2001-07-26 05:35:19 +00:00
Eric Melville
b48baf886a Handle keys consistently. 2001-07-26 03:34:43 +00:00
Eric Melville
87aaead2f8 Improve the interface provided by libdialog. Move a cursor around over
the components and trigger actions based on its position. This reduces
the need to remember the functions of various keys, and makes the
interface more consistant across library.
~
2001-07-18 05:21:37 +00:00
Ruslan Ermilov
63919764c2 mdoc(7) police: removed HISTORY info from the .Os call. 2001-07-10 10:42:19 +00:00
Brian Somers
7bc6d0158f Fix the type of the NULL arg to execl()
Idea from: Theo de Raadt <deraadt@openbsd.org>
2001-07-09 09:24:06 +00:00
Ruslan Ermilov
eb0838029f mdoc(7) police: normalize .Nd. 2001-04-18 15:54:10 +00:00
Ruslan Ermilov
e5ac5644e2 MAN[1-9] -> MAN. 2001-03-27 14:59:06 +00:00
Jordan K. Hubbard
5c0ebacbcd Properly orient the buttons for yes/no and no/yes so that POLA is
observed.  This fixes the "no/yes box jumps buttons around" problem.

PR:		gnu/24487
Submitted by:	Gerhard Sittig <Gerhard.Sittig@gmx.net>
2001-02-24 18:52:56 +00:00
Ruslan Ermilov
d0353b836e mdoc(7) police: split punctuation characters + misc fixes. 2001-02-01 16:38:02 +00:00
Ruslan Ermilov
b77b3c00be mdoc(7) police: Ft/Vt now accept punctuation-type arguments. 2001-01-12 15:46:56 +00:00
Ruslan Ermilov
1c232e52cd Prepare for mdoc(7)NG. 2000-12-27 13:59:17 +00:00
Jordan K. Hubbard
e6657d443e Add a new function, dialog_noyes(), for sysinstall to be able to
present questinos with a different default answer.  Somebody submitted
a patch to me once which did something this but I lost it (my bad) so
I'm just going to re-implement it with thanks to whomever it was who
gave me the idea.
2000-12-14 02:35:22 +00:00
Ruslan Ermilov
48d1139d2a mdoc(7) police: Add a missing `.Sm on' request. 2000-11-21 18:18:46 +00:00
Brian Somers
f91f965e85 include <sys/types.h> 2000-10-15 20:49:53 +00:00
Andrey A. Chernov
22ed5ae46b Remove unneded -lmytinfo 2000-09-16 04:27:30 +00:00
Brian Feldman
559048567a This is the second half of unbreaking the world build. Add a -DNOHTML
corollary for -DNOINFO and -DNOMAN.  I'll fix this properly (add
specific HTML doc magic) in the .mk files later; right now, just
unbreak the world.
2000-01-11 12:51:56 +00:00
Brian Feldman
c9215ae2ed *draws his sword*
I smite thee, vile buildworld breakage!

The story is that these were added to beforeinstall improperly.  In our
beforeinstall, a full mtree has not been populated.  Since the tree is
not populated, we explode from missing directories on doc install.  It
should not be done in beforeinstall (includes) anyway.
2000-01-11 12:37:57 +00:00
Jordan K. Hubbard
7207f9e28e This change was mis-identified as the problem, sorry. It appears to be
an anomaly restricted only to the alpha in FreeBSD-current (weird).
2000-01-11 03:27:33 +00:00
Jordan K. Hubbard
6ea1a2ddfc Back out the previous change to install the examples - it breaks the release builds. 2000-01-11 02:18:33 +00:00
Alexey Zelkin
54294f4494 Install contents of the TESTS subdirectory to /usr/share/examples/libdialog 2000-01-10 12:04:18 +00:00
Alexey Zelkin
52a7c4d030 Remove -lncurses and -lmytinfo from LDFLAGS 2000-01-10 11:54:55 +00:00
Alexey Zelkin
c11c0da371 Cleanup warnings. 2000-01-10 11:52:10 +00:00
Alexey Zelkin
d5083ac4a1 Completely reconstruct page. Make it mdoc(7) style compatible also :)
Page still needs some work about english refinements and some actualization.
2000-01-10 09:29:21 +00:00
Jordan K. Hubbard
9639dc68d7 *Really* make space accelerators work; no wonder Brian McGovern was
confused!  I fat-fingered the first commit.
1999-12-17 02:44:09 +00:00
Jordan K. Hubbard
34fa097361 Prevent spaces from being interpreted as accelerators. 1999-12-14 04:18:22 +00:00
Marcel Moolenaar
3cf3c5d9dd sigset_t change (part 5 of 5)
-----------------------------

Most of the userland changes are in libc. For both the alpha
and the i386 setjmp has been changed to accomodate for the
new sigset_t. Internally, libc is mostly rewritten to use the
new syscalls. The exception is in compat-43/sigcompat.c

The POSIX thread library has also been rewritten to use the
new sigset_t. Except, that it currently only handles NSIG
signals instead of the maximum _SIG_MAXSIG. This should not
be a problem because current applications don't use any
signals higher than NSIG.

There are version bumps for the following libraries:
  libdialog
  libreadline
  libc
  libc_r
  libedit
  libftpio
  libss

These libraries either a) have one of the modified structures
visible in the interface, or b) use sigset_t internally and
may cause breakage if new binaries are used against libraries
that don't have the sigset_t change. This not an immediate
issue, but will be as soon as applications start using the
new range to its fullest.

NOTE: libncurses already had an version bump and has not been
      given one now.

NOTE: doscmd is a real casualty and has been disconnected for
      the moment. Reconnection will eventually happen after
      doscmd has been fixed. I'm aware that being the last one
      to touch it, I'm automaticly promoted to being maintainer.
      According to good taste this means that I will receive a
      badge which either will be glued or mechanically stapled,
      drilled or otherwise violently forced onto me :-)

NOTE: pcvt/vttest cannot be compiled with -traditional. The
      change cause sys/types to be included along the way which
      contains the const and volatile modifiers. I don't consider
      this a solution, but more a workaround.
1999-09-29 15:18:46 +00:00
Peter Wemm
63fdd4420d #include <termios.h> 1999-08-30 08:10:42 +00:00
Peter Wemm
9b7a44a60e $Id$ -> $FreeBSD$ 1999-08-27 23:37:10 +00:00
Mike Pritchard
2ce66fb320 Various man page cleanup:
- Sort xrefs
- Be consistent with section names as outlined in mdoc(7).
- Other misc mdoc cleanup.

PR:		doc/13144
Submitted by:	Alexey M. Zelkin <phantom@cris.net>
1999-08-15 09:06:06 +00:00
Warner Losh
bdca080cce Use braces to avoid potentially ambiguous else clause.
main's return type is int not void.

Reviewed by: obrien and chuckr
1999-04-25 22:14:06 +00:00
Bruce Evans
e06fbe492b Don't use backslash-newline to split the too-long line for
".Fn dialog_ftree ...", since my synopsis checker doesn't support it
and no other too-long .Fn lines are split.
1999-03-05 14:43:29 +00:00
Jordan K. Hubbard
90103ada10 Add documentation for new tree functions.
Submitted by:	Anatoly A. Orehovsky <tolik@mpeks.tomsk.su>
1998-10-02 11:23:47 +00:00
Jordan K. Hubbard
8091c27e9f Add missing free().
Submitted by:	Anatoly A. Orehovsky <tolik@mpeks.tomsk.su>
1998-09-30 12:09:12 +00:00
Jordan K. Hubbard
a53cd3d253 Add examples for tree functions.
Submitted by:	"Anatoly A. Orehovsky" <tolik@mpeks.tomsk.su>
1998-09-29 12:22:46 +00:00
Jordan K. Hubbard
0726f7f509 Add support for saved trees.
Submitted by:	"Anatoly A. Orehovsky" <tolik@mpeks.tomsk.su>
1998-09-29 12:22:36 +00:00
Jordan K. Hubbard
31f0cd629b Update tree function and remove gratuitous .h file.
Submitted by:	"Anatoly A. Orehovsky" <tolik@mpeks.tomsk.su>
1998-09-28 16:12:49 +00:00
Jordan K. Hubbard
92587d7333 Unbump the minor number; guess this doesn't happen in the ELF world
anymore and maybe we should nuke the meaning if MINOR altogether. :)
1998-09-28 00:52:53 +00:00
Jordan K. Hubbard
2a09091a34 Add some new functionality which I promised to add over a year a go and
shamefully dropped on the floor.  I need to add it now since it does a
minor number bump, but otherwise the current functionality of libdialog
is unchanged (in all its evil glory) and the change is non-intrusive.
Submitted by:	"Anatoly A. Orehovsky" <tolik@mpeks.tomsk.su>
1998-09-26 12:29:57 +00:00
Warner Losh
486a7ab25b Fix bogus length restriction on readlink. Use sizeof(buf) - 1 rather
than the size of the directory name.  Fix style bug which increased
the number of lines > 80 characters by one.

Pointed out by: bde
1998-09-10 16:14:29 +00:00
Warner Losh
1508e89cc6 Use size of structure rather than hard coded 256 in readlink. This change
either came from OpenBSD, or was inspired by work done there.
1998-09-09 17:12:58 +00:00
John Birrell
6bdef94d87 Change the aux field type to long instead of int so that it is large
enough to hold a man-sized pointer.
1998-08-20 21:39:28 +00:00
Joseph Koshy
9c727d2ca9 Spelling corrections.
PR: 6868
Submitted by: Josh Gilliam <josh@quick.net>
1998-06-06 05:50:53 +00:00
Jordan K. Hubbard
d1b7206119 Fix improperly re-entrant code which caused the menu spammage we've
been seeing since 2.2.1.
Pointed-in-the-right-direction by:	phk
1997-10-12 12:09:46 +00:00
Bruce Evans
18b29797da Fixed synopsis. There was a missing arg, 3 args with the wrong type,
and many apparent dependendcies on <sys/types.h> from use of u_char.
<dialog.h> avoids u_char, so avoid it here too.
1997-04-13 12:36:42 +00:00
Jordan K. Hubbard
ab9b932c99 YAMF22 1997-03-29 19:51:48 +00:00
Andrey A. Chernov
5ee71a0d7b Fix various overflows for items longer then menu width.
Fix cursor place after PgUp/PgDn.

Should go into 2.2
Submitted by: "Anatoly A. Orehovsky" <tolik@mpeks.tomsk.su>
1997-02-28 19:18:47 +00:00
Peter Wemm
fce15c9ab3 Revert $FreeBSD$ to $Id$ 1997-02-22 15:48:31 +00:00
Andrey A. Chernov
113b1c5fe5 When wrong directory choosed and chdir failed, directory name
was not reset to old name causing any file choosen put error
diagnostic about wrong directory, fix it by resetting back
to old name after chdir failed.

Add \r as alias to \n, some telnets have problem with that.

Should go into 2.2
Submitted by: "Anatoly A. Orehovsky" <tolik@mpeks.tomsk.su> & me
1997-02-18 14:26:24 +00:00
Jordan K. Hubbard
a59ff6e254 Go on one of my periodic rampages through this code, trying to make
it DTRT.  In the process, discover the usual 10-15 evil bogons which
have been lurking in it for years.  This closes, for one thing, the
recent report Mike Smith made about nested checklist menus returning
with the scrolling region messed up.
1997-01-17 08:19:19 +00:00
Jordan K. Hubbard
75c6403334 Allow emacs-style next/prev characters as well as arrow keys so that
I can offer this as a consistent feature.
1997-01-15 02:50:48 +00:00
Jordan K. Hubbard
1130b656e5 Make the long-awaited change from $Id$ to $FreeBSD$
This will make a number of things easier in the future, as well as (finally!)
avoiding the Id-smashing problem which has plagued developers for so long.

Boy, I'm glad we're not using sup anymore.  This update would have been
insane otherwise.
1997-01-14 07:20:47 +00:00
Joerg Wunsch
65fb557e51 Pull the fix from rev 1.31.2.1; i've accidentally committed it to
2.2 first.
1996-12-26 18:47:11 +00:00
Jordan K. Hubbard
fac5450c4f Somewhere along the way, multiple targets started working and nobody
noticed.
1996-12-14 16:40:05 +00:00
Jordan K. Hubbard
ae5b2dcf86 Add another hateful global to libdialog (what the heck, there are already
so many).  For now, the only extended attribute implemented is NO ECHO,
useful for things like passwords.  See TESTS/input2.c for an example.
This should go into 2.2.
1996-12-14 16:14:21 +00:00
Jordan K. Hubbard
fb46ad63d7 Line up some of these OK boxes properly again. 1996-12-12 11:05:59 +00:00
Jordan K. Hubbard
3cd2d3f69a "CONTINUE" was just too long. Make it a nice "OK" now. 1996-10-04 13:06:48 +00:00
Bruce Evans
0c8ea4d48c Eliminated includes of the "temporary" backwards compatibility header
<sys/dir.h> in applications.  Maintained existing (inadequate) ifdefs
for dir.h vs dirent.h in libdialog, amd and rarpd, but didn't add any
new ones.
1996-09-24 08:08:11 +00:00
Jordan K. Hubbard
e36f5f6c56 Make button highlighting more visible on B/W displays. 1996-09-06 09:36:45 +00:00
Jordan K. Hubbard
09059a0b45 Collapse some common arrow key handling semantics from sysinstall into
PollObj(), simplifying code which uses it.
1996-09-01 08:16:00 +00:00
Peter Wemm
345be915f7 cmp -s || install -c ==> install -C 1996-08-30 02:12:07 +00:00
Jordan K. Hubbard
71a074386a Reverse my patch which erroneously removed the library dependencies
for a library.  They're needed.
1996-08-13 12:46:10 +00:00
Jordan K. Hubbard
8a80fd427c Throw some unnecessary dreck out of this Makefile. 1996-08-11 17:21:20 +00:00
Jordan K. Hubbard
15232ab26e 1. Remove some ancient bogons from when I initially added dialogMenuItem
support.
2. Have message boxes say "Continue" instead of "Exit"
1996-07-11 18:22:16 +00:00
Jordan K. Hubbard
1cca289947 Fix a couple of whoopers which somehow went undetected until now. 1996-07-11 11:15:28 +00:00
Jordan K. Hubbard
3bd9961585 Add missing dialog_clear() calls. 1996-07-05 07:42:23 +00:00
Jordan K. Hubbard
73410b698a Round out the examples a little better in showing custom buttons in operation
more than once.
1996-07-02 01:03:56 +00:00
Jordan K. Hubbard
d1efb9fdc2 Fix the OK/Cancel accellerator bogon I introduced a few days back. 1996-04-28 02:13:07 +00:00
Jordan K. Hubbard
1e702eb8a5 Fix what I just broke with DITEM_LEAVE_MENU 1996-04-27 07:09:41 +00:00
Jordan K. Hubbard
396df2aa3a Fix a bogon with ok/cancel callback usage. 1996-04-27 01:52:15 +00:00
Jordan K. Hubbard
7af0a5dbaf More custom hackery to deal with issues discovered in sysinstall. 1996-04-25 17:27:18 +00:00
Jordan K. Hubbard
ab112e9f34 Allow some post-fire actions to be combined in ways that weren't
possible before.
1996-04-25 13:34:37 +00:00
Jordan K. Hubbard
02836a445d alloca() was being called with highly bogus arguments due to brain
fade.  Fixed.
1996-04-25 01:50:18 +00:00
Jordan K. Hubbard
5553e30b48 Cosmetic tweaks. 1996-04-23 01:25:04 +00:00
Jordan K. Hubbard
7b75f15fa7 Another bug fix for the DITEM_REDRAW case. 1996-04-20 01:56:06 +00:00
Jordan K. Hubbard
060882c315 Make the DITEM_RECREATE option work properly. 1996-04-20 01:28:20 +00:00
Jordan K. Hubbard
d83f3d7544 Fix a bug which did not properly bias checklist items by their scroll
factor.
1996-04-19 10:39:16 +00:00
Jordan K. Hubbard
806a609d46 Remove a long-standing window leak I just noticed. 1996-04-18 13:36:39 +00:00
Jordan K. Hubbard
c50c22c798 Remove the special-case behavior for fire actions that return
DITEM_FAILURE - formerly they would simply act as an implicit "continue",
but this is wrong.  If you want this behavior, you should now return
with the DITEM_CONTINUE flag set.

Also make the semantics of DITEM_RESTORE quite a bit different - rather
than restore the screen back to pre-menu state, we restore the menu
itself.  This is more correct for a variety of reasons when dealing with
nested menus (whoops!).
1996-04-18 13:21:26 +00:00
Jordan K. Hubbard
6562be49a5 More changes to attempt to make this whole new dialog scheme more
robust.  The new "fire" actions, while affording signficantly more
interactivity to libdialog, come at a cost - if the fire action trashes
the screen then you're not going to be in Kansas anymore when you
come back to the menu and there had better be considerable extra
smarts in place for coping with such a situation.  These changes are my
attempt to do just that.
1996-04-16 12:17:27 +00:00
Jordan K. Hubbard
056985cc17 Remove some of the grot I added to try and save/restore screen contents.
This shouldn't be done here, it should be done in the client as needed.
1996-04-13 13:13:32 +00:00
Jordan K. Hubbard
de16e2a457 Save screen before calling any fire() callbacks - you never know what
they might do to the screen.
1996-04-08 10:28:07 +00:00
Jordan K. Hubbard
3d681421e0 Refresh dialogs if a callback action fails. 1996-04-08 10:02:55 +00:00
Jordan K. Hubbard
f6284247b7 Make this properly respect obj dirs. 1996-04-07 03:34:35 +00:00
Jordan K. Hubbard
371a943ab5 Strive for a little more consistency with my examples. 1996-04-07 03:21:01 +00:00