Commit Graph

301 Commits

Author SHA1 Message Date
David E. O'Brien
e0908a9f34 Use lstat(2) rather than stat(2) in isdir(), so that a symlink to a
directory is not considered a directory.  I have a feeling all the other
stat(2) calls should instead be lstat(2) calls, but I have not suffiently
determined that the current behavior [especially in isfile()] isn't
depended upon by someone.

Ok'ed by:	JKH
2000-02-08 06:36:08 +00:00
Chris Costello
6f30e43c0e Grammar fix: `Different than'' should be `different from''. 2000-01-29 22:20:19 +00:00
Dan Moschuk
61de98348a Fix a bug in previous commit where pkg_{delete,info} foo-1.0/ would segfault.
Noticed first by: kris
2000-01-18 01:45:54 +00:00
Dan Moschuk
06647a4f76 Teach pkg_delete and pkg_info how to deal with full pathnames
(/var/db/pkg/foo-1.0, instead of just foo-1.0).

Submitted by: Matthew D. Fuller <fullermd@futuresouth.com>
2000-01-15 01:15:37 +00:00
Sheldon Hearn
3c47fb7922 Fix bogon in previous commit: pass a string argument to printf(3) to
satisfy the %s conversion format specifier.

Reported by:		Mark Huizer <freebsd@xaa.iae.nl>
2000-01-11 13:40:20 +00:00
Sheldon Hearn
b8d1e942b5 Use a more helpful fatal error message than "Toto! This doesn't look
like Kansas anymore!" when unable to return to the original working
directory.

PR:		bin/16015
2000-01-11 12:37:16 +00:00
Alexey Zelkin
f4c2a87d41 Include -f and -t options to SYNOPSYS section (manpage) and usage information
(main.c)

PR:		bin/5410
Submitted by:	Frank Volf <volf@oasis.IAEhv.nl>
2000-01-07 13:25:53 +00:00
Jordan K. Hubbard
481dc61302 Deal with package filenames which contain spaces.
Submitted by:	Ming-I Hsieh <mihs@wm28.csie.ncu.edu.tw>
PR:		15667
2000-01-04 05:08:58 +00:00
Satoshi Asami
a9758dac1a Redirect stdout from mtree to /dev/null; we don't really need to know
the list of directories being created when we install a package.
2000-01-03 22:59:27 +00:00
Jordan K. Hubbard
430122ed41 Only pkg_delete the old package if the new one builds properly.
Submitted by:	Dan "The Bug" Bugg <bugg@bugg.strangled.net>
1999-12-06 03:19:16 +00:00
Bill Fumerola
47f97505ad Add '-l' which will match a certain status code.
Add the submitter as a contributor in the man page
freebsd -> FreeBSD, while I'm poking around.

PR:		bin/15162
Submitted by:	Dominic Mitchell <dom@palmerharvey.co.uk>
1999-12-03 06:08:11 +00:00
Bill Fumerola
a30945450e Correct co-MAINTAINER's e-mail address. I don't know how many
more ways I can screw his address up. Suggestions welcome.
1999-12-03 03:20:59 +00:00
Bill Fumerola
bc019cca2f Install man pages in the right place. This is what I get for cheating
and copying a Makefile from another directory over to this one.

PR:		docs/15140
Submitted by:	Kazuo Horikawa <horikawa@jp.FreeBSD.org>
1999-11-28 18:34:27 +00:00
Bill Fumerola
80d667c495 Add the author as co-maintainer, a la mergemaster. 1999-11-26 20:35:55 +00:00
Bill Fumerola
33b668b529 Welcome pkg_version into the FreeBSD source tree.
pkg_version (as you may well know) matches the existing packages/ports
installed on your system with the ports INDEX and reports which
ports differ from the current INDEX.

Submitted by:	Bruce A. Mah <CA.Sandia.GOV>
Reviewed by:	ports
1999-11-26 20:31:58 +00:00
Chris Piazza
79e970edde Make pkg_add -r package1 package2 package3 ... work correctly.
Reviewed by:	billf
1999-11-18 23:32:43 +00:00
Bill Fumerola
db86a11e69 o Remove all of the objformat logic, it's never coming back.
o Simplify getpackagesite(), it comes back in full glory when we branch
again. It's still needed however to get the i386 or alpha directory.
1999-09-25 03:02:08 +00:00
Masafumi Max NAKANE
ce30a19b7c Document the fact that pkg_add/delete passes INSTALL/DEINSTALL
respectively to rscript.
1999-09-11 03:52:24 +00:00
Jordan K. Hubbard
c32155b9e3 Use the appropriate macro for double quotes rather than using double
quotes.

Submitted by:	Alexey Zelkin <phantom@cris.net>
PR:		13436
1999-09-01 10:04:47 +00:00
Peter Wemm
3085e97a0b Remove some $Log$ debris 1999-08-29 15:54:49 +00:00
Peter Wemm
a1a4f1a0d8 $Header$ -> $FreeBSD$ 1999-08-28 05:11:36 +00:00
Peter Wemm
97d92980a9 $Id$ -> $FreeBSD$ 1999-08-28 01:35:59 +00:00
Mike Pritchard
32fdc70513 Various man page cleanup:
- Sort xrefs.
- FreeBSD.ORG -> FreeBSD.org
- Be consistent with section names as outlined in mdoc(7).
- Other misc mdoc cleanup.

PR:		doc/13144
Submitted by:	Alexey M. Zelkin <phantom@cris.net>
1999-08-15 08:47:11 +00:00
Bill Fumerola
0845a96cd0 -Wall fixes. Ambigious if/elses, uninitialized values, missing headers,
missing prototypes, and empty format strings.
1999-08-11 20:55:42 +00:00
John Polstra
8d14a4acbe When listing the installed packages, do it in alphabetical order. 1999-07-30 23:14:15 +00:00
Nik Clayton
414a35e60a Add $Id$, to make it simpler for members of the translation teams to
track.

The Id line is normally at the bottom of the main comment block in the
man page, separated from the rest of the manpage by an empty comment,
like so;

     .\"    $Id$
     .\"

If the immediately preceding comment is a @(#) format ID marker than the
the $Id$ will line up underneath it with no intervening blank lines.
Otherwise, an additional blank line is inserted.

Approved by:            bde
1999-07-12 20:12:29 +00:00
Warner Losh
02db1769f3 '?' shouldn't be in the usage string. Unknown characters are already
converted to '?'.
1999-06-24 06:33:24 +00:00
Bill Fumerola
69f8389253 If we are going to have a case for '?' then we should define it in Options.
Submitted by:	Ben Olson <bseth@chc-chimes.com>
1999-06-23 16:54:38 +00:00
David E. O'Brien
ba83352b78 Support Alpha and -CURRENT in the "-r" option case. 1999-06-14 21:58:59 +00:00
Jordan K. Hubbard
177bf8278c where_arge is allocated on stack and return address is overwritten
by buffer overflow.

Submitted by:	Hidetoshi Shimokawa <simokawa@sat.t.u-tokyo.ac.jp>
1999-06-09 09:29:53 +00:00
Jordan K. Hubbard
722678f1c8 Revive the PKG_ADD_BASE stuff a bit. 1999-05-12 06:06:49 +00:00
Jordan K. Hubbard
c89686d6b7 If pkg_info is run with no args, default to "-aI". 1999-04-27 02:30:27 +00:00
Alexander Langer
43d1df332e Removed occurrences of consecutive repeated words (such as "the the"). 1999-02-12 02:12:08 +00:00
Bill Fumerola
2d073cdff2 Fix nasty bug where getpackagesite() will return an integer if it doesn't
know what revision of FreeBSD is being run. This case should never happen,
but just in case.
1999-01-28 20:17:32 +00:00
Bill Fumerola
ad22d0720b Numbering typo, missed a '0'
Submitted by:	Brian Feldman
1999-01-26 22:31:23 +00:00
Bill Fumerola
c6a6c9c017 Update pkg_add's remote package feature to reflect the new structure of
wcarchive. This needs to be updated when:

(a) The directory structure changes on wcarchive
(b) getosreldate() has a new significance
	(ie. get ELF packages/get a.out packages)
(c) Branches are changed around

As we stand right now, 3.0-postELFday and 4.0-x all point to the same
directory, but when 4.0 starts to have its own packages, this file will
need to be changed.
1999-01-25 21:08:13 +00:00
Bill Fumerola
99ebed6b50 Style police, inline ifs.
Submitted by:	 Brian Feldman <green@unixhelp.org>
1999-01-18 03:54:17 +00:00
Justin M. Seger
1048df4463 enviornment -> environment
PR:		docs/9534
Submitted by:	rv@fore.com
1999-01-17 15:08:09 +00:00
Bill Fumerola
ab13b06dc0 Add a new option for pkg_add, -r.
The remote option allows for automatic package fetching and installation
using the package repository found on wcarchive. Naturally, this site
can be overridden with a enviornment variable.

This code uses getobjformat() and getosreldate(). This means when some event
causes the package to be fetched to change (such as e-day) the logic also
needs to be changed.

Sorta reviewed by:	jkh
Code suggestions:	peter, jkh, eivind, msmith
1999-01-17 01:22:55 +00:00
David E. O'Brien
729ac65e7c document PKG_DBDIR
Add ENVIRONMENT and FILES sections.
1998-12-31 20:29:29 +00:00
David E. O'Brien
ce4273bfe4 change wording slightly to match other pkg_*.1 1998-12-31 20:28:55 +00:00
Jordan K. Hubbard
0440e20b71 Make it possible to have separate install scripts as well as have
an on-delete script.

Submitted by:	Rajesh Vaidheeswarran <rv@fore.com>
1998-12-16 13:59:31 +00:00
Satoshi Asami
cf144a3d4a Fix support for uncompressed (".tar") package types. It's not completely
fixed (chained dependency checking for pkg_add is broken, for one thing)
but at least you can now create one package and use it.
1998-12-05 06:29:03 +00:00
Jordan K. Hubbard
1b771b9577 Fix bug where trailing slash could confuse the registry removal.
Noticed by:	des
1998-11-11 06:09:04 +00:00
Jordan K. Hubbard
400d793dd7 Unlink old contents of package when extracting new.
Submitted by:	pst
1998-10-28 22:44:24 +00:00
Jordan K. Hubbard
27f612d03f Revert 1.33; lstat() is indeed the wrong thing to do here. I'll
revisit this after release.
1998-10-14 18:52:04 +00:00
Jordan K. Hubbard
ac5c5f1320 Correct a misleading comment. 1998-10-12 20:01:48 +00:00
Jordan K. Hubbard
d0a638ae52 Use lstat() rather than stat in determining whether a file exists,
otherwise we'll miss the "symlink exists but points nowhere" case.
Submitted by:	asami and/or possibly <ru@ucb.crimea.ua>
1998-10-09 00:01:16 +00:00
Jordan K. Hubbard
355150a489 Use a more reasonable default umask in case the root umask is too
fascist.
PR:		4014
1998-09-14 19:22:59 +00:00
Jordan K. Hubbard
375ca45770 correct usage of cleanup() everywhere - this became bogus when the warnx/errx
stuff was added and nobody seems to have noticed. :)
Noticed by:	Josh MacDonald <jmacd@paris.CS.Berkeley.EDU>
1998-09-11 07:26:58 +00:00
Jordan K. Hubbard
8c26c30381 o Set paths internally for pkg_add for tools we might want to invoke.
o Fix bogus suffix handling.
o Tell user when an FTP url is being xferred rather than being silent.
  This sort of violates "the unix way" but it stops people from whacking
  ^C when they think it's hung, too.  Sometimes visual indication of
  success is important.  Doesn't spit out anything if not on a TTY.
1998-09-08 10:42:26 +00:00
Jordan K. Hubbard
4a641d8eeb Fix bogus suffix stripping to be less naive.
PR:		3418
Noted by:	pst
1998-09-08 03:15:41 +00:00
Jordan K. Hubbard
62203a9ce5 Fail as documented when a dependency cannot be found
PR:		7318
Submitted by:	djv@bedford.net
1998-09-08 03:02:45 +00:00
Jordan K. Hubbard
45878e4d34 Silence potentially bogus warning. 1998-09-01 06:58:11 +00:00
Jordan K. Hubbard
47d8228368 Fix recursive package add problem (for on-disk package files) I introduced
with the change in semantics to make_playpen().  Now package dependencies
more than 2 levels deep should work again.  Pass the hat.
1998-08-27 14:59:55 +00:00
Jordan K. Hubbard
77b7b41b81 Don't exit() from cleanup() if we got there via a non-signal since
we're only going to exit (after printing a more detailed error message)
afterwards anyway.
PR:		7020
1998-07-28 11:55:39 +00:00
Jacques Vidrine
dd123c1609 Paranoia: use mkdtemp instead of mktemp
PR:		bin/3212
Reviewed by:	jkh@FreeBSD.ORG
1998-07-28 01:18:02 +00:00
Tim Vanderhoek
922fcd0032 Clarify "Cannot delete file as directory" errmessage.
PR:		bin/1985
1998-07-18 22:19:11 +00:00
Eivind Eklund
4dc6689c09 Avoid race-conditions on playpen delete. 1998-07-17 14:56:31 +00:00
Joseph Koshy
fa0bc432ca Add $Id$.
PR:		7251
Submitted by:   Norihiro Kumagai <kuma@jp.freebsd.org>
1998-07-14 08:28:15 +00:00
Joseph Koshy
ec500c67a1 Document -I' and -R' options to `pkg_info'.
PR: 7155
1998-07-06 04:39:20 +00:00
Jordan K. Hubbard
3dc0dc887a MF22: check for null pointer. 1998-07-04 14:13:01 +00:00
Joseph Koshy
f618e998de Document environment variables used by pkg_{add,create,info}. These
include PKG_TMPDIR, TMPDIR, PKG_DBDIR.  Add a FILES section to these
manual pages.

PR: docs/7064
1998-06-26 07:15:38 +00:00
Steve Price
b7350d720d Loosely document the '-s' commandline option.
PR:		6713
1998-05-24 03:11:17 +00:00
Jordan K. Hubbard
90b14d4761 Fix dependent-package loading when pkg_adding with an FTP URL. I broke
this when I changed the playpen code to disallow recursion.  I know
this fixes a PR someplace but I can't seem to find it with the GNATs
search tool.
1998-04-12 16:01:10 +00:00
Philippe Charnier
f12a14713b .Sh AUTHOR -> .Sh AUTHORS. Use .An/.Aq. 1998-03-23 08:31:20 +00:00
Bruce Evans
6dd8984675 Use foo/bar.a' instead of -Lfoo -lbar' for linking to static internal
libraries, so that `ld -f' in can create correct dependencies for
yet-to-be-built libraries.
1998-03-07 08:55:00 +00:00
Jordan K. Hubbard
79af7eafa8 Eliminate the idea of nested "playpens" entirely - it just obfuscated
the code and, in at least one case, made it more dangerous to no gain.
1998-02-16 17:16:51 +00:00
Jordan K. Hubbard
8b1643d2c6 I must have been smoking crack when I made this change. Using sh -c
in a vsystem() call is just a ludicrous way of calling sh -c "sh -c ..."
Whoops!  I don't know my own bloody code here!
1998-01-21 06:08:35 +00:00
Warner Losh
07d19529ee Quote filenames more agressively.
Reviewed by:	jkh
Submitted by:	Hubert Feyrer
1998-01-21 00:12:56 +00:00
Jordan K. Hubbard
73dfa4e8d6 MF22: fix to install script handling. 1998-01-17 12:26:19 +00:00
Jordan K. Hubbard
cac1743203 MF22: Additional paranoia in cleanup. 1998-01-09 14:52:18 +00:00
Jordan K. Hubbard
07eb524cb0 Don't assume install script is directly runnable - use sh -c. 1998-01-08 11:27:06 +00:00
Tim Vanderhoek
a86f3c5dee "This is the add^H^H^Hinfo module."
Pedantic comment fix.

PR:		bin/5188
Submitted by:	Alex [3]garbanzo@hooked.net
1997-12-26 05:29:29 +00:00
Jordan K. Hubbard
2a23bb4e4c MF22: Revert part of -p handling. 1997-11-14 01:56:04 +00:00
Jordan K. Hubbard
c6a72fc9d7 The prefix override code was bogus. The original idea was sound
enough, but we're not using the pkg_create tool that way anymore
in the ports collection.

PR:		4894
Submitted by:	Adrian Colley <aecolley@ois.ie>
1997-11-13 11:49:23 +00:00
Masafumi Max NAKANE
cb48519127 Pkg_add refused to process package whose packing list contains @exec/@unexec
before any file names.  This change makes pkg_add to process those
packages if @exec/@unexec commands don't contain any %[fFB].  Also
enable @exec/@unexec that have %D if the installation prefix is known to
pkg_add.
Reviewed by:	jkh
1997-10-24 08:32:06 +00:00
Jordan K. Hubbard
940d89a9d5 - do string-magic on the right variable when trying
to find dependent packages on the local disk (i.e. package given as
   filename, not URL)
 - document $PKG_PATH
 - use -v on pkg_add for dependent packages

Submitted by:	hubertf@NetBSD.ORG
Obtained from:	NetBSD
1997-10-18 05:54:17 +00:00
Jordan K. Hubbard
47af563ed0 Deal with PLIST_UNEXEC properly.
PR:		4784
Submitted by:	Stefan `Sec` Zehl <sec@quit.42.org>
1997-10-18 05:42:05 +00:00
Jordan K. Hubbard
570f313ee4 Don't return from cleanup() - if it's removed the playpen then very
bad things will happen if we return to unsuspecting code.
Noted to my great dismay by:	Tim Vanderhoek <hoek@hwcn.org>
1997-10-13 15:03:55 +00:00
Philippe Charnier
6fed414929 Use err(3). Cosmetics in usage string and man page. 1997-10-08 07:48:21 +00:00
Tim Vanderhoek
a04aa72155 Document pkg_add's dependency auto-install. While I'm here, fix
a couple typos, and consistent double-spacing after sentences.

This is actually a spinoff from the "ports-current discontinued"
blow-up some time ago.

Ack'd by: jkh
1997-09-27 13:41:35 +00:00
Poul-Henning Kamp
d030d2d2ae Many places in the code NULL is used in integer context, where
plain 0 should be used.  This happens to work because we #define
NULL to 0, but is stylistically wrong and can cause problems
for people trying to port bits of code to other environments.

PR:		2752
Submitted by:	Arne Henrik Juul <arnej@imf.unit.no>
1997-09-18 14:08:40 +00:00
Masafumi Max NAKANE
a1138a1695 Typo. 1997-09-13 17:55:43 +00:00
Jordan K. Hubbard
b4104ffa6b Eliminate an annoying message. 1997-09-02 08:48:47 +00:00
Jordan K. Hubbard
643e8222c7 Add proper md5 comments to ports-installed packages also by
masticating it through the same routine used by pkg_create.
Submitted by:	se
1997-07-04 04:48:02 +00:00
Jordan K. Hubbard
55f4e300b4 Change the naming conventions for preserve'd files and also document
the option in pkg_create.  Now preserved files start with a . and are
named .<filename>.<pkgname>.backup so that their purpose is more clear.

Note that just using the preserve option without proper pkg_deps
is also foolish since packages being deleted in the incorrect order with
preserve on can generate some odd results.
1997-07-01 06:13:51 +00:00
Jordan K. Hubbard
8805157f39 YAMF22 - deletes and preserve option fixes. 1997-06-30 03:15:40 +00:00
Jordan K. Hubbard
6373a10b41 Whoops, only attempt to back up the file if it exists. :-} 1997-06-30 02:57:40 +00:00
Jordan K. Hubbard
94d1d55871 Add support for @option preserve - moves existing files out of the way
before replacing them (using pkgname to make this hopefully unique).
Delete also moves them back, if they exist, resulting in a package
which can be "backed out" with reasonable safety.
1997-06-29 10:41:49 +00:00
Jordan K. Hubbard
9a73af57e4 Fix multiple documentation bogons.
PR:		3798
Submitted by:	Jan Kuriyama <kuriyama@opt.phys.waseda.ac.jp>
1997-06-19 15:18:34 +00:00
Jordan K. Hubbard
159225d08b Add support for srcdir overrides. 1997-06-06 12:19:11 +00:00
Andrey A. Chernov
31adf0ad42 When no last file specified for % command user barf(error diagnostic)
instead of segmentation fault
1997-05-24 21:45:55 +00:00
Masafumi Max NAKANE
a1c9d782b7 Minor typo.
PR:		3473
Submitted by:	Josh Gilliam <soil@quick.net>
1997-05-02 22:00:05 +00:00
Warner Losh
6c3f552a31 compare return value from getopt against -1 rather than EOF, per the final
posix standard on the topic.
1997-03-31 05:11:47 +00:00
Jordan K. Hubbard
8375be7ed6 Protect against missing initial @cwd. Closes PR#2893
Submitted-By: pius@iago.ienet.com
1997-03-06 10:21:57 +00:00
Jordan K. Hubbard
b421849f2f Close PR#2459 1997-02-25 07:22:23 +00:00
Peter Wemm
476602a9d0 Revert $FreeBSD$ to $Id$ 1997-02-22 16:15:28 +00:00
Jordan K. Hubbard
6e0a4251e7 Prevent potential argument buffer overflow. 1997-02-15 16:34:47 +00:00
Jordan K. Hubbard
2df00d4c64 Fix a bogon with playpen size calculation for pkg of "-". It's amazing
this ever worked, actually.
1997-02-15 14:17:28 +00:00