Poul-Henning Kamp
87ac8d11c2
Fix two old/new consumer confusions.
...
Submitted by: Pawel Jakub Dawidek <nick@garage.freebsd.pl>
2003-10-24 18:46:23 +00:00
Poul-Henning Kamp
d55b513f6e
Fix a braino memory leak.
...
Found by: Pawel Jakub Dawidek <nick@garage.freebsd.pl>
2003-10-22 20:28:46 +00:00
Poul-Henning Kamp
43bff1a7ab
Forgotten commit: If a provider has zero sectorsize, it is an
...
indication of lack of media.
Tripped up: peter
2003-10-22 06:32:20 +00:00
Poul-Henning Kamp
d1b8bf476c
Remove KASSERT check for negative bio_offsets, add "normal" EIO
...
error return for same.
2003-10-19 19:06:54 +00:00
Poul-Henning Kamp
3916828f7b
Retire bio_blkno entirely.
...
bio_offset is the field drivers should use.
bio_pblkno remains as a convenient place to store the number of
the device drivers.
2003-10-18 17:53:34 +00:00
Poul-Henning Kamp
e83d1f3b9c
Assume that bp->bio_offset is correctly initialized.
...
This fixes non-power-of-2 blocksize GEOM I/O.
2003-10-12 11:35:55 +00:00
Poul-Henning Kamp
b144e6ffeb
Destroy providers maked with G_PF_WITHER when the last consumer has detached.
2003-10-12 11:34:35 +00:00
Poul-Henning Kamp
f4db0cbe58
Interior decoration changes.
2003-10-07 09:28:07 +00:00
Poul-Henning Kamp
f7eeab176c
Allow our bio tools to be used for local bio-chopping by not mandating
...
a bio_from value. bio_to is still mandated (mostly for debuggign) and
shall be copied from the parent bio.
2003-10-06 09:07:35 +00:00
Poul-Henning Kamp
90916ef730
Introduce a per provider wither flag
2003-10-06 09:05:44 +00:00
Poul-Henning Kamp
5774cead7a
Return ENODEV in case the driver has no dump routine.
2003-09-29 07:44:23 +00:00
Poul-Henning Kamp
70cd771337
The present defaults for the open and close for device drivers which
...
provide no methods does not make any sense, and is not used by any
driver.
It is a pretty hard to come up with even a theoretical concept of
a device driver which would always fail open and close with ENODEV.
Change the defaults to be nullopen() and nullclose() which simply
does nothing.
Remove explicit initializations to these from the drivers which
already used them.
2003-09-27 12:01:01 +00:00
Poul-Henning Kamp
3eb6ffdf43
Add more KASSERTS().
2003-09-26 20:52:46 +00:00
Poul-Henning Kamp
eb98005f8d
Be more careful in dumpconf: softc may be NULL for departing devices.
...
Allow drivers to initialize the d_devstat if they want magic params.
2003-09-23 07:53:59 +00:00
Poul-Henning Kamp
e060b6bd03
Reorder a couple of KASSERTS to give more sensible messages.
...
Found by: GEOM 101 class of '03
2003-09-11 00:49:02 +00:00
Poul-Henning Kamp
d5ce9dac89
Correct bzero length so we clear the entire key structure.
2003-09-08 18:35:26 +00:00
Poul-Henning Kamp
a8c1568e29
Bzero the right number of bytes.
...
Found by: Juergen Buchmueller <pullmoll@stop1984.com>
2003-09-06 18:37:17 +00:00
Poul-Henning Kamp
f03bec944d
Make sure to return ENOIOCTL if the ioctl is not handled.
2003-09-04 21:23:46 +00:00
Poul-Henning Kamp
497c334767
Simplify the ioctl handling in GEOM.
...
This replaces the current ioctl processing with a direct call path
from geom_dev() where the ioctl arrives (from SPECFS) to any directly
connected GEOM class.
The inverse of the above is no longer supported. This is the
situation were you have one or more intervening GEOM classes, for
instance a BSDlabel on top of a MBR or PC98. If you want to issue
MBR or PC98 specific ioctls, you will need to issue them on a MBR
or PC98 providers.
This paves the way for inviting CD's, FD's and other special cases
inside GEOM.
2003-09-01 20:45:32 +00:00
Poul-Henning Kamp
ce1ee7895e
Try to close the race between disk_destroy() and a subsequent disk_create().
2003-09-01 12:03:13 +00:00
Poul-Henning Kamp
bff1e2999d
Add the new g_dev_getprovider() function, the swap_pager needs it now.
...
Spotted by: mr
2003-08-30 18:33:55 +00:00
Paul Saab
e65b213768
Change the the size fields to daddr_t to support greater than 2TB ccd volumes.
...
Reviewed by: phk
2003-08-22 11:21:06 +00:00
Poul-Henning Kamp
f63679713e
Make CCD unloadable.
2003-08-22 11:04:47 +00:00
Poul-Henning Kamp
1f75de94ea
Don't panic over the fact that unloading failed if we already knew that.
2003-08-22 11:00:54 +00:00
Poul-Henning Kamp
e30b2eda02
Block all GETATTR calls hitting the CCD, we wouldn't know which child
...
device should handle them.
This prevents for instance GEOM::ioctl requests from reaching a
lower BSDlabel node, which ps@ found would confuse newfs(8).
2003-08-22 10:28:19 +00:00
Poul-Henning Kamp
92b5e86ebf
Check for null softc pointers, these happens when a ccd is withering.
...
Found by: David Schultz <dschultz@OCF.Berkeley.EDU>
2003-08-22 10:22:46 +00:00
Poul-Henning Kamp
4ba5a129c5
Replace a panic with a .1Hz retry loop.
...
Not a perfect solution, but far cheaper than one.
2003-08-13 12:35:25 +00:00
Poul-Henning Kamp
f0ffd81bc2
In case we encounter a zero sectorsize provider in g_io_check(), fail
...
the request with a printf rather than a divide by zero error.
2003-08-13 06:42:56 +00:00
Poul-Henning Kamp
a35006e814
Kick Giant compatibility one layer up.
2003-08-02 10:11:58 +00:00
Poul-Henning Kamp
114ebb2f28
Fix a memory leak in CCD's mirror code.
2003-07-29 20:04:06 +00:00
Poul-Henning Kamp
3f5187f276
Implement DOSPTYP_EXTLBA more completely: loop until we find no more
...
partitions.
Submitted by: Rudolf Cejka <cejkar@fit.vutbr.cz>
PR: 53719
2003-07-29 10:09:13 +00:00
Poul-Henning Kamp
d32622aaee
Handle geoms which are withering away specially in the dump functions.
2003-07-08 21:12:40 +00:00
Poul-Henning Kamp
fd02a4233e
Only dump 512 bytes of debugging.
...
Always wait for things to settle before returning.
2003-07-02 08:07:07 +00:00
Poul-Henning Kamp
44be139bbb
Sleep on "-" in our normal state to simplify debugging.
2003-06-18 10:33:09 +00:00
Poul-Henning Kamp
22db1e9ff5
Add "GEOM_FOX", a class which detects and selects between multiple
...
redundant paths to the same device.
This class reacts to a label in the first sector of the device,
which is created the following way:
# "0123456789abcdef012345..."
# "<----magic-----><-id-...>
echo "GEOM::FOX someid" | dd of=/dev/da0 conv=sync
NB: Since the fact that multiple disk devices are in fact the same
device is not known to GEOM, the geom taste/spoil process cannot
fully catch all corner cases and this module can therefore be
confused if you do the right wrong things.
NB: The disk level drivers need to do the right thing for this to
be useful, and that is not by definition currently the case.
2003-06-18 09:29:28 +00:00
David E. O'Brien
50b1faef38
Use __FBSDID().
...
Approved by: phk
2003-06-11 06:49:16 +00:00
Poul-Henning Kamp
ec421aec25
Fix error handling for ENOMEM style issues.
2003-06-09 19:12:19 +00:00
Poul-Henning Kamp
84c080a85e
Improve the root-dev prompt facility for printing devices which could
...
possibly be a root filesystem.
2003-06-07 15:46:53 +00:00
Poul-Henning Kamp
ac2ba9e3d5
Wait for everything to settle before we try to print the list of
...
geom devices.
2003-06-07 15:32:09 +00:00
Poul-Henning Kamp
b61e8fed30
Make sure we return an error message if the geom parameter is not
...
located.
2003-06-07 15:31:44 +00:00
Poul-Henning Kamp
c44c213f24
Polishing and nitpicking.
2003-06-07 11:06:44 +00:00
Poul-Henning Kamp
df2c3922e9
Drop a memory-corruption debugging test-tool.
2003-06-07 10:55:48 +00:00
Poul-Henning Kamp
a1a9b44569
Add missing va_end() calls.
...
Noticed by: tmm
2003-06-07 10:16:53 +00:00
Poul-Henning Kamp
d6c5e71627
Introduce g_provider_by_name() function, and use it.
2003-06-04 18:17:52 +00:00
Poul-Henning Kamp
3a3fcd72dd
Make this a true GEOM class:
...
Attach to the component devices using GEOM semantics.
Create a GEOM provider instead of using disk_create()
Use the GEOM OAM api for configuration.
I saw approx ~1% speedup in througput and ~7% in latency in a
simple minded test of a two-disk striped device.
This file was repo-copied from src/sys/dev/ccd/ccd.c.
This is not yet linked into the build.
2003-06-04 18:16:09 +00:00
Poul-Henning Kamp
ce64e0f2c9
Add a KASSERT to prevent the same GEOM class from being processed loaded
...
twice.
Enforce that classes should have different names while we are here.
2003-06-04 17:51:10 +00:00
Poul-Henning Kamp
0f557e0ac0
Further devilification of CCD:
...
Change the list interface to simplify things.
Remove old list ioctls which bogusly exported the softc to userland.
Move the softc and associated structures from the public header to
the source file.
2003-06-02 21:29:04 +00:00
Poul-Henning Kamp
189337d81f
Begin deevilification of CCD:
...
Make CCD a GEOM class.
For now only use this for implementing a OAM config method which
can return a list of configured CCD devices in the format which
"ccdconfig -g[v]" would normally output.
2003-06-02 20:50:03 +00:00
Poul-Henning Kamp
786a6905ec
Return an indicative error message.
2003-06-02 20:35:37 +00:00
Poul-Henning Kamp
83d771de78
Simplify the GEOM OAM api: Drop the request type, and let everything
...
hinge on the "verb" parameter which the class gets to interpret as
it sees fit.
Move the entire request into the kernel and move changed parameters
back when done.
2003-06-01 13:47:51 +00:00
Poul-Henning Kamp
a6c58fec6c
constify g_sanity()
2003-06-01 13:30:39 +00:00
Poul-Henning Kamp
58223589d5
Use bcmp() to compare hash strings.
2003-06-01 09:18:49 +00:00
Poul-Henning Kamp
b77052e617
Remove unused variable.
...
Remove unneeded return;
Found by: FlexeLint
2003-05-31 19:41:33 +00:00
Poul-Henning Kamp
3bae8877f4
Remove unused variables.
...
Found by: FlexeLint
2003-05-31 19:40:43 +00:00
Poul-Henning Kamp
7fd69a8064
Remove unused variables.
...
Rename struct h0h0 to g_hh01 in order to make it unique over files.
Found by: FlexeLint
2003-05-31 19:37:21 +00:00
Poul-Henning Kamp
c543626797
Remove unused variables.
...
Remove #ifdef notyet which will never become.
Found by: FlexeLint
2003-05-31 19:30:52 +00:00
Poul-Henning Kamp
23bfa598a8
Remove unused variable.
...
Remove unneeded return.
Found by: FlexeLint
2003-05-31 19:29:38 +00:00
Poul-Henning Kamp
68283a9b5a
Remove unused variable.
...
Found by: FlexeLint
2003-05-31 19:28:53 +00:00
Poul-Henning Kamp
ce67c955ca
Add a destroy_geom method to the slice "library".
...
If a slice class has no destroy_geom method, use this one.
This should allow all slicers to kldload.
2003-05-31 19:25:05 +00:00
Poul-Henning Kamp
fc29c9de5c
Don't use & in front of arrays.
...
Found by: FlexeLint
2003-05-31 19:23:11 +00:00
Poul-Henning Kamp
a980e07369
Remove unused variable.
...
Found by: FlexeLint
2003-05-31 19:08:23 +00:00
Poul-Henning Kamp
d6b602d4b2
Remove unused variable.
...
Found by: FlexeLint
2003-05-31 18:55:18 +00:00
Poul-Henning Kamp
6c87f8d5ea
Introduce a init and fini member functions on a class.
...
Use ->init() and ->fini() to handle the mutex in geom_disk.c
Remove the g_add_class() function and replace it with a standardized
g_modevent() function.
This adds the basic infrastructure for loading/unloading GEOM classes
2003-05-31 18:13:07 +00:00
Poul-Henning Kamp
f075585f67
Remove the G_CLASS_INITIALIZER, we do not need it anymore.
2003-05-31 16:59:27 +00:00
Poul-Henning Kamp
7e28a78f0e
Use le_uuid_dec() since GPT UUID's are always in LE format.
...
Tested by: Marcel
2003-05-31 16:48:43 +00:00
Poul-Henning Kamp
43f0db6cc5
Don't do silly thing if the disk_create() event gets canceled.
...
Approved by: re/scottl
2003-05-25 16:57:10 +00:00
Poul-Henning Kamp
67fd2837cd
Return ENXIO if the softc pointer is NULL, in all likelyhood the
...
disk is in the process of disappearing.
Approved by: re/rwats*
2003-05-21 18:52:29 +00:00
Poul-Henning Kamp
3eb8c738fd
When a disk disappears, destroy the class from the event thread
...
to avoid race condtion.
Approved by: re/rwatson
2003-05-12 20:15:28 +00:00
Poul-Henning Kamp
4da6e74ce4
When a GEOM (/dev-)device is closed and we find that I/O requests are
...
still outstanding, give them a chance to complete.
If after 10 seconds we still find outstanding I/O requests, complete
the close with a console warning that the system is likely to panic
later on.
This is a workaround for umount -f not quite doing the right thing.
Approved by: re/scottl
2003-05-09 21:25:28 +00:00
Poul-Henning Kamp
2cc9686e52
Hide the "ENOMEM" notice messages behind bootverbose. They are still
...
a valuable debugging tool for certain kinds of problems.
Approved by: re/scottl
2003-05-07 05:37:31 +00:00
Poul-Henning Kamp
c9e629297a
Fix the WARNING for wrong rawoffset, I tested incompatible units.
...
Approved by: re/jhb
2003-05-06 19:36:13 +00:00
Poul-Henning Kamp
af3e2db5de
Avoid double-free panic.
...
Tripped up: DougB
2003-05-05 15:52:11 +00:00
Poul-Henning Kamp
c0c393a2aa
Re-order the the initialization slightly to improve structure.
2003-05-05 08:58:12 +00:00
Poul-Henning Kamp
0195276f54
Use a dedicated malloc(9) bucket for sector storage.
2003-05-05 08:37:07 +00:00
Poul-Henning Kamp
3fd530f7ec
Don't warn if the rawoffset is zero, that is actually the best value it
...
could have.
2003-05-05 08:30:59 +00:00
Poul-Henning Kamp
b9275c8fc6
Turn the check that rawoffset == mbroffset into a warning instead.
2003-05-05 06:46:49 +00:00
Poul-Henning Kamp
b624374de8
Only accept a rawoffset if it is identical to the mbroffset.
2003-05-04 19:26:31 +00:00
Poul-Henning Kamp
7f9e81b703
Add a way to read the current mbroffset from a BSD label class.
2003-05-04 19:25:48 +00:00
Poul-Henning Kamp
1ee055e692
Add gctl_set_param() function.
2003-05-04 19:24:34 +00:00
Poul-Henning Kamp
ce40bcd0d1
Remove debugging printfs which should not have been committed.
2003-05-04 18:48:25 +00:00
Poul-Henning Kamp
a767c3daa3
Add a OAM interface for changing the label and writing the boot code.
2003-05-03 08:01:34 +00:00
Poul-Henning Kamp
951fd0d157
remove unused variables.
...
Spotted by: dougb
2003-05-03 07:12:15 +00:00
Poul-Henning Kamp
56dde750d5
Make bsd_disklabel_le_enc calculate the checksum and fill it in.
...
(If there is a legitimate need to correctly encode and pack a
disklabel with an invalid checksum custom tools can be built for
that.)
Make bsd_disklabel_le_dec() validate the magics, number of partitions
(against a new parameter) and the checksum.
Vastly simplify the logic of the GEOM::BSD class implementation:
Let g_bsd_modify() always take a byte-stream label.
This simplifies all users, except the ioctl's which now have to
convert to a byte-stream first. Their loss.
g_bsd_modify() is called with topology held now, and it returns
with it held.
Always update the md5sum in g_bsd_modify(), otherwise the check
is no use after the first modification of the label. Make the
MD5 over the bytestream version of the label.
Move the rawoffset hack to g_bsd_modify() and remove all the
inram/ondisk conversions.
Don't configure hotspots in g_bsd_modify(), do it in taste instead,
we do not support moving the label to a different location on the
fly anyway.
This passes all current regression tests.
2003-05-02 22:46:13 +00:00
Poul-Henning Kamp
81377a3f17
Pull in bcopy() prototype from <string.h> when compiled in userland.
2003-05-02 19:53:55 +00:00
Poul-Henning Kamp
039b4cba75
Considering that I did cast the arguments to (intmax_t) I must have
...
been sleepy since I used %qd instead of %jd.
2003-05-02 19:08:57 +00:00
Poul-Henning Kamp
3daf7274a1
Style improvement.
2003-05-02 12:57:40 +00:00
Poul-Henning Kamp
3110102a73
Use g_wither_geom() and plug memory leaks.
2003-05-02 12:52:51 +00:00
Poul-Henning Kamp
3e7b7bb1cb
Plug memory leaks.
2003-05-02 12:49:41 +00:00
Poul-Henning Kamp
5ffb2c8bfd
Use an uma-zone for allocation bio requests.
2003-05-02 12:36:12 +00:00
Poul-Henning Kamp
c9c29450f5
Use g_slice_spoiled() instead of g_std_spoiled().
...
Add XXX comment about minor memory leak until I can fix it.
2003-05-02 08:33:26 +00:00
Poul-Henning Kamp
7da144d91c
Use g_slice_spoiled() instead of g_std_spoiled().
2003-05-02 08:21:02 +00:00
Poul-Henning Kamp
a0c89548a3
Use g_slice_spoiled().
...
Free buffer from g_read_data().
2003-05-02 08:13:03 +00:00
Poul-Henning Kamp
c4da4e46b2
Back out all the stuff that didn't belong in the last commit.
2003-05-02 06:42:59 +00:00
Poul-Henning Kamp
e65ab0f83f
Use g_slice_spoiled() rather than g_std_spoiled().
...
Remember to free the buffer we got from g_read_data().
2003-05-02 06:36:14 +00:00
Poul-Henning Kamp
4f806d2428
Use g_slice_spoiled() not g_std_spoiled()
2003-05-02 06:34:51 +00:00
Poul-Henning Kamp
28ce9efcef
Use g_slice_spoiled() rather than g_std_spoiled()
2003-05-02 06:33:59 +00:00
Poul-Henning Kamp
afec8eb8ad
Use g_slice_spoiled() rather than g_std_spoiled().
2003-05-02 06:33:26 +00:00
Poul-Henning Kamp
15649213a6
Use a more tailored spoil routine for slices, and take advantage of
...
g_wither_geom() to do most of the work for us.
2003-05-02 06:29:33 +00:00
Poul-Henning Kamp
3ddef7422c
Style improvement.
2003-05-02 06:22:48 +00:00
Poul-Henning Kamp
03af3a23dd
Use g_wither_geom() for cleanup.
2003-05-02 06:22:32 +00:00