d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
115,328 Commits 72 Branches 135 Tags 3.2 GiB
3db87a68e0
Commit Graph

58 Commits

Author SHA1 Message Date
David Schultz
8318eaae8b s/int/size_t/ as appropriate. 
Noticed by:	bde
 2005-04-17 01:06:37 +00:00
Dag-Erling Smørgrav
a049d7b097 Revert parts of previous commits and use a temporary variable to avoid 
an invalid type pun.
 2005-04-08 11:19:50 +00:00
Jacques Vidrine
5c929a0c96 An array was mistaken for a pointer in the previous commit. 
Noticed by:	tinderbox, stefanf
Pointy hat to:	nectar
 2005-04-07 19:26:35 +00:00
Jacques Vidrine
26f7774a47 Correct type mismatch introduced in last commit. 
Noticed by:	Steve Kargl <sgk@troutmask.apl.washington.edu>
 2005-04-05 18:25:27 +00:00
Jacques Vidrine
5251901c93 DES pointed out that the PAM layer may change the target user name 
during authentication.  Thus we need to call getpwnam *after* the user
has been authenticated.  Colin mentioned that we should also move the
check for root in that case.
 2005-04-05 14:55:33 +00:00
Jacques Vidrine
0fcbbd7bea When PAM support was added to rexecd in revision 1.29 (just prior to 
5.0-RELEASE), a visually elusive bug was introduced.  A comparison
operator was changed to assignment.  As a result, rexecd behaved
always as if the `-i' option had been specified.  It would allow root
logins.  This commit corrects the situation in the obvious way.

A separate bug was introduced at the same time.  The PAM library
functions are called between the invocation of getpwnam(3) and the use
of the returned static object.  Since many PAM library functions
result in additional getpwnam(3) calls, the contents of the returned
static object could be changed from under rexecd.  With this commit,
getpwnam_r(3) is used instead.

Other PAM-using applications should be reviewed for similar errors in
getpw* usage.

Security:	rexecd's documented default policy of disallowing root
		logins was not enforced.
Reviewed by:	cperciva
 2005-03-27 13:59:44 +00:00
David Schultz
13b68b3267 Use sysconf(_SC_ARG_MAX) instead of NCARGS. 2005-03-21 08:01:14 +00:00
Hajimu UMEMOTO
72847b8fff correct WARNS=6 fix to use cast to (void *). 
use of struct sockaddr_strage * is thought as not good manner. :)
 2005-03-01 10:55:06 +00:00
Dag-Erling Smørgrav
6eece4b5f1 If what we have is a struct sockaddr_storage * and what we want is a 
struct sockaddr_storage *, there's no point in casting it prematurely
to a struct sockaddr *.  This unbreaks WARNS=6 on sparc64.
 2005-02-23 21:26:55 +00:00
Dag-Erling Smørgrav
9da3e5bad4 Make WARNS=6-clean. 2005-02-23 17:13:28 +00:00
Stefan Farfeleder
78e3eed071 Fix most cases where the address of an int is passed to a function expecting a 
socklen_t * argument.
 2005-02-14 17:42:58 +00:00
Ruslan Ermilov
a3ac07a54e Sort sections. 2005-01-18 09:29:40 +00:00
Ruslan Ermilov
c481aa05e8 Mechanically kill hard sentence breaks. 2004-07-02 21:28:50 +00:00
Stefan Farfeleder
28e1bf4689 Include <stdlib.h> for exit() and abort() prototypes. 
Approved by:	das (mentor)
 2004-05-24 13:21:24 +00:00
Philippe Charnier
42161502bd Add section number to .Xr 2003-06-08 12:40:50 +00:00
Philippe Charnier
3f162cb85d The .Nm utility 2002-07-06 19:19:48 +00:00
Dag-Erling Smørgrav
d6551d89a2 Unbreak static build and remove usage() that isn't usage(). 
Reviewed by:	bde
 2002-05-03 13:12:06 +00:00
Dag-Erling Smørgrav
7f5e4ed359 PAMify rexecd(8). 
Sponsored by:	DARPA, NAI Labs
 2002-05-02 05:06:32 +00:00
Hajimu UMEMOTO
b2b1845212 When opieverify() is fail, fallback to try unix password. 
Tested by:	kuriyama
 2002-04-16 10:54:30 +00:00
Hajimu UMEMOTO
859be0911a Add an IPv6 support. 
I dunno if there is an IPv6 supported rexec client.  So, it was
tested that this change doesn't break an IPv4.

Tested by:	kuriyama (IPv4 only)
 2002-04-16 10:15:30 +00:00
Jun Kuriyama
0d652d42ca Make this compilable without -DOPIE. 
Hint by:	ume
 2002-04-16 07:53:42 +00:00
Warner Losh
266ebcd391 o __P removal 
o register removal
o use new style prototypes and function definitions
 2002-02-07 23:57:01 +00:00
Kris Kennaway
9357f4121d Lock down with WFORMAT?=1, with overrides in the subdirectories which 
are not yet warning-clean.  Tested on i386 and alpha.
 2002-02-04 02:33:51 +00:00
Bruce Evans
a7dff00b1e Don't clobber the default for CFLAGS. 2001-08-03 21:45:54 +00:00
Sheldon Hearn
e1b4d8d074 Use STD{ERR,IN,OUT}_FILENO instead of their numeric values. The 
definitions are more readable, and it's possible that they're
more portable to pathalogical platforms.

Submitted by:   David Hill <david@phobia.ms>
 2001-07-26 11:02:39 +00:00
Dima Dorfman
7ebcc426ef Remove whitespace at EOL. 2001-07-15 07:53:42 +00:00
Ruslan Ermilov
0efe23d669 mdoc(7) police: removed HISTORY info from the .Os call. 2001-07-10 10:49:54 +00:00
Mark Murray
20934175ae Goodbye S/Key, Hello OPIE. 
I believe I have done due dilligence on this, but I'd appreciate
decent test scenarios and sucess (or failure) reports.
 2001-07-09 17:34:22 +00:00
Brian Somers
7bc6d0158f Fix the type of the NULL arg to execl() 
Idea from: Theo de Raadt <deraadt@openbsd.org>
 2001-07-09 09:24:06 +00:00
David Malone
ea66ccbf96 Avoid a warning by making a variable a const char *. 2001-05-01 10:35:20 +00:00
Ruslan Ermilov
e5b5c66bca - Backout botched attempt to intoduce MANSECT feature. 
- MAN[1-9] -> MAN.
 2001-03-26 14:22:12 +00:00
Ruslan Ermilov
020ee2dc9f Set the default manual section for libexec/ to 8. 2001-03-20 18:10:13 +00:00
Philippe Charnier
57757e9f36 Remove unused #include. Use getopt(3). Add usage() with syslog(3) cap. 2000-11-28 18:15:25 +00:00
Ruslan Ermilov
760819894e mdoc(7) police: use the new features of the Nm macro. 2000-11-20 14:42:24 +00:00
Nick Sayer
210376ef16 Man page fixups 
Submitted by:	sheldonh@uunet.co.za
 2000-05-15 14:06:07 +00:00
Nick Sayer
0d9fb499eb Add -i (insecure) flag to rexecd, which allows uid == 0 logins 
(presuming that the user in question is not in /etc/ftpusers and
does not have a null password).
 2000-05-13 15:58:36 +00:00
Peter Wemm
7f3dea244c $Id$ -> $FreeBSD$ 1999-08-28 00:22:10 +00:00
Brian Somers
9e9a43bdec Ensure that things returned by gethostname() and 
friends are terminated and allow for a maximum
host name length of MAXHOSTNAMELEN - 1.
Put parenthesis around sizeof args.
Make some variables static.
Fix telnetd -u (broken by my last commit)

Prompted by: bde
 1999-04-07 08:27:45 +00:00
Brian Somers
143b4dcdc7 Link with libutil 1999-04-06 23:40:25 +00:00
Brian Somers
32af26a501 Use realhostname() rather than various combinations of 
gethostbyaddr() & gethostbyname().

Remove brokeness in ftpd for hosts of MAXHOSTNAMELEN length.
 1999-04-06 23:06:00 +00:00
Philippe Charnier
6896720af3 Use err(3). -Wall cleaning. Use Pa for file names and add section in Xrefs. 1997-11-26 07:29:04 +00:00
Warner Losh
a51e2c9b04 Julian A's fix. Do chdir as user rather than as root. Fixes a minor NFS 
compatibility problem at the same time.  Some buffer made large enough
for worst case hostname.

fixes PR 2593.

Reviewed by:	Dan Cross and maybe others
 1997-03-24 05:57:28 +00:00
Peter Wemm
9e522f7a18 Revert $FreeBSD$ to $Id$ 1997-02-22 14:22:49 +00:00
Warner Losh
5b266377fd Buffer Overflow from OpenBSD 
rev 1.7 deraadt:
	buf oflow
Obtained from: OpenBSD
 1997-02-09 04:40:02 +00:00
Jordan K. Hubbard
1130b656e5 Make the long-awaited change from $Id$ to $FreeBSD$ 
This will make a number of things easier in the future, as well as (finally!)
avoiding the Id-smashing problem which has plagued developers for so long.

Boy, I'm glad we're not using sup anymore.  This update would have been
insane otherwise.
 1997-01-14 07:20:47 +00:00
Paul Traina
a13e275f66 Back out recent security patch for rexecd. After more careful analysis, 
it is both uneeded and breaks certain lock-step timing in the rexec
protocol.

Yes, an attacker can "relay" connections using this trick,  but a properly
configured firewall that would make this sort of subterfuge necessary in the
first place (instead of direct packet spoofing) would also thwart useful
attacks based on this.
 1996-11-22 08:59:07 +00:00
Paul Traina
6c6cc60e38 Do not attempt to open reverse channel until authentication phase has 
succeeded.

Never allow the reverse channel to be to a privileged port.

Cannidate for:	2.1 and 2.2 branches

Reviewed by:	pst (with local cleanups)
Submitted by:	Cy Shubert <cy@cwsys.cwent.com>
Obtained from:	Jaeger <jaeger@dhp.com> via BUGTRAQ
 1996-11-19 18:03:16 +00:00
Wolfram Schneider
148531ef1e add forgotten $Id$ 1996-09-22 21:56:57 +00:00
Mike Pritchard
ae532ecb79 Check for expired passwords before allowing access to the system. 1995-08-28 21:30:59 +00:00
Peter Wemm
3f59b9c4ef rexecd was not calling "setlogin()" when it should have. This was causing 
getlogin() to return wrong answers (eg: "root").
Reviewed by:	davidg
Obtained from:	James Jegers, for NetBSD, slightly reworked by me.
 1995-07-29 15:21:15 +00:00