d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
217,962 Commits 72 Branches 135 Tags 3.2 GiB
5619c99fb3
Commit Graph

56 Commits

Author SHA1 Message Date
Gleb Smirnoff
9aa8749970 Revert r299830, it has couple of fatal errors. 
The CMSG_ family of macros take care of alignment, so we don't need r299830
at all, even if it was correct.  Put NO_WCAST_ALIGN into Makefile.

Together with:	peter
 2016-05-18 22:02:19 +00:00
Enji Cooper
9ea0bf43e5 Fix .Dd 
Today is the 14th, not the 10th of May

Reported by: igor (derp)
Sponsored by: EMC / Isilon Storage Division
 2016-05-15 03:44:32 +00:00
Enji Cooper
9e1f7d9aa0 Fix fully canonicalized example for myvariable.27... 
`6` doesn't occur in the OID; it was spurious

Bump .Dd for the change

MFC after: 2 weeks
Sponsored by: EMC / Isilon Storage Division
 2016-05-15 03:43:36 +00:00
Enji Cooper
3b8e9f554f Remove trailing whitespace in license tort 
MFC after: 1 week
Reported by: igor
Sponsored by: EMC / Isilon Storage Division
 2016-05-15 03:41:01 +00:00
Enji Cooper
09ac27c318 Fix -Wcast-align warnings 
Use memcpy instead of using direct assignment of void* pointers with
CMSG_DATA(..), which changes alignment

MFC after: 3 weeks
Reported by: clang
Sponsored by: EMC / Isilon Storage Division
 2016-05-15 03:36:19 +00:00
Enji Cooper
126b5bb6a4 Use SNMPD_INPUT_FAILED instead of SNMP_CODE_FAILED 
SNMPD_INPUT_FAILED is `enum snmpd_input_err` type (which matches the return
code from the function). SNMP_CODE_FAILED is `enum snmp_code` type.

MFC after: 1 week
Sponsored by: EMC / Isilon Storage Division
 2016-05-15 00:54:21 +00:00
Enji Cooper
d208c8fa3f Replace QUADFMT with %ju and QUADXFMT with %jx and cast values with uintmax_t 
This will cure some -Wformat warnings

MFC after: 1 week
Reported by: clang, gcc
Sponsored by: EMC / Isilon Storage Division
 2016-05-15 00:10:37 +00:00
Conrad Meyer
4aa1608aee bsnmpd: Fix size of trapsink::comm to match other community arrays 
This fixes a number of possible strcpy() buffer overruns between the various
community strings in trap.c.

Reported by:	Coverity
CIDs:		1006820, 1006821, 1006822
Sponsored by:	EMC / Isilon Storage Division
 2016-05-11 17:06:03 +00:00
Enji Cooper
8ad8cdc95f Use sizeof(*uuser) instead of sizeof(struct usm_user) for consistency with 
the rest of the users in the file

No functional change

MFC after: 3 days
Sponsored by: EMC / Isilon Storage Division
 2016-04-22 08:11:26 +00:00
Enji Cooper
f517a30206 Don't leak string in parse_define(..) when a macro has been found 
and the parser token != TOK_ASSIGN

MFC after: 1 week
CID: 1007187, 1007188
Reported by: Coverity
Obtained from: Isilon OneFS (part of r445479)
Submitted by: Miles Ohlrich <miles.ohlrich@isilon.com>
Sponsored by: EMC / Isilon Storage Division
 2016-04-22 05:14:12 +00:00
Enji Cooper
8cd5a258fb Staticize several variables that are used exclusively in bsnmpd/main.c and 
bsnmpd/trap.c

This fixes several -Wmissing-variable-declaration warnings noted by clang

Differential Revision: https://reviews.freebsd.org/D4718
MFC after: 1 week
Reported by: Jenkins
Reviewed by: araujo
Sponsored by: EMC / Isilon Storage Division
 2015-12-28 01:51:20 +00:00
Enji Cooper
30dfa264d0 Remove unused function act_getkernstring 
This fixes a clang -Wunused warning

Differential Revision: https://reviews.freebsd.org/D4697
MFC after: 1 week
Reported by: Jenkins
Reviewed by: araujo, bapt
Sponsored by: EMC / Isilon Storage Division
 2015-12-24 22:22:02 +00:00
Gleb Smirnoff
23cea7199b Re-do r240271: 
- Set IP_RECVDSTADDR sockopt on the socket only in case if
  it is INADDR_ANY bound.
- Supply IP_SENDSRCADDR control message only if we did receive
  IP_RECVDSTADDR control message.

This fixes operation of snmpd bound to a specific local IP address.

PR:		bin/171279
 2012-09-20 05:41:20 +00:00
Gleb Smirnoff
f2ddd22eac For UDP transport set IP_RECVDSTADDR sockopt on the socket, and provide 
IP_SENDSRCADDR control with datagram message we reply with. This makes
bsnmpd reply from exactly same address that request was sent to, thus
successfully bypassing stateful firewalls or other kinds of strict checking.

PR:		bin/171279
 2012-09-09 09:46:48 +00:00
Gleb Smirnoff
0cf0d912b7 The first part of check_priv() function, that attempts to obtain creds 
from the control message, actually never worked. This means check_priv()
didn't work for local dgram sockets.

The SCM_CREDS control messages is received only in two cases:

1) If we did setsockopt(LOCAL_CREDS) on our socket, and in this case
   the message is struct sockcred.
2) If sender did supplied SCM_CREDS control message in his sendmsg()
   syscall. In this case the message is struct cmsgcred.

We can't rely on 2), so we will use 1) for dgram sockets. For stream
sockets it is more reliable to obtain accept-time credentials, since
SCM_CREDS control message is attached only on first read. Thus:

o Do setsockopt(LOCAL_CREDS) on local dgram sockets.
o Split check_priv() into check_priv_stream() and check_priv_dgram(),
  and call them from recv_stream() and recv_dgram() respectively.
o Don't provide space for SCM_CREDS control message in recv_stream().
o Provide space for SCM_CREDS control message in recv_dgram(), but there
  is no need to initialize anything in it.
o In recv_dgram() do not blindly expect that first message is SCM_CREDS,
  instead use correct search cycle through control messages.
 2012-09-08 07:12:00 +00:00
Kevin Lo
31f7ba0295 Fully initialize the stack-allocated "struct sockaddr_in sa" structure. 2012-09-07 08:58:30 +00:00
Hartmut Brandt
9972acaa15 memset() wants the size of the structure to clear, not the size 
of the pointer to it.

Submitted by:	Pawel Worach
 2012-03-18 19:28:52 +00:00
Mikolaj Golub
b2b91ddf9d Include sys/queue.h: snmpmod.h uses TAILQ. 
PR:		bin/153153
MFC after:	2 weeks
 2011-12-11 17:10:33 +00:00
Ruslan Ermilov
81b587f396 Don't spam syslog with "inet_ntop(): Address family not supported 
by protocol family" when processing requests received from the
UNIX domain socket.

MFC after:	3 days
 2011-04-20 08:38:25 +00:00
Shteryana Shopova
cf90ea94a0 Unbreak the build by temprorarily not using include directives in 
bsnmpd(1)' def files, until bsd.snmpmod.mk & Makefiles are fixed to
pass proper include path flags to gensnmptree.
 2010-12-20 22:56:50 +00:00
Shteryana Shopova
72cd7a520d Bring in a SNMP module that allows configuration of SNMPv3 Notification targets. 
Sponsored by:	The FreeBSD Foundation
Reviewed by:	philip
Approved by:	philip
 2010-12-20 17:13:14 +00:00
Shteryana Shopova
135f7de5dd In bsnmpd(1) add support for SNMPv3 message processing model, including message authentication, packet encryption & view-based access control (RFC 3412, 3414, 3415). 
Sponsored by:	The FreeBSD Foundation
Reviewed by:	philip@ (mostly)
Approved by:	philip@
 2010-12-08 13:51:38 +00:00
Ulrich Spörlein
d9962dc588 Remove mention of non-existant -o flag for debugging options. 
MFC after:	3 days
 2010-10-23 12:27:39 +00:00
Joel Dahl
54be88c948 Fix two minor typos. 2010-08-16 21:12:26 +00:00
Ulrich Spörlein
f239d44ec1 Bump document date after content changes. 
Pointy hat to:	uqs
 2010-08-16 19:05:10 +00:00
Ulrich Spörlein
e5cce4162a Wordsmithing of bsnmpd.1 
PR:		docs/149157
Submitted by:	Warren Block <wblock@wonkity.com>
MFC after:	1 week
 2010-08-16 18:47:35 +00:00
Ulrich Spörlein
4f13bbb691 mdoc: consistently spell our email addresses <foo@FreeBSD.org> 
Reviewed by:	ru
Approved by:	harti
 2010-05-24 06:26:38 +00:00
Antoine Brodin
5a64472b2a (S)LIST_HEAD_INITIALIZER takes a (S)LIST_HEAD as an argument. 
Fix some wrong usages.
Note: this does not affect generated binaries as this argument is not used.

Approved by:	harti@
 2010-03-27 13:43:18 +00:00
Ulrich Spörlein
ddedd8277a Fix typo in macro name and macro usage. 
Found by:	make manlint
Reviewed by:	ru
Approved by:	harti, philip (mentor)
 2010-03-12 11:05:37 +00:00
Shteryana Shopova
02f27f1cfa This commit was generated by cvs2svn to compensate for changes in r176892, 
which included commits to RCS files with non-trunk default branches.
 2008-03-07 09:33:29 +00:00
Shteryana Shopova
691f8568ea Vendor patch: Prevent bsnmpd from dumping core when a module's init hook 
returns an error.

Approved by:	bz (mentor), harti
 2008-03-07 09:33:29 +00:00
Hartmut Brandt
cab70e0247 Vendor patch: synthesize the initial value for sysObjectId from the value 
of uname -r in FreeBSD. This value can be overwritten in the configuration
file.

Suggested by:	phk
 2006-10-31 09:00:35 +00:00
Hartmut Brandt
f56ce4bd26 This commit was generated by cvs2svn to compensate for changes in r163820, 
which included commits to RCS files with non-trunk default branches.
 2006-10-31 09:00:35 +00:00
Hartmut Brandt
748b5b1ebd Virgin import of bsnmpd 1.12 2006-02-27 16:16:18 +00:00
Hartmut Brandt
568d256aa1 This commit was generated by cvs2svn to compensate for changes in r156066, 
which included commits to RCS files with non-trunk default branches.
 2006-02-27 16:16:18 +00:00
Hartmut Brandt
fa122c2038 Vendor patch: string_get_max() function to return strings with a maximum 
SNMP string length.
 2006-02-07 15:48:37 +00:00
Hartmut Brandt
74b07c5412 This commit was generated by cvs2svn to compensate for changes in r155429, 
which included commits to RCS files with non-trunk default branches.
 2006-02-07 15:48:37 +00:00
Hartmut Brandt
5105400329 Vendor patch: prevent a core dump when the trace option is not followed 
by an option value.

Submitted by:	Shteryana Shopova <shteryana@yahoo.com>
 2006-01-31 14:59:07 +00:00
Hartmut Brandt
3dc7424242 This commit was generated by cvs2svn to compensate for changes in r155094, 
which included commits to RCS files with non-trunk default branches.
 2006-01-31 14:59:07 +00:00
Hartmut Brandt
d4199d75a1 Vendor fix: make the default read and write communities NULL. This 
basically disables any access unless other strings are set in the config
file. Note, that there is no way to set the communities back to NULL once
they're set to something not NULL.
 2006-01-10 11:49:26 +00:00
Hartmut Brandt
5b1d3a5c13 This commit was generated by cvs2svn to compensate for changes in r154180, 
which included commits to RCS files with non-trunk default branches.
 2006-01-10 11:49:26 +00:00
Hartmut Brandt
e9d4cb69e2 Vendor patch: fix a bug when parsing the include path. 2006-01-10 11:47:56 +00:00
Hartmut Brandt
2bc6540439 This commit was generated by cvs2svn to compensate for changes in r154178, 
which included commits to RCS files with non-trunk default branches.
 2006-01-10 11:47:56 +00:00
Hartmut Brandt
4c0a7af955 Vendor fix for the build problem of snmp_pf. Move the fallback definitions 
for U?INT32_{MAX,MIN} from asn1.h into the .c files that actually require
them (the .h file doesn't refer to these macros).
 2005-10-05 15:19:56 +00:00
Hartmut Brandt
bb5e059e0d This commit was generated by cvs2svn to compensate for changes in r150974, 
which included commits to RCS files with non-trunk default branches.
 2005-10-05 15:19:56 +00:00
Hartmut Brandt
e50dd7e071 These files are not needed and were imported by accident in the 
previous import.
 2005-10-04 14:51:55 +00:00
Hartmut Brandt
165c5d31cb Virgin import of bsnmpd 1.11 2005-10-04 14:41:06 +00:00
Hartmut Brandt
69292ced51 Virgin import of bsnmpd 1.10 2005-05-23 11:19:11 +00:00
Hartmut Brandt
a9bfedb789 Vendor patch: fix a bug that was introduced when moving from libisc to 
libbegemot: the rpoll_start_timer function needs the timeout value in
milli-seconds, not the absolute time when the timer should tick.
 2005-04-29 11:02:18 +00:00
Hartmut Brandt
d7eb6b4714 Virgin import of bsnmp 1.9 2005-04-26 16:43:22 +00:00