Commit Graph

103 Commits

Author SHA1 Message Date
Ruslan Ermilov
a216173556 NOCRYPT -> NO_CRYPT 2004-12-21 10:16:04 +00:00
Xin LI
74ec0afcc7 Correct two bugs that may result in incorrect CBCP response for
administrator specified number.

The implementation in our version transmits extra zero byte that is a
violation of the Microsoft PPP Callback Control Protocol section 3.2[1].
This can lead to incorrect behavior on certain devices, as reported
in bin/50613.

Confirmed with:	cbcp.c in ppp's cvs, rev. 1.4 and 1.15 [2]

Submitted by:	Dmitry Pryanishnikov <dmitry at atlantis.dp.ua>
PR:		bin/50613

[1] http://www.dsl.gr.jp/~manabe/PPxP/doc/Standards/draft-gidwani-ppp-callback-cp-00.txt
[2] http://cvs.samba.org/cgi-bin/cvsweb/ppp/pppd/cbcp.c
    http://www.samba.org/cvs.html
2004-12-06 15:49:52 +00:00
Xin LI
37ee573ec6 Correct a potential DoS vulnerability, as described at
http://www.securityfocus.com/archive/1/379450

This patch is based on dillon's patch on DragonFlyBSD, which is in
turn derived from OpenBSD's src/usr.sbin/pppd/cbcp.c,v 1.6.

Obtained from:	OpenBSD via DragonFlyBSD
Encouraged by:	nectar
2004-11-10 05:49:52 +00:00
Colin Percival
d37df47d31 Join the 21st century: Cryptography is no longer an optional component
of releases.  The -DNOCRYPT build option still exists for anyone who
really wants to build non-cryptographic binaries, but the "crypto"
release distribution is now part of "base", and anyone installing from a
release will get cryptographic binaries.

Approved by:	re (scottl), markm
Discussed on:	freebsd-current, in late April 2004
2004-08-06 07:27:08 +00:00
Maxim Konovalov
efccc7dc25 o SIOCGIFCONF->getifaddrs(2) conversion.
PR:		bin/9379
Obtained from:	NetBSD
2004-04-09 16:59:05 +00:00
Maxim Konovalov
4b40c43af8 o Now when the Cold War is ended we can confess our pppd(8) supports
CBCP (Call Back Configuration Protocol).  Document 'callback phone_number'.

Obtained from:	NetBSD (pppd/pppd.8, rev. 1.26)
MFC after:	3 weeks
2004-02-28 21:32:40 +00:00
Peter Wemm
144b6720d9 Disclaim ownership of pppd/chat. It is vendor code, but has been badly
neglected here.
2003-10-29 19:24:04 +00:00
Peter Wemm
cf6453779c Fix a 64 bit time_t bogon that I missed from before. lastlog.ll_time is
not a time_t.
2003-10-26 06:01:06 +00:00
Mark Murray
ebb9f0efa8 Don't check for the existance of src/crypto/ for building items that
may contain crypto. The days of ITAR paranoia are over, and the simple
macro tests that remain are sufficient.
2003-07-24 18:30:25 +00:00
Dag-Erling Smørgrav
7691f66abf Retire the useless NOSECURE knob.
Approved by:	re (scottl)
2003-05-19 15:52:01 +00:00
Peter Wemm
ec480a9740 Add __amd64__ to an ifdef set so that pppd compiles. Reactivate on amd64.
Approved by:  re (amd64 "safe" ifdefs etc)
2003-05-12 18:51:31 +00:00
Max Khon
d4c6c8f992 RFC1548, section 5.8:
Echo-Request and Echo-Reply packets may only be sent in the LCP
Opened state.  Echo-Request and Echo-Reply packets received in any
state other than the LCP Opened state SHOULD be silently discarded.

PR:		45760
Submitted by:	Eugene Grosbein
MFC after:	2 weeks
2003-04-07 13:34:00 +00:00
David E. O'Brien
052238b16c style.Makefile(5) 2003-04-04 17:49:21 +00:00
Jens Schweikhardt
9d5abbddbf Correct typos, mostly s/ a / an / where appropriate. Some whitespace cleanup,
especially in troff files.
2003-01-01 18:49:04 +00:00
Jens Schweikhardt
d64ada501a Fix typos, mostly s/ an / a / where appropriate and a few s/an/and/
Add FreeBSD Id tag where missing.
2002-12-30 21:18:15 +00:00
Jens Schweikhardt
57bd0fc6e8 english(4) police. 2002-12-27 12:15:40 +00:00
Peter Wemm
6ceeb6902a utmp.ut_time and lastlog.ll_time are explicitly int32_t rather than
time_t.  Deal with the possibility that time_t != int32_t.  This boils
down to this sort of thing:
 -   time(&ut.ut_time);
 +   ut.ut_time = time(NULL);
and similar for ctime(3) etc.  I've kept it minimal for the stuff
that may need to be portable (or 3rd party code), but used Matt's time32
stuff for cases where that isn't as much of a concern.

Approved by: re (jhb)
2002-11-15 22:42:00 +00:00
Brooks Davis
51480d2fff Test for the existance of kernel ppp support by seeing if the kernel has
the module compiled in or loaded instead of bogusly checking for ppp0.
Also if and only if the caller is actually root and the kernel does not
have ppp support, try to load the ppp module before giving up.
2002-11-05 05:58:31 +00:00
Jacques Vidrine
24280a8fbb Check for FD_SET overruns.
Approved by:	peter
2002-09-17 15:52:35 +00:00
Philippe Charnier
f0067240a1 Replace various spelling with FALLTHROUGH which is lint()able 2002-08-25 13:30:43 +00:00
Peter Wemm
dfeeeca3bf Use fchmod() to restore the tty modes. 2002-07-30 03:49:27 +00:00
David Malone
d3275eea44 inet_aton returns 0 on failure, not -1.
PR:		37680
Submitted by:	Scott Bertilson <scott@nts.umn.edu>
MFC after:	2 weeks
2002-05-06 08:39:43 +00:00
Maxim Konovalov
7b65fef03a Unbreak PAP-only authentication.
PR:			i386/34607
Not objected by:	peter
Approved by:		ru
Obtained from:		ppp-2.4.1b2
MFC after:		1 week
2002-03-05 10:50:55 +00:00
Crist J. Clark
76f10508d4 Put a complete set of pppd(8) sample configuration files in
/usr/share/examples/pppd.

Update pppd(8) documentation to reflect this, usr.sbin/pppd/pppd.8.

Remove the out-of-place pppd(8) configuration files in etc/ppp,
ppp.shells.sample and ppp.deny.

Make the appropriate changes to the build process, etc/Makefile and
etc/mtree/BSD.usr.mtree, so it all works.

The files from etc/ppp, ppp.shells.sample and ppp.deny, were moved
with a repo copy. Note it in the logs with a forced commit to these
two.

Submitted by:	Maxim Konovalov <maxim@macomnet.ru> provided the new samples.
2002-01-29 00:23:35 +00:00
Jeroen Ruigrok van der Werven
fdc0360913 Logging should wind up in /var/log, not /etc/ppp/.
PR:		11989
Submitted by:	Phil Homewood <phil@rivendell.apana.org.au>
MFC after:	1 week
2001-07-31 16:09:29 +00:00
Kris Kennaway
e9c56664e7 Install this mode 4550 owned by group dialer; there is unsafe code
in the signal handlers which may pose a risk when executable by untrusted
users.

Submitted by:	Przemyslaw Frasunek <venglin@freebsd.lublin.pl>
MFC After:	3 days
2001-07-24 02:37:48 +00:00
David E. O'Brien
90e655ea4e Perform a major cleanup of the usr.sbin Makefiles.
These are not perfectly in agreement with each other style-wise, but they
are orders of orders of magnitude more consistent style-wise than before.
2001-07-20 06:20:32 +00:00
Dima Dorfman
f247324df7 Remove whitespace at EOL. 2001-07-15 08:06:20 +00:00
Ruslan Ermilov
345e52e742 - Backout botched attempt to introduce MANSECT feature.
- MAN[1-9] -> MAN.
2001-03-26 14:42:20 +00:00
Ruslan Ermilov
c73e22c3d4 Set the default manual section for usr.sbin/ to 8. 2001-03-20 18:17:26 +00:00
Jeroen Ruigrok van der Werven
2fa72ea7d4 Fix typo: compatability -> compatibility.
Compatability is not an existing english word.
2001-02-06 12:05:58 +00:00
David E. O'Brien
1a37aa566b Add `_PATH_DEVZERO'.
Use _PATH_* where where possible.
2000-12-09 09:35:55 +00:00
Kris Kennaway
bc488ed1ad Constify 2000-11-27 08:18:58 +00:00
Kris Kennaway
38e1809ae3 Remove the last vestiges of libRSAglue now that it's an empty stub.
This should fix the buildworld problems some people were seeing.

Approved by:	jkh
2000-03-11 22:34:10 +00:00
Kris Kennaway
bb49f794f5 Buildworld fixes for NO_OPENSSH and NO_OPENSSL
Approved by:	jkh
2000-03-09 06:29:05 +00:00
Sheldon Hearn
a3f3c85b7f Remove single-space hard sentence breaks. These degrade the quality
of the typeset output, tend to make diffs harder to read and provide
bad examples for new-comers to mdoc.
2000-03-03 09:11:28 +00:00
Mark Murray
354e20794f Update DISTRIBUTION for new crypto world order. 2000-02-29 11:45:48 +00:00
Mark Murray
512182f3ff Use libcrypto instead of libdes. 2000-02-24 21:10:28 +00:00
Peter Wemm
97d92980a9 $Id$ -> $FreeBSD$ 1999-08-28 01:35:59 +00:00
Andrzej Bialecki
a4df7ffed9 Add a knob to avoid DES code when making crunched binary. This isn't a beauty
incarnated, it just matches other deficiencies related to crunchgen
and friends... and we already have similar code in ppp/Makefile.

RELEASE_CRUNCH should be axed, but for now let's be consistent.

Submitted by:	Patrick Powell <papowell@astart.com>
1999-07-15 21:47:52 +00:00
Brian Somers
43f9e1bb41 Reset our start time when the link comes up, correcting
the reported connection time.

PR:		11943
Submitted by:	Peter Mutsaers <plm@xs4all.nl>
1999-06-17 22:12:51 +00:00
Archie Cobbs
eed2b804bf When incrementing through a SIOCGIFCONF list, enforce a lower limit of
sizeof(ifr->ifr_addr) for the variable length field ifr->ifr_addr.sa_len.
Otherwise the increment will be wrong in certain cases.

Obtained from:  Whistle source tree
For the record: Garrett Wollman <wollman@khavrinen.lcs.mit.edu> suggests
                SIOCGIFCONF should be dropped in favor of a sysctl mechanism.
1999-06-05 05:55:07 +00:00
John Polstra
d74efe9105 pppd/Makefile:
Enable MS-CHAP support.

release/Makefile:
  Build a separate NOCRYPT version of pppd, to keep This Great
  Nation's top-secret cryptographic tools out of the filthy hands
  of those evil furriners.
1999-04-29 17:56:28 +00:00
John Polstra
9836a38f7b Fix the MS-CHAP support. The code was passing a bit count to
MD4Update(), but our version in libmd expects a byte count.

This code is not currently compiled or linked into pppd, so I'm
reasonably sure I didn't break anything. :-)  I added the necessary
statements to the Makefile, but left them commented out because we
are in feature freeze.  When the code is enabled, we must be careful
to build it only if the DES library is available.
1998-10-11 19:40:38 +00:00
David E. O'Brien
2887f586f0 Remove useless `BINOWN=root' now that it is the default. 1998-09-19 22:42:14 +00:00
Peter Wemm
05f5bac14a Forgot to resync the RELNOTES to 2.3.5 1998-06-23 21:41:58 +00:00
Peter Wemm
0e40275a28 remove old hack that's no longer needed and now breaks the compile 1998-06-21 04:47:21 +00:00
Peter Wemm
f3af07bd28 Merge ppp 2.3.3 -> 2.3.5 changes onto mainline. 1998-06-20 18:02:16 +00:00
Peter Wemm
a65dba1221 ppp-2.3.x ships with a bad compression number for deflate. It uses number
24 (which is magnalink!) rather than the correct (according to the rfc) 26.

Initial attempt at a compatability kludge that will negotiate for either
but will prefer to use the correct deflate compression type.
1998-03-22 06:57:20 +00:00
Peter Wemm
1ceb7f1f59 Merge ppp-2.3.3 changes onto mainline 1998-03-22 05:33:08 +00:00