d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
283,205 Commits 72 Branches 135 Tags 3.2 GiB
820ac12679
Commit Graph

13 Commits

Author SHA1 Message Date
Alexander V. Chernikov
bbff3a72b2 Fix typo in pwait.c introduced in 5bdce6ff54 
Reported by:	kevans
 2021-01-21 21:43:27 +00:00
Alexander V. Chernikov
5bdce6ff54 Remove deadlock in rc caused by pwait waiting for itself. 
The following situation can trigger the deadlock:
1) Long time ago a_service was started through rc.d
2) We want to restart a_service and issue service a_service restart
3) rc.subr reads current process PID (via file or process),
   sends TERM signal and runs pwait with PID harvested
4) a_service process dies very quickly so it's PID becomes available.
   It is possible that while original process was running,
   PID counter overflowed and pwait got assigned a_service's PID.

This patch ignores pid(s) to wait that are equal to pwait PID.

Reported by:	Dan McGregor, Boris Lytochkin
Submitted by:	Boris Lytochkin <lytboris at gmail.com>
Reviewed By:	0mp
MFC after:	2 weeks
PR:		218598
Differential Revision: https://reviews.freebsd.org/D28240
 2021-01-21 21:36:37 +00:00
Xin LI
778ac8d371 Remove unused include. 
MFC after:	2 weeks
 2020-02-02 20:51:28 +00:00
Pawel Jakub Dawidek
d731a314d3 Restore previous usage presentation (without "pwait: " prefix). 
Pointed out by:	jilles
 2020-02-01 09:13:11 +00:00
Pawel Jakub Dawidek
9677354790 Style changes, mostly usage of braces around single line statements - 
it is safer and allowed for some time now by style(9).

Sponsored by:	Fudo Security
 2020-01-26 11:13:34 +00:00
Pawel Jakub Dawidek
2362bc2cf5 Implement -o flag which tells pwait(1) to exit if any of the given processes 
has terminated.

Sponsored by:	Fudo Security
 2020-01-26 11:02:51 +00:00
Pawel Jakub Dawidek
5e2e2222ae Don't setup a timeout if we are exiting. 
Sponsored by:	Fudo Security
 2020-01-26 10:54:16 +00:00
Pawel Jakub Dawidek
3f50bbaf51 Check for duplicated PID without using additional variable. 
Sponsored by:	Fudo Security
 2020-01-26 10:51:57 +00:00
Pawel Jakub Dawidek
532b3f4791 - Be consistent with using sysexits(3) codes. 
- Turn fprintf()+exit() into errx().

Sponsored by:	Fudo Security
 2020-01-26 10:49:24 +00:00
Bryan Drewery
b06b52baac pwait: Add a -t flag to specify a timeout before exiting, and tests. 
The exit status will be 124, as the timeout(1) utility uses.

Reviewed by:	jilles
MFC after:	2 weeks
Differential Revision:	https://reviews.freebsd.org/D9697
 2017-03-07 22:16:55 +00:00
Xin LI
f3de285bbf Use a different way to silence clang analyzer as done in r245494 by 
explicitly telling the compiler that we are on the exit route.

X-MFC:	together with r245494
 2013-01-16 18:15:25 +00:00
Eitan Adler
28e4657584 Free memory before exiting in order to silence a warning from the clang 
static analyzer

Approved by:	cperciva
MFC after: 	3 days
 2013-01-16 05:03:52 +00:00
Jilles Tjoelker
0e5e416780 Add pwait utility, which waits for any process to terminate. 
This is similar to the Solaris utility of the same name.

Some use cases:
* rc.subr's wait_for_pids
* interactive use, e.g. to shut down the computer when some task is done
  even if the task is already running

Discussed on:	hackers@
 2009-11-17 22:47:20 +00:00