d/freebsd-dev
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
202,204 Commits 72 Branches 135 Tags 3.2 GiB
8bc7851803
Commit Graph

30 Commits

Author SHA1 Message Date
Alexander Motin
f249b52d9a Fix bug in r278331: unlike some other options MaxRecvDataSegmentLength 
is not negotiated as minimum, but only reported by sides to each other.

MFC after:	1 week
 2015-06-02 01:47:12 +00:00
Edward Tomasz Napierala
aa32b5e076 Make setproctitle(3) work in Capsicum capability mode. This makes 
ctld(8) child processes to indicate initiator address and name in
their titles, similar to what iscsid(8) child processes do.

PR:		181352
Differential Revision:	https://reviews.freebsd.org/D2363
Reviewed by:	rwatson@, mjg@
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2015-04-27 11:18:16 +00:00
Xin LI
a7c4ad3926 Eliminate unused headers. 2015-04-14 18:13:55 +00:00
Edward Tomasz Napierala
a9d7821075 Move the "offload" clause from the target section to portal-group 
section; it makes more sense there.

MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2015-02-28 12:02:32 +00:00
Edward Tomasz Napierala
07b49a3eed Make it possible to set (via ctl.conf(5)) and query (via ctladm islist -v) 
target iSCSI offload.  Add mechanism to query maximum receive data segment
size supported by chosen hardware offload module, and use it in ctld(8)
to determine the value to advertise to the other side.

MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2015-02-06 21:03:25 +00:00
Alexander Motin
92847ee1f3 Add support for multiple portal groups per target. 
This change allows multiple "portal-group" options to be specified per
target.  Each of them may include new optional auth-group name parameter
to override per-target auth parameters for specific portal group.

Kernel side support was added earlier at r278161.

MFC after:	2 weeks
Sponsored by:	iXsystems, Inc.
 2015-02-06 17:43:13 +00:00
Alexander Motin
3f9e1172b7 Slightly polish iSCSI parameters negotiation. 
MFC after:	1 week
 2014-12-19 01:12:22 +00:00
Alexander Motin
2124e3b07f Make sequence numbers checks more strict. 
While we don't support MCS, hole in received sequence numbers may mean
only PDU loss.  While we don't support lost PDU recovery, terminate the
connection to avoid stuck commands.

While there, improve handling of sequence numbers wrap after 2^32 PDUs.

MFC after:	2 weeks
 2014-12-17 15:13:21 +00:00
Edward Tomasz Napierala
7889a0832f Fix several nits in redirection handling - don't use wrong CSG, 
and avoid use-after-free.

MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-11-09 13:30:02 +00:00
Edward Tomasz Napierala
6dbdbf825d Add support for sending redirections to iSCSI target. 
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-11-09 13:01:09 +00:00
Edward Tomasz Napierala
0537488353 Add discovery-filter. This makes it possible to restrict which targets 
are returned during discovery based on initiator portal, name, and CHAP
credentials.

Reviewed by:	mav@
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-10-29 09:26:55 +00:00
Edward Tomasz Napierala
e867e16225 Make the initiator-name and initiator-portal checks a little nicer. 
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-10-24 11:40:09 +00:00
Edward Tomasz Napierala
ff982835f8 Tidy up the login code; no functional changes. 
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-10-24 11:34:55 +00:00
Edward Tomasz Napierala
2bd282696a Whitespace fixes. 
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-10-22 09:17:17 +00:00
Edward Tomasz Napierala
45078155e3 Untangle iSCSI authentication code by splitting off the CHAP 
implementation.

Reviewed by:	mav@
MFC after:	1 month
Sponsored by:	The FreeBSD Foundation
 2014-10-22 08:59:23 +00:00
Edward Tomasz Napierala
2e779f745b Use keys_add_int() where appropriate. No functional changes. 
Sponsored by:	The FreeBSD Foundation
 2014-09-09 16:57:02 +00:00
Edward Tomasz Napierala
dce704a67a Fix ctld(8) to not forget to send TargetPortalGroupTag and TargetAlias 
when the initiator skips security negotiation.  This fixes interoperability
with Xtend SAN initiator.

PR:		193021
MFC after:	1 week
Sponsored by:	The FreeBSD Foundation
 2014-09-09 16:45:36 +00:00
Edward Tomasz Napierala
d69440367c Fix typo. 
MFC after:	2 weeks
Sponsored by:	The FreeBSD Foundation
 2014-09-05 11:10:44 +00:00
Edward Tomasz Napierala
b7a65e3936 Make the iSCSI stack use __FBSDID() properly. 
MFC after:	2 weeks
Sponsored by:	The FreeBSD Foundation
 2014-08-21 15:32:38 +00:00
Alexander Motin
073edb1c91 Add netmasks support to initiator-portal option. 
MFC after:	2 weeks
 2014-07-28 12:47:09 +00:00
Alexander Motin
6d81c129dd Pass through iSCSI session ISID from LOGIN request to the CTL frontend. 
ISID is an important part of initiator transport ID for iSCSI.  It is not
used now, but should be to properly implement persistent reservation.
 2014-07-05 21:18:33 +00:00
Edward Tomasz Napierala
639466801c Use proper terminology in debug messages. 
Sponsored by:	The FreeBSD Foundation
 2014-04-16 11:03:21 +00:00
Edward Tomasz Napierala
e6954b999d Make the error message more clear. 
Sponsored by:	The FreeBSD Foundation
 2014-03-19 13:00:44 +00:00
Edward Tomasz Napierala
e76ce4484d Use new auth-type "deny" instead of using "chap" with no chap entries; 
it's cleaner this way, and gives better feedback to the user.

Sponsored by:	The FreeBSD Foundation
 2014-02-11 11:32:36 +00:00
Edward Tomasz Napierala
f7ae5bf8de Rename a variable, no functional changes. 
Sponsored by:	The FreeBSD Foundation
 2014-02-11 11:14:50 +00:00
Edward Tomasz Napierala
8cb2e95863 Implement initiator-name and initiator-portal restrictions. 
Sponsored by:	The FreeBSD Foundation
 2014-02-11 11:08:04 +00:00
Edward Tomasz Napierala
017cbe4aaa Empty data segment during Login Phase is rather unlikely, but it's 
not, by itself, a protocol error.  This fixes interoperability with
OpenBSD initiator.

Sponsored by:	The FreeBSD Foundation
 2014-02-11 10:58:32 +00:00
Edward Tomasz Napierala
b30f0d901a Fix handling for empty auth-groups. Without it, ctld child process 
would either exit on assertion, or, if assertions are not enabled,
fail to authenticate the target.

MFC after:	2 days
Sponsored by:	The FreeBSD Foundation
 2013-12-10 17:27:11 +00:00
Edward Tomasz Napierala
5989c4cc16 Plug memory leaks. 
Coverity CID:	1087993, 1087992
Approved by:	re (marius)
Sponsored by:	FreeBSD Foundation
 2013-10-09 13:28:45 +00:00
Edward Tomasz Napierala
009ea47eb2 Bring in the new iSCSI target and initiator. 
Reviewed by:	ken (parts)
Approved by:	re (delphij)
Sponsored by:	FreeBSD Foundation
 2013-09-14 15:29:06 +00:00