Commit Graph

40327 Commits

Author SHA1 Message Date
Warner Losh
28ea3785d9 neta: remove write only variable
Sponsored by:		Netflix
2022-04-05 21:42:06 -06:00
Warner Losh
37466424b2 mxge: Remove write only variables, mark ifp __unused
Sponsored by:		Netflix
2022-04-05 21:42:06 -06:00
Warner Losh
7e5c042cce msk: Remove write only variables, but leave hardware reads in place
Sponsored by:		Netflix
2022-04-05 21:42:06 -06:00
Warner Losh
85ecba9b20 mwl: Remove write only variables, but leave hardware reads in place
Sponsored by:		Netflix
2022-04-05 21:42:06 -06:00
Warner Losh
fba6f8efb6 malo: Remove write only variables, but leave hardware reads in place
Sponsored by:		Netflix
2022-04-05 21:42:05 -06:00
Warner Losh
d483782ecf intpm: Remove write only variables, tag slvcnt unused since it's used for debugging
Sponsored by:		Netflix
2022-04-05 21:42:05 -06:00
Warner Losh
8707108f33 ipmi: Remove write only variables used to read form hardware
Sponsored by:		Netflix
2022-04-05 21:42:05 -06:00
Warner Losh
1545c66789 hwpmc_arm64: remove write only variables and the computations they do
Sponsored by:		Netflix
2022-04-05 21:42:05 -06:00
Warner Losh
20669405d2 flexspi: In flex_spi_task remove dev, it's write only
Sponsored by:		Netflix
2022-04-05 21:42:05 -06:00
Warner Losh
094b2a2379 ena: Remove write only variables
Sponsored by:		Netflix
2022-04-05 21:42:05 -06:00
Warner Losh
5f5986656c cas: Mark work3 as unused: we apparently need to read it from hardware, but ignore its value
Sponsored by:		Netflix
2022-04-05 21:42:05 -06:00
Warner Losh
5035b5f5b0 bwi: Mark write-only variable as __unused
We read TX_STATUS1 to acknowledge a TX interrupt. We don't use this
value for anything, so mark it as unused. We may be able to eliminate
this read, but since this hardware is poorly documented and difficult to
test, I'm leaving the read in place.

Sponsored by:		Netflix
2022-04-05 13:52:55 -06:00
Warner Losh
6e5056a903 bwi: Remove write-only variable
bbp_atten is write-only: we don't use it later in
bwi_rf_calc_nrssi_slope_11b. However, we may also be able to eliminate
the read of this value from the device. However, The documationation for
this hardware is thing and I can't test this card so I've left the read
of this register in case it's required.

Sponsored by:		Netflix
2022-04-05 13:52:54 -06:00
Warner Losh
cbf7b9e6ee bce: Mark a few debugging variables as unused.
Sponsored by:		Netflix
2022-04-05 13:52:54 -06:00
Mitchell Horne
c9114f9f86 Add new vnode dumper to support live minidumps
This dumper can instantiate and write the dump's contents to a
file-backed vnode.

Unlike existing disk or network dumpers, the vnode dumper should not be
invoked during a system panic, and therefore is not added to the global
dumper_configs list. Instead, the vnode dumper is constructed ad-hoc
when a live dump is requested using the new ioctl on /dev/mem. This is
similar in spirit to a kgdb session against the live system via
/dev/mem.

As described briefly in the mem(4) man page, live dumps are not
guaranteed to result in a usuable output file, but offer some debugging
value where forcefully panicing a system to dump its memory is not
desirable/feasible.

A future change to savecore(8) will add an option to save a live dump.

Reviewed by:	markj, Pau Amma <pauamma@gundo.com> (manpages)
Discussed with:	kib
MFC after:	3 weeks
Sponsored by:	Juniper Networks, Inc.
Sponsored by:	Klara, Inc.
Differential Revision:	https://reviews.freebsd.org/D33813
2022-04-05 15:35:05 -03:00
Chandrakanth Patil
79c4c4be96 mrsas: if controller reset is in progress, refrain from firing DCMDs to
firmware in shutdown

If controller reset is in progress, at same time if system shutdown is
issued then corresponding shutdown function in driver will be invoked
where driver is waiting 15 seconds to complete the controller reset.

If the reset is not complteted within that time frame driver will go
ahead and fire cache flush and shutdown DCMDs which will end up
accessing the the queues which are not initialized due to undergoing
reset leads to FMU error in firmware.

Fix:
In shutdown function, if controller reset is not finished within 15
seconds than driver will return to the OS without firing any DCMDs.

Reviewed by: imp
PR: 261375
2022-04-05 08:38:15 -06:00
Chandrakanth Patil
241bb95552 mrsas: remove additional MPT command allocation for R1 FP command
There is an additional MPT command allocation for R1 fp command which
will lead to MPT command unavailablity in case of rigorous R1 FP IOs.

Remove additional MPT command allocation for R1 FP.

Reviewed by: imp
PR: 261377
2022-04-05 08:38:14 -06:00
Warner Losh
c972f2c065 xl_attach: eliminate write only variable unit
Sponsored by:		Netflix
2022-04-04 22:30:45 -06:00
Warner Losh
76e9675663 vtpci_legacy_register_msix: eliminate write only variable dev
Sponsored by:		Netflix
2022-04-04 22:30:42 -06:00
Warner Losh
7a1bef40f1 ustorage_fs_verify: eliminate write only variables file_offset and file_offset
Sponsored by:		Netflix
2022-04-04 22:30:40 -06:00
Warner Losh
f7097359c8 mgue: eliminate write only variables ret, err and error
Sponsored by:		Netflix
2022-04-04 22:30:38 -06:00
Warner Losh
11110685fc cp2112iic_intr_write_callback: eliminate write only variable psc
Sponsored by:		Netflix
2022-04-04 22:30:36 -06:00
Warner Losh
53c1f1fc60 wsp_intr_callback: eliminate write only variable h
Sponsored by:		Netflix
2022-04-04 22:30:33 -06:00
Warner Losh
12312f7583 uss820dci: eliminate unused variables sc, ep_no
Sponsored by:		Netflix
2022-04-04 22:30:31 -06:00
Warner Losh
6ccdcae1b9 uhci_xfer_setup: eliminate write only variable sc
Sponsored by:		Netflix
2022-04-04 22:30:29 -06:00
Warner Losh
ab59cd6a0b musb: eliminate write only variable sc
Sponsored by:		Netflix
2022-04-04 22:30:26 -06:00
Warner Losh
e73b02f66b atmegadci: eliminate unused variables sc, ep_no
Sponsored by:		Netflix
2022-04-04 22:30:23 -06:00
Warner Losh
ad1b7fd714 hdspe_dmapsetmap: eliminate write only variable sc
Sponsored by:		Netflix
2022-04-04 22:30:22 -06:00
Warner Losh
c8fe3923d8 quicc_bus_setsig: eliminate write only variable bas
Sponsored by:		Netflix
2022-04-04 22:30:20 -06:00
Warner Losh
557627dda9 hdaa_eld_dump: eliminate write only variable len
Sponsored by:		Netflix
2022-04-04 22:30:17 -06:00
Warner Losh
8717135d37 emu10kx: eliminate write only variables val, r and move i to loop
Sponsored by:		Netflix
2022-04-04 22:30:13 -06:00
Warner Losh
451f54707a emu10kx-pci: eliminate write only variable r
Sponsored by:		Netflix
2022-04-04 22:30:11 -06:00
Warner Losh
7387abd342 emu_midi_probe: eliminate write only variable r
Sponsored by:		Netflix
2022-04-04 22:30:09 -06:00
Warner Losh
33985865b2 pcmcsa_attach: eliminate write only variable unit
Sponsored by:		Netflix
2022-04-04 22:30:07 -06:00
Warner Losh
3e423419cf midicsa_attach: eliminate write only variable func
Sponsored by:		Netflix
2022-04-04 22:30:06 -06:00
Warner Losh
0c64fe0068 cs4281: eliminate write only variable codecno
Sponsored by:		Netflix
2022-04-04 22:30:04 -06:00
Warner Losh
635a4068d2 sb_probe: eliminate write only variable r
Sponsored by:		Netflix
2022-04-04 22:30:02 -06:00
Warner Losh
668986eae9 sb16_probe: eliminate write only variable r
Sponsored by:		Netflix
2022-04-04 22:30:01 -06:00
Warner Losh
3a7365acc8 ess_probe: eliminate write only variable r
Sponsored by:		Netflix
2022-04-04 22:29:59 -06:00
Warner Losh
c9439e23ce sis_attach: Move waittime definition into for loop
Sponsored by:		Netflix
2022-04-04 22:29:57 -06:00
Warner Losh
94885fbd04 ppc_detect_fifo: eliminate write only variable cc
Sponsored by:		Netflix
2022-04-04 22:29:55 -06:00
Warner Losh
de80fb0ace ppi_probe: eliminate unused variable ppi
Sponsored by:		Netflix
2022-04-04 22:29:53 -06:00
Warner Losh
09b966ee7c Mark cfg as __unused to avoid ifdef soup
Sponsored by:		Netflix
2022-04-04 22:29:51 -06:00
Warner Losh
273676a44c mxge_rss_ethp_z8e_fw_modevent: eliminate write only variable parent
Sponsored by:		Netflix
2022-04-04 22:29:49 -06:00
Warner Losh
5f136a4c01 mxge_rss_eth_z8e_fw_modevent: eliminate write only variable parent
Sponsored by:		Netflix
2022-04-04 22:29:47 -06:00
Warner Losh
886bc93da8 mxge_ethp_z8e_fw_modevent: eliminate write only variable parent
Sponsored by:		Netflix
2022-04-04 22:29:45 -06:00
Warner Losh
498276b4b4 mxge_eth_z8e_fw_modevent: eliminate write only variable parent
Sponsored by:		Netflix
2022-04-04 22:29:43 -06:00
Warner Losh
f8967810f5 mge: eliminate write only variables ifp, sc and error
Sponsored by:		Netflix
2022-04-04 22:29:41 -06:00
Warner Losh
2d4ae2ed36 tmp461_signed_extend32 is unused, remove it
Sponsored by:		Netflix
2022-04-04 22:29:39 -06:00
Warner Losh
875145ffd4 rx8803_settime: remove write only variable bus
Sponsored by:		Netflix
2022-04-04 22:29:38 -06:00