Commit Graph

82 Commits

Author SHA1 Message Date
Kevin Lo
8840ea45ae Add missing braces
Obtained from:	DragonFly
2012-09-12 10:16:39 +00:00
Ed Schouten
902d9eafbf Rework all non-contributed files that use `struct timezone'.
This structure is not part of POSIX. According to POSIX, gettimeofday()
has the following prototype:

	int gettimeofday(struct timeval *restrict tp, void *restrict tzp);

Also, POSIX states that gettimeofday() shall return 0 (as long as tzp is
not used). Remove dead error handling code. Also use NULL for a
nul-pointer instead of integer 0.

While there, change all pieces of code that only use tv_sec to use
time(3), as this provides less overhead.
2012-09-01 14:45:15 +00:00
Eitan Adler
50d675f7a9 Remove trailing whitespace per mdoc lint warning
Disussed with:	gavin
No objection from:	doc
Approved by:	joel
MFC after:	3 days
2012-03-29 05:02:12 +00:00
Kevin Lo
a3a2bf4b67 fgets(3) returns a pointer, so compare against NULL, not integer 0. 2012-01-13 06:51:15 +00:00
Ulrich Spörlein
3df5ecac8c Spelling fixes for usr.sbin/ 2011-12-30 10:58:14 +00:00
Dimitry Andric
5c67a2799c Fix r228719; when you use intmax_t, you need stdint.h.
Pointy hat to:	dim
MFC after:	1 week
2011-12-19 20:33:53 +00:00
Dimitry Andric
655353a78c Some people pointed out long is 32-bit on some arches, while time_t is
64-bit, so better cast time_t to intmax_t, and use the appropriate
printf format strings.

MFC after:	1 week
2011-12-19 20:29:50 +00:00
Dimitry Andric
ad5b59d82c In usr.sbin/timed, fix several issues with printf formats:
- Cast time_t's to long, and print them with %ld.
- Print ptrdiff_t's with %td.
- Print ssize_t's and size_t's with %zd and %zu.
- Print int32_t's with %d.
Also, replace some int variables with the more appropriate size_t.

MFC after:	1 week
2011-12-19 18:08:31 +00:00
Ed Schouten
acd29a915f Simplify inclusion of the tsptype array a bit.
We don't need this array in timed.c -- only readmsg.c.
2011-11-06 16:37:15 +00:00
Simon L. B. Nielsen
1ae2ca130d Check return code of setuid() in timedc.
While it will not fail in normal circumstances, better safe than
sorry.

MFC after:	3 days
2011-04-23 13:57:12 +00:00
Joel Dahl
914e11a72b Remove the advertising clause from UCB copyrighted files in usr.sbin. This
is in accordance with the information provided at
ftp://ftp.cs.berkeley.edu/pub/4bsd/README.Impt.License.Change
2010-12-11 09:38:12 +00:00
Ulrich Spörlein
cded07a878 Move most of the remaining USD/PSD/SMM papers into share/doc 2010-12-04 10:11:20 +00:00
Gavin Atkinson
913a61f799 Initialise the "trials" variable to zero earlier in case we unexpectedly
error out early.

Found by:	clang static analyzer
2010-06-19 17:04:01 +00:00
Ulrich Spörlein
c71e97c47e mdoc: replace troff macros with -mdoc equivalents 2010-06-08 16:48:49 +00:00
Ed Schouten
e4ce5cb26c Port timed away from logwtmp(3). Let it use utmpx. 2010-01-13 18:15:46 +00:00
Ed Schouten
a9d25ec695 Fix LLVM compiler errors related to K&R declarations with ANSI prototypes.
Submitted by:	Pawel Worach <pawel.worach@gmail.com>
2009-02-26 20:59:05 +00:00
Xin LI
6b41097822 Remove spurious duplicated defination of sock. 2008-09-24 00:04:51 +00:00
Warner Losh
047b4ae4cf getopt returns an int, not a char. Make sure that we store the
variable in an int to avoid casting to an unsigned value which causes
the comparison with -1 to fail.

PR:		123807
Submitted by:	Matthew Luckie
Reviewed by:	keramida@
MFC after:	1 week
2008-06-02 04:50:47 +00:00
Remko Lodder
f7769a0c07 Typo fix.
Spotted by:	brueffer
2008-02-11 08:12:58 +00:00
Remko Lodder
d7cb71e0df Enhance descriptions in the timed manual.
PR:		docs/115445
Submitted by:	"Julian Stacey" <jhs at berklix dot org>
MFC After:	3 days
2007-12-08 20:04:15 +00:00
Kevin Lo
784bddbc5b Cleanup of userland __P use 2007-11-07 10:53:41 +00:00
Maxim Konovalov
ba5b74d001 o Remove duplicate includes.
Obtained from:	Slava Semushin via NetBSD
2007-01-20 08:24:02 +00:00
Ruslan Ermilov
59a3c79da6 Sort sections. 2005-01-18 20:02:45 +00:00
Ruslan Ermilov
07bfccd71e Mechanically kill hard sentence breaks. 2004-07-02 23:13:00 +00:00
Johan Karlsson
84d018e017 Fix typo, s/transmitts/transmits/
PR:		62346
Submitted by:	Gavin Atkinson (gavin at ury.york.ac.uk)
2004-02-04 21:59:29 +00:00
Tim J. Robbins
acb85bc034 Fix a BSS buffer overflow caused by makeargv() writing past the end of
margv[] when an input line contains 20 or more space-separated words.
2003-10-11 07:35:35 +00:00
Christian Weisgerber
fc3b13fcee missing word 2003-10-04 15:43:22 +00:00
Christian Weisgerber
c698f34f6c reference ntpd(8) 2003-10-04 15:07:27 +00:00
Christian Weisgerber
9a0e785bba Mark the -i and -n options as mutually exclusive and fix various
mdoc formatting nits.

PR:		57027
Approved by:	simon
Obtained from:	OpenBSD
2003-10-03 00:44:11 +00:00
Philippe Charnier
51f5c480cd de-__P
use port/proto to represent services (not proto/port).
add FBSDID
2003-07-06 10:37:00 +00:00
Warner Losh
87ddbe28e8 Change incorrect strings.h to more correct string.h to pick up
declarations for strlcpy, strlen, strmp and strcpy.
2003-06-09 06:30:36 +00:00
Philippe Charnier
aae2e03571 Add section number to .Xr 2003-06-08 14:33:04 +00:00
Jens Schweikhardt
d64ada501a Fix typos, mostly s/ an / a / where appropriate and a few s/an/and/
Add FreeBSD Id tag where missing.
2002-12-30 21:18:15 +00:00
Philippe Charnier
490d5836b5 The .Nm utility 2002-07-14 14:47:15 +00:00
Robert Drehmel
94fed363fe Use the length modifier 'l' when supplying an argument of
type long to printf(3).
2002-07-11 20:10:07 +00:00
Robert Drehmel
a89c0b2458 - Remove unnecessary inclusion of <utmp.h>.
- Cast a value to time_t before comparing it to another
   time_t to fix a warning.
2002-07-11 20:01:36 +00:00
Tom Rhodes
c896b13a88 timed(8) manual page has some incorrect grammer
PR:	36457
No objections from:	ru
2002-04-09 20:47:17 +00:00
Mike Barcroft
fd8e4ebc8c o Move NTOHL() and associated macros into <sys/param.h>. These are
deprecated in favor of the POSIX-defined lowercase variants.
o Change all occurrences of NTOHL() and associated marcros in the
  source tree to use the lowercase function variants.
o Add missing license bits to sparc64's <machine/endian.h>.
  Approved by: jake
o Clean up <machine/endian.h> files.
o Remove unused __uint16_swap_uint32() from i386's <machine/endian.h>.
o Remove prototypes for non-existent bswapXX() functions.
o Include <machine/endian.h> in <arpa/inet.h> to define the
  POSIX-required ntohl() family of functions.
o Do similar things to expose the ntohl() family in libstand, <netinet/in.h>,
  and <sys/param.h>.
o Prepend underscores to the ntohl() family to help deal with
  complexities associated with having MD (asm and inline) versions, and
  having to prevent exposure of these functions in other headers that
  happen to make use of endian-specific defines.
o Create weak aliases to the canonical function name to help deal with
  third-party software forgetting to include an appropriate header.
o Remove some now unneeded pollution from <sys/types.h>.
o Add missing <arpa/inet.h> includes in userland.

Tested on:	alpha, i386
Reviewed by:	bde, jake, tmm
2002-02-18 20:35:27 +00:00
John Baldwin
9f2b972fdb Unifdef all the SGI code. It mainly added clutter while providing some
specialized logging, SGI-specific priority massaging, and SCI-specific
time trimming support.  Also add missing $FreeBSD$'s.

Inspired by:	NetBSD
2001-11-20 07:13:40 +00:00
John Baldwin
3878fff7db Use fixed-size fields in the structure for the timed protocol. This
includes changing a struct timeval to an explicit structure of two
int32_t's.  This requires using temporary timevals in several places
when calling gettimeofday(), settimeofday(), etc.  With this timed now
works properly on 64-bit platforms such as Alpha.

Obtained from:	NetBSD
2001-11-20 06:36:09 +00:00
Ruslan Ermilov
cda2a9b2f0 Set BINOWN=root explicitly for setuid root binaries.
This is not "useless", as one may have non-default
setting for BINOWN in make.conf, and we still want
these to be installed setuid root in this case.
2001-09-13 06:48:18 +00:00
Kris Kennaway
73c4a23ef2 The timed protocol is not implemented in a compatible way by all vendors;
the size of the tsp_name field is OS-dependent.  4.3BSD used a 32-byte
field, FreeBSD uses MAXHOSTNAMELEN and RedHat apparently uses a 64-byte
field.  As a result, sanity checking code added a few months ago to detect
short packets will fail when interoperating with one of these other vendors.

Change the short packet detection code to expect a minimum packet size
corresponding to the 4.3BSD implementation, which should be a safe minimum
size.

Submitted by:	Stephen Whiteley <stevew@best.com> (based on)
PR:		misc/29867
2001-08-20 06:16:04 +00:00
David E. O'Brien
90e655ea4e Perform a major cleanup of the usr.sbin Makefiles.
These are not perfectly in agreement with each other style-wise, but they
are orders of orders of magnitude more consistent style-wise than before.
2001-07-20 06:20:32 +00:00
Dima Dorfman
f247324df7 Remove whitespace at EOL. 2001-07-15 08:06:20 +00:00
Ruslan Ermilov
a4c37c816b mdoc(7) police: removed HISTORY info from the .Os call. 2001-07-10 15:12:08 +00:00
Kris Kennaway
e58c2d0ce4 Patches from OpenBSD:
- check the msg.tsp_type value prior to using it as an
          index into char *tsptype[]
        - use strlcpy's instead of strcpy's
        - & handle short packets properly.

Submitted by:	"Andrew R. Reiter" <arr@watson.org>
Obtained from:	OpenBSD
2001-05-09 08:37:18 +00:00
Dima Dorfman
19ab52cb4e mdoc(7) police: properly use a -diag list in the DIAGNOSTICS section.
Reviewed by:	ru
2001-04-13 19:59:47 +00:00
Ruslan Ermilov
345e52e742 - Backout botched attempt to introduce MANSECT feature.
- MAN[1-9] -> MAN.
2001-03-26 14:42:20 +00:00
Ruslan Ermilov
c73e22c3d4 Set the default manual section for usr.sbin/ to 8. 2001-03-20 18:17:26 +00:00
Jeroen Ruigrok van der Werven
d1d2ed0e78 Preceed/preceeding are not english words. Use precede and preceding.
Add $FreeBSD$.
2001-02-18 10:44:00 +00:00