Commit Graph

71 Commits

Author SHA1 Message Date
Brooks Davis
f189761366 Fix various -Wpointer-compare warnings
This warning (comparing a pointer against a zero character literal
rather than NULL) has existed since GCC 7.1.0, and was recently added to
Clang trunk.

Almost all of these are harmless, except for fwcontrol's str2node, which
needs to both guard against dereferencing a NULL pointer (though in
practice it appears none of the callers will ever pass one in), as well
as ensure it doesn't parse the empty string as node 0 due to strtol's
awkward interface.

Submitted by:	James Clarke <jtrc27@jrtc27.com>
Obtained from:	CheriBSD
Sponsored by:	DARPA, AFRL
Differential Revision:	https://reviews.freebsd.org/D21914
2019-10-08 21:14:09 +00:00
Warner Losh
53584cf69c Don't close fd twice. This line should have been deleted in r327279.
CID: 1384015
2018-01-05 05:34:20 +00:00
Warner Losh
d8dfc65f43 Close fd when we're done dv-sending the file.
CID: 978413
2017-12-28 05:34:38 +00:00
Pedro F. Giffuni
df57947f08 spdx: initial adoption of licensing ID tags.
The Software Package Data Exchange (SPDX) group provides a specification
to make it easier for automated tools to detect and summarize well known
opensource licenses. We are gradually adopting the specification, noting
that the tags are considered only advisory and do not, in any way,
superceed or replace the license texts.

Special thanks to Wind River for providing access to "The Duke of
Highlander" tool: an older (2014) run over FreeBSD tree was useful as a
starting point.

Initially, only tag files that use BSD 4-Clause "Original" license.

RelNotes:	yes
Differential Revision:	https://reviews.freebsd.org/D13133
2017-11-18 14:26:50 +00:00
Bryan Drewery
ea825d0274 DIRDEPS_BUILD: Update dependencies.
Sponsored by:	Dell EMC Isilon
2017-10-31 00:07:04 +00:00
Enji Cooper
64a0982bee usr.sbin: normalize paths using SRCTOP-relative paths or :H when possible
This simplifies make logic/output

MFC after:	1 month
Sponsored by:	Dell EMC Isilon
2017-03-04 11:38:03 +00:00
Eitan Adler
463a577b27 Fix a ton of speelling errors
arc lint is helpful

Reviewed By: allanjude, wblock, #manpages, chris@bsdjunk.com
Differential Revision: https://reviews.freebsd.org/D3337
2015-10-21 05:37:09 +00:00
Simon J. Gerraty
ccfb965433 Add META_MODE support.
Off by default, build behaves normally.
WITH_META_MODE we get auto objdir creation, the ability to
start build from anywhere in the tree.

Still need to add real targets under targets/ to build packages.

Differential Revision:       D2796
Reviewed by: brooks imp
2015-06-13 19:20:56 +00:00
Simon J. Gerraty
44d314f704 dirdeps.mk now sets DEP_RELDIR 2015-06-08 23:35:17 +00:00
Simon J. Gerraty
ee7b0571c2 Merge head from 7/28 2014-08-19 06:50:54 +00:00
Baptiste Daroussin
01c2b8ac0d use .Mt to mark up email addresses consistently (part2)
PR:		191174
Submitted by:	Franco Fichtner  <franco@lastsummer.de>
2014-06-20 09:57:27 +00:00
Simon J. Gerraty
fae50821ae Updated dependencies 2014-05-16 14:09:51 +00:00
Simon J. Gerraty
76b28ad6ab Updated dependencies 2014-05-10 05:16:28 +00:00
Simon J. Gerraty
7cf3a1c6b2 Updated dependencies 2013-03-11 17:21:52 +00:00
Simon J. Gerraty
f5f7c05209 Updated dependencies 2013-02-16 01:23:54 +00:00
Simon J. Gerraty
23090366f7 Sync from head 2012-11-04 02:52:03 +00:00
Marcel Moolenaar
7750ad47a9 Sync FreeBSD's bmake branch with Juniper's internal bmake branch.
Requested by: Simon Gerraty <sjg@juniper.net>
2012-08-22 19:25:57 +00:00
Joel Dahl
e1656a8810 mdoc: add missing width argument to Bl -tag. 2012-06-03 06:57:47 +00:00
Joel Dahl
c2965cd185 mdoc: terminate quoted strings.
Reviewed by:	brueffer
2012-03-26 15:18:14 +00:00
Ulrich Spörlein
3df5ecac8c Spelling fixes for usr.sbin/ 2011-12-30 10:58:14 +00:00
Eitan Adler
520374b5aa - Remove extraneous null ptr deref checks
- Fix memory leak

Submitted by:	Slono Slono <slonoman2011@yandex.ru>
Approved by:	jhb
MFC after:	1 week
2011-12-21 20:27:41 +00:00
Ed Maste
0737626a7f Quiet clang warnings by using literal format strings for printf-like
functions.
2011-01-04 02:52:22 +00:00
Kevin Lo
f55df2a221 Closing fd when it's done
Reviewed by:	sbruno
2010-12-09 08:36:23 +00:00
Joel Dahl
d4352d2928 Spelling fixes. 2010-08-01 09:37:36 +00:00
Ulrich Spörlein
47e1a877c5 Always assign WARNS using ?=
- fix some nearby style bugs
- include Makefile.inc where it makes sense and reduces duplication

Approved by:	ed (co-mentor)
2010-03-02 16:58:04 +00:00
Sean Bruno
cde9186f93 Remove reference to phy_delay from fwcontrol. Thanks for the catch!
Submitted by:	Giorgos Keramidas <keramida@ceid.upatras.gr>
MFC after:	2 weeks
2009-02-17 23:56:16 +00:00
Sean Bruno
e627b033dc Begin basic improvements to fwcontrol in the area of handling
video streams from cameras.

This patch changes the displayed timer to a time stamp and corrects
one or two mishandled errors.

Submitted by:	imp
2009-02-02 21:05:12 +00:00
Warner Losh
96747dc015 Add fd = -1 after close when we detect the format so that subsequent
open_dev will reopen the device.
2009-01-02 08:21:21 +00:00
Sean Bruno
c1de48a3d2 Reviewed by: (Dieter)freebsd@sopwith.solgatos.com
Approved by:	slong scottl@samsco.org
MFC after:	2 weeks

Final cleanup of fwcontrol.
  NetBSD compatibility
  Cleanup errors in usage() display
  Finish up error handling via errx/warnx
  Generate error on unparsed command line syntax
  Change device(devbase) to open into the form /dev/fwX.X
2008-12-12 18:17:23 +00:00
Daniel Gerzo
2cdb71a94a Sweep this man page a bit:
- new sentence = new line
- use .Dq macro to quote words
- some minor rewording

MFC after:	2 weeks
2008-09-11 22:11:41 +00:00
Sean Bruno
7f1b527c00 Beginning of overhaul of fwcontrol:
-  Documentation of send_phy_config()
-  cleanup of malloc's() and added error checking throughout
-  new capability to iterate over multiple firewire buses
-  update usage() display
-  cleanup command line parsing to allow out of order switches
-  cleanup command line parsing to allow multiple switches per invocation
-  cleanup grammar of man page a bit
-  add some ranges to the man page to indicate what values are valid

Since fwcontrol's code is the same across 6/7/head this can be
applied to all branches after the MFC period.

Reviewed by:	Dieter freebsd@sopwith.solgatos.com
Approved by:	mentor Scott scottl@samsco.org
MFC after:	60 days
2008-09-10 18:09:52 +00:00
Hidetoshi Shimokawa
302176c71f - add '-f' option to force root node.
- fix byte order in read_write_quad()
- show hostnames in the list
- fix typo in manpage

MFC after: 1 week
2008-03-05 01:30:48 +00:00
Christian Brueffer
0297fef065 Remove dublicate .Pp, sort SEE ALSO. 2007-10-31 05:59:17 +00:00
Giorgos Keramidas
e6039c36f0 Whitespace-only change: trim EOL spaces. 2007-10-30 16:08:06 +00:00
Giorgos Keramidas
9aeec3c7db mdoc warning fix: delete spurious empty line.
MFC after:	3 days
2007-10-30 16:06:48 +00:00
Hidetoshi Shimokawa
072d350754 Increase buffer size of DV stream to prevent buffer
overrun caused by long blocking of file I/O (i.e. zfs).

MFC after: 3 days
2007-06-17 10:20:55 +00:00
Yaroslav Tykhiy
9b3d1b0253 Fix a group of typos:
preceed -> precede,
preceeded -> preceded,
preceeding -> preceding.

Submitted by:	Andre Guibert de Bruet <andy@siliconlandmark.com>
2006-12-29 13:08:46 +00:00
Warner Losh
6d815a7d8c Add MPEG2-TS/HDV support to fwcontrol.
Submitted by: Petr Holub" <hopet@ics.muni.cz>
Clean up by: mi@
Pr: 98134
2006-10-26 22:33:38 +00:00
Philippe Charnier
3fe9d89a62 Remove unused variables. Shorten the path to a WARNS=6 compliance. 2005-05-20 12:50:47 +00:00
Ruslan Ermilov
59a3c79da6 Sort sections. 2005-01-18 20:02:45 +00:00
Ruslan Ermilov
1a74e6a157 Scheduled mdoc(7) sweep. 2005-01-11 11:47:22 +00:00
Christian Brueffer
eb1b84fe40 - Xref fwip(4)
- bump .Dd

MFC after:	3 days
2004-12-14 20:44:37 +00:00
Hidetoshi Shimokawa
f62482315a Add usage of -m option. 2004-10-29 01:24:32 +00:00
Hidetoshi Shimokawa
1be7387c03 Add -m option, set default fwmem target. 2004-10-23 23:28:08 +00:00
Ruslan Ermilov
800b8436b0 Nit. 2004-06-04 19:23:39 +00:00
Brooks Davis
cb5df0b27b Use new eui64(3) functions to print EUI-64s and to allow access to nodes
by EUI-64 and name.

Reviewed by:	simokawa
2004-05-26 22:59:55 +00:00
Doug Rabson
3d7b1b4143 Don't crash if the CROM is all zeros. 2004-05-23 10:06:33 +00:00
Christian Brueffer
0270455437 o grammar fixes
o wordsmithing
o s/isochronus/isochronous/

MFC after:	5 days
2003-12-17 10:14:11 +00:00
Hidetoshi Shimokawa
cfa42d3692 Add '0x' in front of EUI64 to avoid confusion. 2003-10-22 07:23:27 +00:00
Hidetoshi Shimokawa
a8587980d8 Add -p option to dump phy registers. 2003-09-25 09:33:16 +00:00