Commit Graph

39 Commits

Author SHA1 Message Date
Maxim Sobolev
6122c0cd5e o Fix semantics of comparison function for qsort(3). According to qsort(3)
manpage:

     The comparison function must return an integer less than, equal to, or
     greater than zero if the first argument is considered to be respectively
     less than, equal to, or greater than the second.

  Therefore, simply returning "arg1 > arg2" is incorrect. Actually it works
  but for the number of items to be sorted less than 7 due to special case
  handling in qsort(3);

o add missing '\n' to one of usage() calls.

Approved by:	phk
2004-06-25 13:04:49 +00:00
Christian Brueffer
9a6a20eeff Fix typo
Submitted by:	edwin
2004-05-23 08:40:52 +00:00
Ruslan Ermilov
d04b5dfe6c Assorted markup, grammar, and spelling fixes. 2004-05-17 08:35:43 +00:00
Poul-Henning Kamp
97d2ca7830 Fix the last and most important bit of the test case to test the same
binary as the rest of it.

Add MD5 check that the md(4) device gets set up correctly.
2004-02-07 22:58:39 +00:00
Dag-Erling Smørgrav
fef1e56d1e Don't create a template file if we're not going to let the user edit it. 2004-02-05 10:57:29 +00:00
Pawel Jakub Dawidek
0cd7b33bf3 Fixed some non-critical memory leaks and one temporary file leak
(theoretical).

Approved by:	phk, scottl (mentor)
2004-02-05 08:39:38 +00:00
Dag-Erling Smørgrav
3678ea800f Mechanical whitespace cleanup. Also, note that previous commit was
Sponsored by:	Teleplan AS
2004-02-03 11:12:29 +00:00
Dag-Erling Smørgrav
efdda83ea8 Remove newline characters from error strings. 2004-02-03 11:10:34 +00:00
Poul-Henning Kamp
1510356035 Clarify that the encrypted device is called foo.bde and mention that
unmounting it before detaching GBDE is a good idea.

Insisted on by:	Flemming Jacobsen <fj@batmule.dk>
Approveed by:	re@
2003-11-27 20:54:51 +00:00
Poul-Henning Kamp
2925fa2283 Make the regression test run also with obj directories. 2003-10-17 19:52:07 +00:00
Poul-Henning Kamp
b6badb5a54 Insert an overview of the plans here, in case I get run over by a bus. 2003-10-13 20:14:02 +00:00
Poul-Henning Kamp
fc36082a22 I think it is more correct to use modfind() than kldfind() here. 2003-10-10 14:32:28 +00:00
Poul-Henning Kamp
f1b9e7798d Improve regression test with an image file which must work. 2003-10-07 09:31:51 +00:00
Poul-Henning Kamp
ad3cb316b3 Autoload kernel module if necessary.
Submitted by:	mr
2003-10-07 09:29:59 +00:00
Poul-Henning Kamp
f4db0cbe58 Interior decoration changes. 2003-10-07 09:28:07 +00:00
Poul-Henning Kamp
83d771de78 Simplify the GEOM OAM api: Drop the request type, and let everything
hinge on the "verb" parameter which the class gets to interpret as
it sees fit.

Move the entire request into the kernel and move changed parameters
back when done.
2003-06-01 13:47:51 +00:00
Ruslan Ermilov
0b00d54eed Moved libgeom.so dependencies to where they belong.
Reviewed by:	phk
Approved by:	re (scottl)
2003-05-17 19:05:17 +00:00
Ruslan Ermilov
5ea3e23965 Normalize, fix ``make checkdpadd''. 2003-04-16 11:54:11 +00:00
Poul-Henning Kamp
ddc6ffdccf Avoid off_t -> integer overflow when sorting the locksector addresses. 2003-04-14 09:36:39 +00:00
Poul-Henning Kamp
1e01677906 Don't pull in geom_enc.c any more. 2003-04-03 12:36:56 +00:00
Poul-Henning Kamp
8b3ee9cd3b Use new GEOM OAM. Kernels have supported this for a number of days, so
people should be OK.
2003-03-31 18:38:31 +00:00
Poul-Henning Kamp
5a42be36e3 Remove reference to unavailable paper. 2003-03-07 09:36:58 +00:00
Tim J. Robbins
73657eba91 Fix two unsafe uses of sprintf(). 2003-02-23 07:37:47 +00:00
Tim J. Robbins
bdd64bca36 Correct some err() format string bugs. 2003-02-23 06:35:33 +00:00
Poul-Henning Kamp
1e90b74683 Solve another bug in the mapping code: correctly skip lock sectors.
Make sure sector zero is protected if it contains metadata.

Lower WARNS for gbde to 3 on non-i386 archs.  rijndael-fst is evil
but appearntly does the right thing and passes the test-vectors.

MFC Candidate.
2002-12-18 22:11:54 +00:00
Poul-Henning Kamp
88806cc28c Fix two blunders in the mapping functions which can lead to corrupt data,
for request sizes larger than the sectorsize or for multi-key setups.

See warning mailed to current@ for details of recovery.

Found by:	Marcus Reid <marcus@blazingdot.com>
2002-12-18 19:57:27 +00:00
Poul-Henning Kamp
c6e3e82803 Untwist a twisty bit of logic which gcc for some reason cannot see
through on ia64.
2002-12-18 07:25:33 +00:00
Poul-Henning Kamp
62998d5574 A couple of stylistic improvements. 2002-12-17 19:16:10 +00:00
Ruslan Ermilov
7faa4ab461 mdoc(7) police: markup overhaul.
Approved by:	re
2002-12-12 08:53:20 +00:00
Poul-Henning Kamp
725490c68f Synchronize usage() with reality.
Semi-automatic handling of /dev prefix for device names.

Sponsored by:	DARPA & NAI Labs.
Approved by:	re (blanket)
2002-12-01 15:58:28 +00:00
Poul-Henning Kamp
03e58f67ae De-danglify the manual page.
Submitted by:	ceri
Approved by:	re (blanket)
2002-12-01 15:57:02 +00:00
Chris Costello
f0732370dd o Bring the NOTICE section into the DESCRIPTION section and wrap it in
.Bf -emphasis ... .Ef
o Grammar/spelling

Sponsored by:	DARPA, NAI Labs
2002-11-18 22:56:41 +00:00
Poul-Henning Kamp
5afa461402 Run a revision on the GBDE encryption facility.
Replace ARC4 with SHA2-512.
Change lock-structure encoding to use random ordering rather for obscurity.
Encrypt lock-structure with AES/256 instead of AES/128.
Change kkey derivation to be MD5 hash based.
Watch for malloc(M_NOWAIT) failures and ditch our cache when they happen.
Remove clause 3 of the license with NAI Labs consent.

Many thanks to "Lucky Green" <shamrock@cypherpunks.to> and "David
Wagner" <daw@cs.berkeley.edu>, for code reading, inputs and
suggestions.

This code has still not been stared at for 10 years by a gang of
hard-core cryptographers.  Discretion advised.

NB: These changes result in the on-disk format changing: dump/restore needed.

Sponsored by:   DARPA & NAI Labs.
2002-11-04 09:27:01 +00:00
Poul-Henning Kamp
ab4be8c231 Initialize the new salt field in the lock sector.
Sponsored by:	DARPA & NAI Labs
2002-10-30 22:14:34 +00:00
Poul-Henning Kamp
936f458807 I overlooked an absolute path.
Submitted by:	Henric Jungheim <henric@attbi.com>
2002-10-21 05:25:02 +00:00
Chris Costello
aa77750747 o Use .Cm for 'attach', 'detach', 'init', 'setkey', and 'destroy' commands
o Fix some punctuation and wording
o Wording consistency in command-line option documentation
o Make use of mdoc's markup a bit more (quoting and the like)

Obtained from:	TrustedBSD Project
Sponsored by:	DARPA, NAI Labs
2002-10-20 19:20:26 +00:00
Poul-Henning Kamp
930f6f2f6d s/dettach/detach/g etc.
Pointed out by:	chris
2002-10-20 19:08:56 +00:00
Poul-Henning Kamp
fa5dbec89f Use .PATH instead of VPATH.
Fix typo in man-page: man-section is 8.
2002-10-20 15:02:26 +00:00
Poul-Henning Kamp
d220f5beb9 Complete the Geom Based Disk Encryption: Add the OAM utility.
Sponsored by:	DARPA and NAI Labs
2002-10-20 11:16:13 +00:00