04622a7f21
Previously the code set TWSI_CONTROL_ACK in twsi_transfer() based on whether the first message had a length of one. That was done regardless of whether the message was a read or write and what kind of messages followed it. Now the bit is set or cleared while handling TWSI_STATUS_ADDR_R_ACK state transition based on the current (read) message. The old code did not correctly work in a scenario where a single byte was read from an EEPROM device with two byte addressing. For example: i2c -m tr -a 0x50 -d r -w 16 -o 0 -c 1 -v The reason is that the first message (a write) has two bytes, so TWSI_CONTROL_ACK was set and never cleared. Since the controller did not send NACK the EEPROM sent more data resulting in a buffer overrun. While working on TWSI_STATUS_ADDR_R_ACK I also added support for the zero-length read access and then I did the same for zero-length write access. While rare, those types of I2C transactions are completely valid and are used by some devices. PR: 258994 MFC after: 3 weeks |
||
---|---|---|
.. | ||
gpio | ||
mux | ||
pmic | ||
rtc | ||
twsi | ||
acpi_iicbus.c | ||
ad7417.c | ||
ad7418.c | ||
adm1030.c | ||
ads111x.c | ||
adt746x.c | ||
ds13rtc.c | ||
ds1307.c | ||
ds1307reg.h | ||
ds1631.c | ||
ds1672.c | ||
ds1775.c | ||
ds3231.c | ||
ds3231reg.h | ||
htu21.c | ||
icee.c | ||
if_ic.c | ||
iic_recover_bus.c | ||
iic_recover_bus.h | ||
iic.c | ||
iic.h | ||
iicbb_if.m | ||
iicbb.c | ||
iicbus_if.m | ||
iicbus.c | ||
iicbus.h | ||
iichid.c | ||
iicoc_fdt.c | ||
iicoc_pci.c | ||
iicoc.c | ||
iicoc.h | ||
iiconf.c | ||
iiconf.h | ||
iicsmb.c | ||
isl12xx.c | ||
lm75.c | ||
max6690.c | ||
max44009.c | ||
nxprtc.c | ||
ofw_iicbus.c | ||
pcf8591.c | ||
rtc8583.c | ||
s35390a.c | ||
sy8106a.c | ||
syr827.c |