34a5582c47
Redirect (and temporal) route expiration was broken a while ago. This change brings route expiration back, with unified IPv4/IPv6 handling code. It introduces net.inet.icmp.redirtimeout sysctl, allowing to set an expiration time for redirected routes. It defaults to 10 minutes, analogues with net.inet6.icmp6.redirtimeout. Implementation uses separate file, route_temporal.c, as route.c is already bloated with tons of different functions. Internally, expiration is implemented as an per-rnh callout scheduled when route with non-zero rt_expire time is added or rt_expire is changed. It does not add any overhead when no temporal routes are present. Callout traverses entire routing tree under wlock, scheduling expired routes for deletion and calculating the next time it needs to be run. The rationale for such implemention is the following: typically workloads requiring large amount of routes have redirects turned off already, while the systems with small amount of routes will not inhibit large overhead during tree traversal. This changes also fixes netstat -rn display of route expiration time, which has been broken since the conversion from kread() to sysctl. Reviewed by: bz MFC after: 3 weeks Differential Revision: https://reviews.freebsd.org/D23075
162 lines
4.2 KiB
C
162 lines
4.2 KiB
C
/*-
|
|
* SPDX-License-Identifier: BSD-2-Clause-FreeBSD
|
|
*
|
|
* Copyright (c) 2020 Alexander V. Chernikov
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
|
|
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*/
|
|
|
|
/*
|
|
* This file contains code responsible for expiring temporal routes
|
|
* (typically, redirect-originated) from the route tables.
|
|
*/
|
|
|
|
#include <sys/cdefs.h>
|
|
__FBSDID("$FreeBSD$");
|
|
|
|
#include <sys/param.h>
|
|
#include <sys/systm.h>
|
|
#include <sys/socket.h>
|
|
#include <sys/kernel.h>
|
|
#include <sys/lock.h>
|
|
#include <sys/rmlock.h>
|
|
#include <sys/callout.h>
|
|
|
|
#include <net/if.h>
|
|
#include <net/route.h>
|
|
#include <net/route_var.h>
|
|
#include <net/vnet.h>
|
|
|
|
/*
|
|
* Callback returning 1 for the expired routes.
|
|
* Updates time of the next nearest route expiration as a side effect.
|
|
*/
|
|
static int
|
|
expire_route(const struct rtentry *rt, void *arg)
|
|
{
|
|
time_t *next_callout;
|
|
|
|
if (rt->rt_expire == 0)
|
|
return (0);
|
|
|
|
if (rt->rt_expire <= time_uptime)
|
|
return (1);
|
|
|
|
next_callout = (time_t *)arg;
|
|
|
|
/*
|
|
* Update next_callout to determine the next ts to
|
|
* run the callback at.
|
|
*/
|
|
if (*next_callout == 0 || *next_callout > rt->rt_expire)
|
|
*next_callout = rt->rt_expire;
|
|
|
|
return (0);
|
|
}
|
|
|
|
/*
|
|
* Per-rnh callout function traversing the tree and deleting
|
|
* expired routes. Calculates next callout run by looking at
|
|
* the rt_expire time for the remaining temporal routes.
|
|
*/
|
|
static void
|
|
expire_callout(void *arg)
|
|
{
|
|
struct rib_head *rnh;
|
|
time_t next_expire;
|
|
int seconds;
|
|
|
|
rnh = (struct rib_head *)arg;
|
|
|
|
CURVNET_SET(rnh->rib_vnet);
|
|
next_expire = 0;
|
|
|
|
rib_walk_del(rnh->rib_fibnum, rnh->rib_family, expire_route,
|
|
(void *)&next_expire, 1);
|
|
|
|
RIB_WLOCK(rnh);
|
|
if (next_expire > 0) {
|
|
seconds = (next_expire - time_uptime);
|
|
if (seconds < 0)
|
|
seconds = 0;
|
|
callout_reset_sbt(&rnh->expire_callout, SBT_1S * seconds,
|
|
SBT_1MS * 500, expire_callout, rnh, 0);
|
|
rnh->next_expire = next_expire;
|
|
} else {
|
|
/*
|
|
* Before resetting next_expire, check that tmproutes_update()
|
|
* has not kicked in and scheduled another invocation.
|
|
*/
|
|
if (callout_pending(&rnh->expire_callout) == 0)
|
|
rnh->next_expire = 0;
|
|
}
|
|
RIB_WUNLOCK(rnh);
|
|
CURVNET_RESTORE();
|
|
}
|
|
|
|
/*
|
|
* Function responsible for updating the time of the next calllout
|
|
* w.r.t. new temporal routes insertion.
|
|
*
|
|
* Called by the routing code upon adding new temporal route
|
|
* to the tree. RIB_WLOCK must be held.
|
|
*/
|
|
void
|
|
tmproutes_update(struct rib_head *rnh, struct rtentry *rt)
|
|
{
|
|
int seconds;
|
|
|
|
RIB_WLOCK_ASSERT(rnh);
|
|
|
|
if (rnh->next_expire == 0 || rnh->next_expire > rt->rt_expire) {
|
|
/*
|
|
* Callback is not scheduled, is executing,
|
|
* or is scheduled for a later time than we need.
|
|
*
|
|
* Schedule the one for the current @rt expiration time.
|
|
*/
|
|
seconds = (rt->rt_expire - time_uptime);
|
|
if (seconds < 0)
|
|
seconds = 0;
|
|
callout_reset_sbt(&rnh->expire_callout, SBT_1S * seconds,
|
|
SBT_1MS * 500, expire_callout, rnh, 0);
|
|
|
|
rnh->next_expire = rt->rt_expire;
|
|
}
|
|
}
|
|
|
|
void
|
|
tmproutes_init(struct rib_head *rh)
|
|
{
|
|
|
|
callout_init(&rh->expire_callout, 1);
|
|
}
|
|
|
|
|
|
void
|
|
tmproutes_destroy(struct rib_head *rh)
|
|
{
|
|
|
|
callout_drain(&rh->expire_callout);
|
|
}
|
|
|