Don Lewis 12be18c7d5 Fix a race condition between the main thread in aqm_pie_cleanup() and the ... callout thread that can cause a kernel panic. Always do the final cleanup in the callout thread by passing a separate callout function for that task to callout_reset_sbt(). Protect the ref_count decrement in the callout with DN_BH_WLOCK(). All other ref_count manipulation is protected with this lock. There is still a tiny window between ref_count reaching zero and the end of the callout function where it is unsafe to unload the module. Fixing this would require the use of callout_drain(), but this can't be done because dummynet holds a mutex and callout_drain() might sleep. Remove the callout_pending(), callout_active(), and callout_deactivate() calls from calculate_drop_prob(). They are not needed because this callout uses callout_init_mtx(). Submitted by: Rasool Al-Saadi <ralsaadi@swin.edu.au> Approved by: re (gjb) MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D6928		2016-07-05 00:53:01 +00:00
..
ipfw	Fix a race condition between the main thread in aqm_pie_cleanup() and the	2016-07-05 00:53:01 +00:00
pf	The void isn't void.	2016-06-24 11:53:12 +00:00