FreeBSD src
Go to file
Adrian Chadd 2172664c4b [net80211] Use the unicast key when transmitting DWDS AP multicast frames.
I'm still not sure whether this is the full solution, but here goes.

I have a two node DWDS setup - a main AP with the ethernet bridge uplink
and a satellite AP in the back of the house. They're both AR9344+AR9580
dual band 11n APs.

The problem was that multicast frames was not going from the DWDS AP to
the DWDS STA. Unicast frames are fine, and multicast frames from the
DWDS STA to AP are fine.

Now, multicast and unicast frames from the STA -> AP are just transmitted
using the unicast key.  That's fine.  However, the AP -> STA multicast
frames by default are transmitted using the current default / multicast
key, the shared one between all STAs in a BSS.  Now, the DWDS implementation
ignores non WDS frames - it only allows about 4 address frames outside
of management / EAPOL frames! - so the STA side ignores the normal multicast
frames.

Instead, the AP side uses ieee80211_dwds_mcast() to send multicast frames
to each WDS VAP that was created as part of the "dynamic" part of DWDS.
This should be queuing them individually to each node instead of using
the normal multicast send path; and this is how they should get turned into
4-addr WDS frames.

HOWEVER, ieee80211_encap() was trying to use the default TX key to queue
them rather than the unicast key that's already setup.  Since this synthetic
node doesn't have the default TX key setup, transmission fails.  Things
would be fine in WEP and in open mode because in both cases you would
have static keys (or no keys) setup.  It just fails in WPA mode.

This resolves the issue.  AP DWDS multicast is now sent using the unicast
key just like in STA mode and I'm pretty sure the STA mode side will stil
work fine (as it's a STA VAP with a DWDS flag..)

Tested:

* TL-WDR3600/4300 APs
2020-05-08 17:01:33 +00:00
bin ps: extend the non-standard option -d (tree view) to work with -p 2020-05-07 16:56:18 +00:00
cddl dtrace tests: Support globbing for excludes 2020-04-29 21:12:32 +00:00
contrib Merge commit 21e5e1724b75 from llvm git: 2020-05-07 21:18:37 +00:00
crypto Merge OpenSSL 1.1.1g. 2020-04-21 19:38:32 +00:00
etc Introduce nexthop objects and new routing KPI. 2020-04-12 14:30:00 +00:00
gnu binutils: disconnect objdump from the build 2020-05-06 18:38:40 +00:00
include Import OpenSSL 1.1.1g. 2020-04-21 19:07:46 +00:00
kerberos5 Update Makefile.depend files 2019-12-11 17:37:53 +00:00
lib Add HISTORY sections to document when this 2020-05-05 19:31:47 +00:00
libexec Move ARM specific flags to arm/Makefile.inc 2020-04-29 16:05:50 +00:00
release Set use_nvd=0 in EC2 AMIs. 2020-04-27 21:44:02 +00:00
rescue rescue: Remove useless linking with libl 2020-03-24 07:08:02 +00:00
sbin Add RFC reference for AES-CTR with IPsec. 2020-05-04 16:50:01 +00:00
secure Merge OpenSSL 1.1.1g. 2020-04-21 19:38:32 +00:00
share src.conf.5: regen after BINUTILS changes 2020-05-08 15:03:28 +00:00
stand Fix the EFI_DEBUG case, prio_str is only used when EFI_DEBUG is unset. 2020-05-05 10:01:10 +00:00
sys [net80211] Use the unicast key when transmitting DWDS AP multicast frames. 2020-05-08 17:01:33 +00:00
targets retire in-tree GPL dtc devicetree compiler 2020-02-29 17:10:54 +00:00
tests Fix the sys.geom.class.multipath.misc.fail_on_error test on stable/12 2020-05-08 02:42:15 +00:00
tools OptionalObsoleteFiles.inc: remove objdump 2020-05-07 18:24:32 +00:00
usr.bin elfctl: update earliest FreeBSD revision to 12.2 2020-05-05 21:50:52 +00:00
usr.sbin Document le_enable subcommand 2020-05-08 01:19:29 +00:00
.arcconfig callsign isn't required anymore 2016-09-29 06:19:45 +00:00
.arclint arc lint: ignore /tests/ in chmod 2017-12-19 03:38:06 +00:00
.cirrus.yml Cirrus-CI: increase timeout to 120m 2020-02-19 15:56:40 +00:00
.clang-format Add a basic clang-format configuration file 2019-06-07 15:23:52 +00:00
.gitattributes Add a basic clang-format configuration file 2019-06-07 15:23:52 +00:00
.gitignore Import the kyua testing framework for infrastructure software 2020-03-17 16:56:50 +00:00
COPYRIGHT Happy New Year 2020! 2019-12-31 16:01:36 +00:00
LOCKS LOCKS: update current locks 2018-06-09 03:08:04 +00:00
MAINTAINERS Move all sources from the llvm project into contrib/llvm-project. 2019-12-20 19:53:05 +00:00
Makefile Use universe-toolchain config(8) 2020-04-29 02:18:39 +00:00
Makefile.inc1 Fix race between prebuilding libsbuf and libgeom 2020-04-25 20:24:41 +00:00
Makefile.libcompat Stop building libl and liby 2020-03-26 08:23:09 +00:00
Makefile.sys.inc AUTO_OBJ: For all top-level targets enforce using an OBJDIR. 2017-12-05 21:29:47 +00:00
ObsoleteFiles.inc binutils: disconnect objdump from the build 2020-05-06 18:38:40 +00:00
README Import OpenSSL 1.1.1g. 2020-04-21 19:07:46 +00:00
README.md Import the kyua testing framework for infrastructure software 2020-03-17 16:56:50 +00:00
RELNOTES Document removal of deprecated algorithms from /dev/crypto. 2020-05-02 14:23:55 +00:00
UPDATING UPDATING: Fix the date of the closefrom(2) entry 2020-04-24 12:57:03 +00:00

FreeBSD Source:

This is the top level of the FreeBSD source directory. This file was last revised on: FreeBSD

FreeBSD is an operating system used to power modern servers, desktops, and embedded platforms. A large community has continually developed it for more than thirty years. Its advanced networking, security, and storage features have made FreeBSD the platform of choice for many of the busiest web sites and most pervasive embedded networking and storage devices.

For copyright information, please see the file COPYRIGHT in this directory. Additional copyright information also exists for some sources in this tree - please see the specific source directories for more information.

The Makefile in this directory supports a number of targets for building components (or all) of the FreeBSD source tree. See build(7), config(8), https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/makeworld.html, and https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/kernelconfig.html for more information, including setting make(1) variables.

Source Roadmap:

bin		System/user commands.

cddl		Various commands and libraries under the Common Development
		and Distribution License.

contrib		Packages contributed by 3rd parties.

crypto		Cryptography stuff (see crypto/README).

etc		Template files for /etc.

gnu		Various commands and libraries under the GNU Public License.
		Please see gnu/COPYING* for more information.

include		System include files.

kerberos5	Kerberos5 (Heimdal) package.

lib		System libraries.

libexec		System daemons.

release		Release building Makefile & associated tools.

rescue		Build system for statically linked /rescue utilities.

sbin		System commands.

secure		Cryptographic libraries and commands.

share		Shared resources.

stand		Boot loader sources.

sys		Kernel sources.

sys/<arch>/conf Kernel configuration files. GENERIC is the configuration
		used in release builds. NOTES contains documentation of
		all possible entries.

tests		Regression tests which can be run by Kyua.  See tests/README
		for additional information.

tools		Utilities for regression testing and miscellaneous tasks.

usr.bin		User commands.

usr.sbin	System administration commands.

For information on synchronizing your source tree with one or more of the FreeBSD Project's development branches, please see:

https://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/current-stable.html