0a7b460e70
The existing code in zmount incorrectly parses the comma-delimited option string. The result is that nmount only honors the last option. AFAICT the parsing has been broken ever since ZFS's initial import in change 168404. PR: 222078 Reviewed by: avg MFC after: 3 weeks Sponsored by: Spectra Logic Corp Differential Revision: https://reviews.freebsd.org/D12232
107 lines
3.1 KiB
C
107 lines
3.1 KiB
C
/*-
|
|
* Copyright (c) 2006 Pawel Jakub Dawidek <pjd@FreeBSD.org>
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHORS AND CONTRIBUTORS ``AS IS'' AND
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHORS OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
|
|
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*/
|
|
|
|
/*
|
|
* This file implements Solaris compatible zmount() function.
|
|
*/
|
|
|
|
#include <sys/cdefs.h>
|
|
__FBSDID("$FreeBSD$");
|
|
|
|
#include <sys/param.h>
|
|
#include <sys/mount.h>
|
|
#include <sys/uio.h>
|
|
#include <sys/mntent.h>
|
|
#include <assert.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <mnttab.h>
|
|
|
|
static void
|
|
build_iovec(struct iovec **iov, int *iovlen, const char *name, void *val,
|
|
size_t len)
|
|
{
|
|
int i;
|
|
|
|
if (*iovlen < 0)
|
|
return;
|
|
i = *iovlen;
|
|
*iov = realloc(*iov, sizeof(**iov) * (i + 2));
|
|
if (*iov == NULL) {
|
|
*iovlen = -1;
|
|
return;
|
|
}
|
|
(*iov)[i].iov_base = strdup(name);
|
|
(*iov)[i].iov_len = strlen(name) + 1;
|
|
i++;
|
|
(*iov)[i].iov_base = val;
|
|
if (len == (size_t)-1) {
|
|
if (val != NULL)
|
|
len = strlen(val) + 1;
|
|
else
|
|
len = 0;
|
|
}
|
|
(*iov)[i].iov_len = (int)len;
|
|
*iovlen = ++i;
|
|
}
|
|
|
|
int
|
|
zmount(const char *spec, const char *dir, int mflag, char *fstype,
|
|
char *dataptr, int datalen, char *optptr, int optlen)
|
|
{
|
|
struct iovec *iov;
|
|
char *optstr, *os, *p, *tofree;
|
|
int iovlen, rv;
|
|
|
|
assert(spec != NULL);
|
|
assert(dir != NULL);
|
|
assert(mflag == 0 || mflag == MS_RDONLY);
|
|
assert(fstype != NULL);
|
|
assert(strcmp(fstype, MNTTYPE_ZFS) == 0);
|
|
assert(dataptr == NULL);
|
|
assert(datalen == 0);
|
|
assert(optptr != NULL);
|
|
assert(optlen > 0);
|
|
|
|
tofree = optstr = strdup(optptr);
|
|
assert(optstr != NULL);
|
|
|
|
iov = NULL;
|
|
iovlen = 0;
|
|
if (mflag & MS_RDONLY)
|
|
build_iovec(&iov, &iovlen, "ro", NULL, 0);
|
|
build_iovec(&iov, &iovlen, "fstype", fstype, (size_t)-1);
|
|
build_iovec(&iov, &iovlen, "fspath", __DECONST(char *, dir),
|
|
(size_t)-1);
|
|
build_iovec(&iov, &iovlen, "from", __DECONST(char *, spec), (size_t)-1);
|
|
while ((p = strsep(&optstr, ",/")) != NULL)
|
|
build_iovec(&iov, &iovlen, p, NULL, (size_t)-1);
|
|
rv = nmount(iov, iovlen, 0);
|
|
free(tofree);
|
|
return (rv);
|
|
}
|