FreeBSD src
Go to file
Konstantin Belousov 28e21133f3 Prevent leak of URWLOCK_READ_WAITERS flag for urwlocks.
If there was some error, e.g. the sleep was interrupted, as in the
referenced PR, do_rw_rdlock() did not cleared URWLOCK_READ_WAITERS.
Since unlock only wakes up write waiters when there is no read
waiters, for URWLOCK_PREFER_READER kind of locks, the result was
missed wakeups for writers.

In particular, the most visible victims are ld-elf.so locks in
processes which loaded libthr, because rtld locks are urwlocks in
prefer-reader mode.  Normal rwlocks fall into prefer-reader mode only
if thread already owns rw lock in read mode, which is not typical and
correspondingly less visible.  In the PR, unowned rtld bind lock was
waited for in the process where only one thread was left alive.

Note that do_rw_wrlock() correctly clears URWLOCK_WRITE_WAITERS in
case of errors.

Reported and tested by:	longwitz@incore.de
PR:	211947
Sponsored by:	The FreeBSD Foundation
MFC after:	1 week
2016-08-25 16:35:42 +00:00
bin Skip ls tests that use sparse files if these are not supported. 2016-08-24 10:10:26 +00:00
cddl fix bug introduced in r297521, set canmount=on doesn't mount filesystem 2016-08-20 09:12:01 +00:00
contrib MFV r304732. 2016-08-24 12:32:24 +00:00
crypto Build OpenSSL assembly sources for arm. Tested with Raspberry Pi 2 Model B. 2016-08-22 20:59:34 +00:00
etc Remove the gratuitous check for $FreeBSD$ and rename the function 2016-08-25 13:24:11 +00:00
gnu rename ARM's libunwind.S to to avoid conflict with llvm libunwind 2016-07-27 16:34:19 +00:00
include LC_*_MASK bit shifting order was partially broken from the initial commit 2016-08-23 20:33:56 +00:00
kerberos5 DIRDEPS_BUILD: Update dependencies 2016-06-14 16:55:05 +00:00
lib Don't build libdevdctl if MK_CXX is no 2016-08-24 17:15:32 +00:00
libexec Import Dragonfly Mail Agent snapshort from 20160806 aka v0.11+ 2016-08-20 16:36:05 +00:00
release Remove the ie(4) hardware list from the release documentation 2016-08-21 15:39:46 +00:00
rescue DIRDEPS_BUILD: Fix and hookup rescue/rescue to the build. 2016-05-26 23:20:40 +00:00
sbin Fix minor copy/paste bug. 2016-08-24 15:13:42 +00:00
secure Prefer C-style comments in assembly sources. 2016-08-22 21:49:17 +00:00
share Document the existence of the cloudabi32 kernel module. 2016-08-24 12:53:54 +00:00
sys Prevent leak of URWLOCK_READ_WAITERS flag for urwlocks. 2016-08-25 16:35:42 +00:00
targets Remove the wl(4) driver and wlconfig(8) utility. 2016-08-19 22:27:14 +00:00
tests Make use of Kyua's work directories. 2016-08-25 10:28:47 +00:00
tools The -f check here is used to determine whether we have a single kernel 2016-08-23 20:04:23 +00:00
usr.bin Capsicumize bspatch 2016-08-25 15:08:33 +00:00
usr.sbin Make the iSCSI parameter negotiation more flexible. 2016-08-25 05:22:53 +00:00
.arcconfig Remove project.name which is a product of a bygone era. 2016-04-21 04:33:07 +00:00
.arclint phabricator related changes: 2015-04-20 20:33:22 +00:00
COPYRIGHT Bump copyright year. 2015-12-31 11:21:45 +00:00
LOCKS Explicitly require Security Officer's approval for kernel PRNG bits. 2013-09-17 14:19:05 +00:00
MAINTAINERS Remove myself from kern_timeout.c yeah! 2016-07-27 20:37:32 +00:00
Makefile Avoid showing the bootstrap make command for check-old, etc. 2016-08-12 13:52:51 +00:00
Makefile.inc1 Fix in-tree GCC builds after r304681. 2016-08-23 19:29:37 +00:00
Makefile.libcompat Fix in-tree GCC builds after r304681. 2016-08-23 19:29:37 +00:00
ObsoleteFiles.inc Remove the ie(4) driver for Intel 82586 ISA Ethernet adapters. 2016-08-20 00:49:29 +00:00
README README: remove nonexistent 'games' directory. 2016-05-18 10:43:13 +00:00
UPDATING Bump __FreeBSD_version for r304787 and add a note about it to UPDATING. 2016-08-25 05:28:02 +00:00

This is the top level of the FreeBSD source directory.  This file
was last revised on:
$FreeBSD$

For copyright information, please see the file COPYRIGHT in this
directory (additional copyright information also exists for some
sources in this tree - please see the specific source directories for
more information).

The Makefile in this directory supports a number of targets for
building components (or all) of the FreeBSD source tree.  See build(7)
and http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/makeworld.html
for more information, including setting make(1) variables.

The `buildkernel` and `installkernel` targets build and install
the kernel and the modules (see below).  Please see the top of
the Makefile in this directory for more information on the
standard build targets and compile-time flags.

Building a kernel is a somewhat more involved process.  See build(7), config(8),
and http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/kernelconfig.html
for more information.

Note: If you want to build and install the kernel with the
`buildkernel` and `installkernel` targets, you might need to build
world before.  More information is available in the handbook.

The kernel configuration files reside in the sys/<arch>/conf
sub-directory.  GENERIC is the default configuration used in release builds.
NOTES contains entries and documentation for all possible
devices, not just those commonly used.


Source Roadmap:
---------------

bin		System/user commands.

cddl		Various commands and libraries under the Common Development
		and Distribution License.

contrib		Packages contributed by 3rd parties.

crypto		Cryptography stuff (see crypto/README).

etc		Template files for /etc.

gnu		Various commands and libraries under the GNU Public License.
		Please see gnu/COPYING* for more information.

include		System include files.

kerberos5	Kerberos5 (Heimdal) package.

lib		System libraries.

libexec		System daemons.

release		Release building Makefile & associated tools.

rescue		Build system for statically linked /rescue utilities.

sbin		System commands.

secure		Cryptographic libraries and commands.

share		Shared resources.

sys		Kernel sources.

tests		Regression tests which can be run by Kyua.  See tests/README
		for additional information.

tools		Utilities for regression testing and miscellaneous tasks.

usr.bin		User commands.

usr.sbin	System administration commands.


For information on synchronizing your source tree with one or more of
the FreeBSD Project's development branches, please see:

  http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/synching.html